Skip to content

Commit 1a8eea1

Browse files
committed
Add TODO comment
1 parent fba5ca2 commit 1a8eea1

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/mcpwm/operator.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,9 @@ where
6666
todo!()
6767
}
6868

69-
// TODO: make sure the peak related description is accurate
7069
/// Set duty as in the range 0 to timers peak value
70+
///
71+
/// NOTE: The compare value shouldn’t exceed timer’s count peak, otherwise, the compare event will never got triggered.
7172
pub fn set_duty_a(&mut self, duty: Duty) -> Result<(), EspError> {
7273
todo!()
7374
}
@@ -84,7 +85,7 @@ where
8485
todo!()
8586
}
8687

87-
/// Set duty as percentage between 0.0 and 100.0 for output B
88+
/// NOTE: The compare value shouldn’t exceed timer’s count peak, otherwise, the compare event will never got triggered.
8889
pub fn set_duty_b(&mut self, duty: Duty) -> Result<(), EspError> {
8990
todo!()
9091
}

src/mcpwm/timer.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ impl<const N: u8, G: Group> Timer<N, G> {
115115
}
116116
}
117117

118+
// TODO: make sure this description is accurate
118119
/// Get number of ticks per period
119120
///
120121
/// Use this when working with the frequency or the period
@@ -126,6 +127,7 @@ impl<const N: u8, G: Group> Timer<N, G> {
126127
self.period_ticks
127128
}
128129

130+
// TODO: make sure this description is accurate
129131
/// This is the maximum value that the comparator will see
130132
///
131133
/// Use this working with the duty

0 commit comments

Comments
 (0)