clippy

Author: ivmarkov

examples/http_request.rs

@@ -15,8 +15,8 @@ use esp_idf_sys::{self as _}; // If using the `binstart` feature of `esp-idf-sys
 
 use log::{error, info};
 
-const SSID: &'static str = env!("WIFI_SSID");
-const PASSWORD: &'static str = env!("WIFI_PASS");
+const SSID: &str = env!("WIFI_SSID");
+const PASSWORD: &str = env!("WIFI_PASS");
 
 fn main() -> anyhow::Result<()> {
     EspLogger::initialize_default();
@@ -55,7 +55,7 @@ fn get_request(client: &mut HttpClient<EspHttpConnection>) -> anyhow::Result<()>
     // Send request
     //
     // Note: If you don't want to pass in any headers, you can also use `client.get(url, headers)`.
-    let request = client.request(Method::Get, &url, &headers)?;
+    let request = client.request(Method::Get, url, &headers)?;
     info!("-> GET {}", url);
     let mut response = request.submit()?;
 
@@ -97,7 +97,7 @@ fn post_request(client: &mut HttpClient<EspHttpConnection>) -> anyhow::Result<()
     let url = "http://example.org/";
 
     // Send request
-    let mut request = client.post(&url, &headers)?;
+    let mut request = client.post(url, &headers)?;
     request.write_all(payload)?;
     request.flush()?;
     info!("-> POST {}", url);

examples/wifi.rs

@@ -10,8 +10,8 @@ use esp_idf_svc::{eventloop::EspSystemEventLoop, nvs::EspDefaultNvsPartition};
 use esp_idf_sys::{self as _}; // If using the `binstart` feature of `esp-idf-sys`, always keep this module imported
 use log::info;
 
-const SSID: &'static str = env!("WIFI_SSID");
-const PASSWORD: &'static str = env!("WIFI_PASS");
+const SSID: &str = env!("WIFI_SSID");
+const PASSWORD: &str = env!("WIFI_PASS");
 
 fn main() -> anyhow::Result<()> {
     EspLogger::initialize_default();

examples/wifi_async.rs

@@ -12,8 +12,8 @@ use esp_idf_sys::{self as _}; // If using the `binstart` feature of `esp-idf-sys
 use futures::executor::block_on;
 use log::info;
 
-const SSID: &'static str = env!("WIFI_SSID");
-const PASSWORD: &'static str = env!("WIFI_PASS");
+const SSID: &str = env!("WIFI_SSID");
+const PASSWORD: &str = env!("WIFI_PASS");
 
 fn main() -> anyhow::Result<()> {
     EspLogger::initialize_default();
@@ -26,7 +26,7 @@ fn main() -> anyhow::Result<()> {
     let mut wifi = AsyncWifi::wrap(
         EspWifi::new(peripherals.modem, sys_loop.clone(), Some(nvs))?,
         sys_loop,
-        timer_service.clone(),
+        timer_service,
     )?;
 
     block_on(connect_wifi(&mut wifi))?;

src/http/client.rs

@@ -223,10 +223,10 @@ impl EspHttpConnection {
                 }
             }
 
-            let c_name = to_cstring_arg(*name)?;
+            let c_name = to_cstring_arg(name)?;
 
             // TODO: Replace with a proper conversion from UTF8 to ISO-8859-1
-            let c_value = to_cstring_arg(*value)?;
+            let c_value = to_cstring_arg(value)?;
 
             esp!(unsafe {
                 esp_http_client_set_header(

src/http/server.rs

@@ -654,20 +654,20 @@ impl<'a> EspHttpConnection<'a> {
 
         for (key, value) in headers {
             if key.eq_ignore_ascii_case("Content-Type") {
-                let c_type = to_cstring_arg(*value)?;
+                let c_type = to_cstring_arg(value)?;
 
                 esp!(unsafe { httpd_resp_set_type(self.request.0, c_type.as_c_str().as_ptr()) })?;
 
                 c_headers.push(c_type);
             } else if key.eq_ignore_ascii_case("Content-Length") {
-                let c_len = to_cstring_arg(*value)?;
+                let c_len = to_cstring_arg(value)?;
 
                 //esp!(unsafe { httpd_resp_set_len(self.raw_req, c_len.as_c_str().as_ptr()) })?;
 
                 c_headers.push(c_len);
             } else {
-                let name = to_cstring_arg(*key)?;
-                let value = to_cstring_arg(*value)?;
+                let name = to_cstring_arg(key)?;
+                let value = to_cstring_arg(value)?;
 
                 esp!(unsafe {
                     httpd_resp_set_hdr(

src/sntp.rs

@@ -214,7 +214,7 @@ impl EspSntp {
 
         let mut c_servers: [CString; SNTP_SERVER_NUM] = Default::default();
         for (i, s) in conf.servers.iter().enumerate() {
-            let c_server = to_cstring_arg(*s)?;
+            let c_server = to_cstring_arg(s)?;
             unsafe { sntp_setservername(i as u8, c_server.as_ptr()) };
             c_servers[i] = c_server;
         }