Skip to content

Commit 092a637

Browse files
committed
Override the flash size in Flasher if provided via command-line argument
1 parent d9f8f8b commit 092a637

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

cargo-espflash/src/main.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,17 @@ fn flash(args: FlashArgs, config: &Config) -> Result<()> {
158158
let cargo_config = CargoConfig::load(&metadata.workspace_root, &metadata.package_root);
159159

160160
let mut flasher = connect(&args.connect_args, config)?;
161+
162+
// If the user has provided a flash size via a command-line argument, we'll
163+
// override the detected (or default) value with this.
164+
if let Some(flash_size) = args.build_args.flash_config_args.flash_size {
165+
flasher.set_flash_size(flash_size);
166+
}
167+
161168
let chip = flasher.chip();
162169
let target = chip.into_target();
163170
let target_xtal_freq = target.crystal_freq(flasher.connection())?;
171+
164172
flasher.disable_watchdog()?;
165173

166174
let build_ctx =

espflash/src/bin/espflash.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ fn main() -> Result<()> {
119119

120120
fn flash(args: FlashArgs, config: &Config) -> Result<()> {
121121
let mut flasher = connect(&args.connect_args, config)?;
122+
123+
// If the user has provided a flash size via a command-line argument, we'll
124+
// override the detected (or default) value with this.
125+
if let Some(flash_size) = args.flash_config_args.flash_size {
126+
flasher.set_flash_size(flash_size);
127+
}
128+
122129
print_board_info(&mut flasher)?;
123130

124131
let chip = flasher.chip();

espflash/src/flasher/mod.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,10 @@ impl Flasher {
401401
Ok(flasher)
402402
}
403403

404+
pub fn set_flash_size(&mut self, flash_size: FlashSize) {
405+
self.flash_size = flash_size;
406+
}
407+
404408
pub fn disable_watchdog(&mut self) -> Result<(), Error> {
405409
let mut target = self.chip.flash_target(self.spi_params, self.use_stub);
406410
target.begin(&mut self.connection).flashing()?;

0 commit comments

Comments
 (0)