fix warnings and make CI fail on warnings (#887)

Author: JurajSadel

.github/workflows/ci.yml

@@ -86,8 +86,8 @@ jobs:
           arch: ${{ matrix.platform.arch }}
           target: ${{ matrix.platform.target }}
 
-      - run: cargo check -p espflash --lib --no-default-features
-      - run: cargo check -p espflash --lib --no-default-features --features serialport
+      - run: RUSTFLAGS="-D warnings" cargo check -p espflash --lib --no-default-features
+      - run: RUSTFLAGS="-D warnings" cargo check -p espflash --lib --no-default-features --features serialport
 
   msrv:
     name: Check lib MSRV  (${{ matrix.platform.target }})

espflash/src/flasher/mod.rs

@@ -4,9 +4,11 @@
 //! application to a target device. It additionally provides some operations to
 //! read information from the target device.
 
+#[cfg(feature = "serialport")]
+use std::fs::OpenOptions;
 #[cfg(feature = "serialport")]
 use std::{borrow::Cow, io::Write, path::PathBuf, thread::sleep, time::Duration};
-use std::{collections::HashMap, fmt, fs::OpenOptions, str::FromStr};
+use std::{collections::HashMap, fmt, str::FromStr};
 
 #[cfg(feature = "serialport")]
 use log::{debug, info, warn};

espflash/src/image_format/mod.rs

@@ -1,7 +1,5 @@
 //! Binary application image formats
 
-#[cfg(not(feature = "cli"))]
-use std::path::PathBuf;
 use std::{
     borrow::Cow,
     cmp::Ordering,

espflash/src/targets/esp32.rs

@@ -1,9 +1,10 @@
 use std::ops::Range;
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32 as efuse};
-use crate::Error;
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32 as efuse};
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 0;
 

espflash/src/targets/esp32c2.rs

@@ -1,9 +1,11 @@
 use std::{collections::HashMap, ops::Range};
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32c2 as efuse};
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
-use crate::{Error, flasher::FlashFrequency};
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32c2 as efuse};
+use crate::flasher::FlashFrequency;
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 12;
 

espflash/src/targets/esp32c3.rs

@@ -1,9 +1,10 @@
 use std::ops::Range;
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32c3 as efuse};
-use crate::Error;
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32c3 as efuse};
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 5;
 

espflash/src/targets/esp32c5.rs

@@ -1,9 +1,10 @@
 use std::ops::Range;
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32c5 as efuse};
-use crate::Error;
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32c5 as efuse};
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 23;
 

espflash/src/targets/esp32c6.rs

@@ -1,9 +1,10 @@
 use std::ops::Range;
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32c6 as efuse};
-use crate::Error;
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32c6 as efuse};
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 13;
 

espflash/src/targets/esp32h2.rs

@@ -1,9 +1,11 @@
 use std::{collections::HashMap, ops::Range};
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32h2 as efuse};
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
-use crate::{Error, flasher::FlashFrequency};
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32h2 as efuse};
+use crate::flasher::FlashFrequency;
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 16;
 

espflash/src/targets/esp32p4.rs

@@ -1,9 +1,10 @@
 use std::ops::Range;
 
-use super::{Chip, ReadEFuse, SpiRegisters, Target, XtalFrequency, efuse::esp32p4 as efuse};
-use crate::Error;
 #[cfg(feature = "serialport")]
-use crate::connection::Connection;
+use super::XtalFrequency;
+use super::{Chip, ReadEFuse, SpiRegisters, Target, efuse::esp32p4 as efuse};
+#[cfg(feature = "serialport")]
+use crate::{Error, connection::Connection};
 
 pub(crate) const CHIP_ID: u16 = 18;