Skip to content

Commit 868fbfe

Browse files
icewind1991jessebraham
authored andcommitted
disable software flowcontrol for serial
1 parent 591e092 commit 868fbfe

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

cargo-espflash/src/main.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use espflash::{Config, Flasher, PartitionTable};
66
use miette::{IntoDiagnostic, Result, WrapErr};
77
use monitor::monitor;
88
use package_metadata::CargoEspFlashMeta;
9-
use serial::{BaudRate, SerialPort};
9+
use serial::{BaudRate, FlowControl, SerialPort};
1010
use std::{
1111
fs,
1212
path::PathBuf,
@@ -137,6 +137,7 @@ fn main() -> Result<()> {
137137
.wrap_err_with(|| format!("Failed to open serial port {}", port))?;
138138
serial
139139
.reconfigure(&|settings| {
140+
settings.set_flow_control(FlowControl::FlowNone);
140141
settings.set_baud_rate(BaudRate::Baud115200)?;
141142
Ok(())
142143
})

espflash/src/connection.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ impl Connection {
5656

5757
sleep(Duration::from_millis(50));
5858

59-
self.serial.set_dtr(true)?;
59+
self.serial.set_dtr(false)?;
6060

6161
Ok(())
6262
}

espflash/src/main.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use std::fs::read;
33
use espflash::{Config, Error, Flasher};
44
use miette::{IntoDiagnostic, Result, WrapErr};
55
use pico_args::Arguments;
6-
use serial::{BaudRate, SerialPort};
6+
use serial::{BaudRate, FlowControl, SerialPort};
77

88
#[allow(clippy::unnecessary_wraps)]
99
fn help() -> Result<()> {
@@ -40,6 +40,7 @@ fn main() -> Result<()> {
4040
.wrap_err_with(|| format!("Failed to open serial port {}", serial))?;
4141
serial
4242
.reconfigure(&|settings| {
43+
settings.set_flow_control(FlowControl::FlowNone);
4344
settings.set_baud_rate(BaudRate::Baud115200)?;
4445

4546
Ok(())

0 commit comments

Comments
 (0)