Skip to content

Commit a5efcb7

Browse files
committed
Address review comments
1 parent c330b9d commit a5efcb7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

cargo-espflash/src/main.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ fn flash(args: FlashArgs, config: &Config) -> Result<()> {
323323
build(&args.build_args, &cargo_config, chip).wrap_err("Failed to build project")?;
324324

325325
// Read the ELF data from the build path and load it to the target.
326-
let elf_data = fs::read(build_ctx.artifact_path).into_diagnostic()?;
326+
let elf_data = fs::read(build_ctx.artifact_path.clone()).into_diagnostic()?;
327327

328328
print_board_info(&mut flasher)?;
329329

@@ -368,8 +368,8 @@ fn flash(args: FlashArgs, config: &Config) -> Result<()> {
368368
args.flash_args.monitor_baud.unwrap_or(default_baud),
369369
args.flash_args.log_format,
370370
true,
371-
None,
372-
None,
371+
args.flash_args.processors,
372+
Some(build_ctx.artifact_path),
373373
)
374374
} else {
375375
Ok(())

espflash/src/bin/espflash.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ pub struct Cli {
3030
subcommand: Commands,
3131

3232
/// Do not check for updates
33-
#[clap(long, global = true, action)]
33+
#[clap(short = 'S', long, global = true, action)]
3434
skip_update_check: bool,
3535
}
3636

0 commit comments

Comments
 (0)