-
Notifications
You must be signed in to change notification settings - Fork 146
Change long form of save-image --ignore-app-descriptor #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SergioGasquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, and it's something we definitely want to do, but this would be considered a breaking change that requires a major bump. We could support both ignore_app_descriptor and ignore-app-descriptor or just wait and merge this when working towards v5.
SergioGasquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you modify this PR to support both ignore_app_descriptor and ignore-app-descriptor while adding a TODO that the underscore version should be removed for v5??
|
I've used |
SergioGasquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A visible_alias should be fine, thanks!
Solves #973