Skip to content

[Bug] Incorrect handling of required parameters for epaper_spi component #2643

Description

@kepstin

What happened?

The epaper_spi component has some fields where whether the field is required depends on the selected value of other parameters. In particular:

  • If you select a model which is a bare controller, like SSD1683, you need to specify cs_pin, dc_pin, and dimensions.
  • If you select a model which is a specific screen, like WAVESHARE-2.13IN-V3, you need to specify cs_pin and dc_pin, but you do not need to specify dimensions, since the screen model defines dimensions.
  • If you select a model which is a preset for a device, like INKPLATE6COLOR, you are not required to specify any of cs_pin, dc_pin, or dimensions because they are all defined by the model.

Unfortunately, in the latter two cases, the add component wizard does not allow you to submit the form, because it thinks that the some of the fields are required when they actually are not required.

Dashboard version

git 0.1.0b8-1714-g408d3f81

How did you install it?

From source (script/setup)

Where is it running?

Local — Linux

Device YAML config

not device specific

Relevant logs / errors

Anything else?

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions