Fixes EventProcedures TotalAmountCents specs. Fixes TotalAmountCents to corretly return when its more then 1 kind of procedure

Author: mattfeg

app/operations/event_procedures/total_amount_cents.rb

@@ -21,19 +21,42 @@ def convert_money(amount_cents)
     end
 
     def calculate_total(user_procedures)
-      convert_money(user_procedures.sum(&:amount_cents))
+      procedures_by_id = {}
+      user_procedures.each do |procedure|
+        procedures_by_id[procedure.id] = procedure
+      end
+      total = 0
+      event_procedures.each do |event_procedure|
+        procedure = procedures_by_id[event_procedure.procedure_id]
+        total += procedure.amount_cents if procedure
+      end
+      convert_money(total)
     end
 
     def calculate_payd(user_procedures)
-      payd_procedures_ids = event_procedures.select(&:payd).pluck(:procedure_id)
-      payd_procedures = user_procedures.where(id: payd_procedures_ids)
-      convert_money(payd_procedures.sum(&:amount_cents))
+      procedures_by_id = {}
+      user_procedures.each do |procedure|
+        procedures_by_id[procedure.id] = procedure
+      end
+      total = 0
+      event_procedures.select(&:payd).each do |event_procedure|
+        procedure = procedures_by_id[event_procedure.procedure_id]
+        total += procedure.amount_cents if procedure
+      end
+      convert_money(total)
     end
 
     def calculate_unpayd(user_procedures)
-      unpayd_procudures_ids = event_procedures.reject(&:payd).pluck(:procedure_id)
-      unpayd_procudures = user_procedures.where(id: unpayd_procudures_ids)
-      convert_money(unpayd_procudures.sum(&:amount_cents))
+      procedures_by_id = {}
+      user_procedures.each do |procedure|
+        procedures_by_id[procedure.id] = procedure
+      end
+      total = 0
+      event_procedures.reject(&:payd).each do |event_procedure|
+        procedure = procedures_by_id[event_procedure.procedure_id]
+        total += procedure.amount_cents if procedure
+      end
+      convert_money(total)
     end
   end
 end

spec/operations/event_procedures/total_amount_cents_spec.rb

@@ -6,91 +6,31 @@
   describe ".result" do
     it "is successful" do
       user = create(:user)
-
-      expect(described_class.result(user_id: user.id, month: nil, year: nil)).to be_success
+      event_procedure = create(:event_procedure, user_id: user.id)
+      expect(described_class.result(event_procedures: [event_procedure])).to be_success
     end
 
     it "returns the amount_cents total, paid and unpaid of event_procedures" do
       user = create(:user)
-      _payd_amount_cents = create_list(
+      procedure_5000 = create(:procedure, amount_cents: 5000)
+      procedure_2000 = create(:procedure, amount_cents: 2000)
+      payd_amount_cents = create_list(
         :event_procedure, 3,
-        procedure: create(:procedure, amount_cents: 5000),
+        procedure: procedure_5000,
         user: user,
         payd: true
       )
-      _unpayd_event_procedure = create(
-        :event_procedure,
-        procedure: create(:procedure, amount_cents: 2000),
+      unpayd_event_procedure = create_list(
+        :event_procedure, 2,
+        procedure: procedure_2000,
         user: user,
         payd: false
       )
-      total_amount_cents = described_class.call(user_id: user.id, month: nil, year: nil)
-
-      expect(total_amount_cents.total).to eq("R$170.00")
+      event_procedures = payd_amount_cents + unpayd_event_procedure
+      total_amount_cents = described_class.call(event_procedures: event_procedures)
+      expect(total_amount_cents.total).to eq("R$190.00")
       expect(total_amount_cents.payd).to eq("R$150.00")
-      expect(total_amount_cents.unpaid).to eq("R$20.00")
-    end
-
-    it "calculates the total, payd, and unpaid amounts for a specific month" do
-      user = create(:user)
-      procedure_1000 = create(:procedure, amount_cents: 1000)
-      procedure_2000 = create(:procedure, amount_cents: 2000)
-
-      _event_procedure_jan = create(
-        :event_procedure, procedure: procedure_1000,
-        date: "31/01/2023",
-        payd: true,
-        user: user
-      )
-      _payd_event_procedure_feb = create(
-        :event_procedure, procedure: procedure_2000,
-        date: "25/02/2023",
-        payd: true,
-        user: user
-      )
-      _unpayd_event_procedure_feb = create(
-        :event_procedure, procedure: procedure_1000,
-        date: "25/02/2023",
-        payd: false,
-        user: user
-      )
-
-      total_amount_cents = described_class.call(user_id: user.id, month: "2", year: nil)
-
-      expect(total_amount_cents.total).to eq("R$30.00")
-      expect(total_amount_cents.payd).to eq("R$20.00")
-      expect(total_amount_cents.unpaid).to eq("R$10.00")
-    end
-
-    it "calculates the total, payd, and unpaid amounts for a specific year" do
-      user = create(:user)
-      procedure_1000 = create(:procedure, amount_cents: 1000)
-      procedure_2000 = create(:procedure, amount_cents: 2000)
-
-      _event_procedure_2023 = create(
-        :event_procedure, procedure: procedure_1000,
-        date: "31/01/2023",
-        payd: true,
-        user: user
-      )
-      _payd_event_procedure_2024 = create(
-        :event_procedure, procedure: procedure_2000,
-        date: "25/02/2024",
-        payd: true,
-        user: user
-      )
-      _unpayd_event_procedure_2024 = create(
-        :event_procedure, procedure: procedure_1000,
-        date: "25/02/2024",
-        payd: false,
-        user: user
-      )
-
-      total_amount_cents = described_class.call(user_id: user.id, month: nil, year: "2024")
-
-      expect(total_amount_cents.total).to eq("R$30.00")
-      expect(total_amount_cents.payd).to eq("R$20.00")
-      expect(total_amount_cents.unpaid).to eq("R$10.00")
+      expect(total_amount_cents.unpaid).to eq("R$40.00")
     end
   end
 end

spec/pdfs/event_procedures_report_pdf_spec.rb

@@ -6,8 +6,8 @@
   it "generates a report with the correct content" do
     user = create(:user)
     pdf = Prawn::Document.new
-    amount = EventProcedures::TotalAmountCents.call(user_id: user.id, month: nil, year: nil)
     event_procedures = create_list(:event_procedure, 3, user_id: user.id)
+    amount = EventProcedures::TotalAmountCents.call(event_procedures: event_procedures)
 
     described_class.new(
       pdf: pdf, amount: amount, items: event_procedures, title: "Procedimentos", email: user.email

spec/pdfs/footer_pdf_spec.rb

@@ -5,11 +5,9 @@
 RSpec.describe FooterPdf, type: :pdf do
   it "generates a footer with the correct content" do
     user = create(:user)
-    create_list(:event_procedure, 3, user_id: user.id)
+    event_procedures = create_list(:event_procedure, 3, user_id: user.id)
     total_amount_cents = EventProcedures::TotalAmountCents.call(
-      user_id: user.id,
-      month: nil,
-      year: nil
+      event_procedures: event_procedures
     )
     pdf = Prawn::Document.new
 

spec/services/pdf_generator_service_spec.rb

@@ -8,7 +8,7 @@
       it "generates event_procedures pdf" do
         user = create(:user)
         event_procedures = create_list(:event_procedure, 11)
-        amount = EventProcedures::TotalAmountCents.call(user_id: event_procedures.first.user_id, month: nil, year: nil)
+        amount = EventProcedures::TotalAmountCents.call(event_procedures: event_procedures)
         pdf = described_class.new(
           relation: event_procedures, amount: amount, entity_name: "event_procedures", email: user.email
         ).generate_pdf