Last line gets ignored when converting if the file doesn't end in a newline

[gtkacz]

The last line of the Makefile will ofter get ignored when converting.

Step-by-step on how to replicate:

1. pip install make-to-batch==0.2.3
2. Create a Makefile containing:

build:
	docker-compose up --build

up:
	docker-compose up

This will generate a make.bat file with the following:

@echo off


IF /I "%1"=="build" GOTO build
IF /I "%1"=="up" GOTO up
GOTO error

:build
	docker-compose up --build
	GOTO :EOF

:up
	GOTO :EOF

:error
    IF "%1"=="" (
        ECHO make: *** No targets specified and no makefile found.  Stop.
    ) ELSE (
        ECHO make: *** No rule to make target '%1%'. Stop.
    )
    GOTO :EOF

Where the up command is empty.

3. Alter the Makefile to have a newline below the last command, and the make.bat file is generated properly.

[espositoandrea]

Hi! Thanks for this issue. Usually the newline at end-of-file is required by Unix (POSIX define a "line" as ending in a \n).

To be sure about what's the issue: is the Makefile that doesn't work properly like this (note the \n)

build:\n
	docker-compose up --build\n
\n
up:\n
	docker-compose up

or like this?

build:\n
	docker-compose up --build\n
\n
up:\n
	docker-compose up\n

If it's the last version, it's a bug and I'll look into it. Otherwise, it's a mal-formed Makefile: I could still check to make it work but I have to make sure that I don't break anything! Thanks.

[gtkacz]

Hello Andrea, thanks for the swift reply! It is indeed the first example. You're right as in POSIX defines a "line" as ending in \n, however, that is not explicitly required for a Makefile to work, as the Makefile I provided works, and there is no mention of such in: https://www.gnu.org/software/make/manual/make.html#Parsing-Makefiles. Should we treat this or force the user to comply to Makefile best-practices? Thanks for your time!

[espositoandrea]

Hi! I suppose that no one will really care that we are going against a POSIX recommendation as long as it does not break anything anywhere! I think we can safely try and check where the issue preventing the parsing of the last line is!