Skip to content

Commit 122609f

Browse files
lucasssvazlucasssvaz
committed
Merge branch 'ci/default_partition' into test/psram
2 parents 96c79b3 + 613536a commit 122609f

File tree

21 files changed

+148
-132
lines changed

21 files changed

+148
-132
lines changed

‎.github/scripts/install-platformio-esp32.sh‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ PLATFORMIO_ESP32_URL="https://github.com/platformio/platform-espressif32.git"
66
TOOLCHAIN_VERSION="12.2.0+20230208"
77
ESPTOOLPY_VERSION="~1.40501.0"
88
ESPRESSIF_ORGANIZATION_NAME="espressif"
9-
LIBS_DIR="tools/esp32-arduino-libs"
9+
SDKCONFIG_DIR="$PLATFORMIO_ESP32_PATH/tools/esp32-arduino-libs"
1010

1111
echo "Installing Python Wheel ..."
1212
pip install wheel > /dev/null 2>&1
@@ -100,7 +100,8 @@ function count_sketches(){ # count_sketches <examples-path>
100100
requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
101101
if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
102102
for requirement in $requirements; do
103-
found_line=$(grep -E "^$requirement" $LIBS_DIR/esp32/sdkconfig)
103+
requirement=$(echo $requirement | xargs)
104+
found_line=$(grep -E "^$requirement" "$SDKCONFIG_DIR/esp32/sdkconfig")
104105
if [[ "$found_line" == "" ]]; then
105106
continue 2
106107
fi
@@ -190,7 +191,8 @@ function build_pio_sketches(){ # build_pio_sketches <board> <options> <examples-
190191
requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
191192
if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
192193
for requirement in $requirements; do
193-
found_line=$(grep -E "^$requirement" $LIBS_DIR/esp32/sdkconfig)
194+
requirement=$(echo $requirement | xargs)
195+
found_line=$(grep -E "^$requirement" "$SDKCONFIG_DIR/esp32/sdkconfig")
194196
if [[ "$found_line" == "" ]]; then
195197
continue 2
196198
fi

‎.github/scripts/sketch_utils.sh‎

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
LIBS_DIR="tools/esp32-arduino-libs"
3+
SDKCONFIG_DIR="$ARDUINO_ESP32_PATH/tools/esp32-arduino-libs"
44

55
function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [extra-options]
66
while [ ! -z "$1" ]; do
@@ -83,14 +83,21 @@ function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [ex
8383

8484
len=1
8585

86+
if [ -f $sketchdir/ci.json ]; then
87+
fqbn_append=`jq -r '.fqbn_append' $sketchdir/ci.json`
88+
if [ $fqbn_append == "null" ]; then
89+
fqbn_append=""
90+
fi
91+
fi
92+
8693
# Default FQBN options if none were passed in the command line.
8794

88-
esp32_opts="PSRAM=enabled,PartitionScheme=huge_app,FlashMode=dio"
89-
esp32s2_opts="PSRAM=enabled,PartitionScheme=huge_app,FlashMode=dio"
90-
esp32s3_opts="PSRAM=opi,USBMode=default,PartitionScheme=huge_app,FlashMode=dio"
91-
esp32c3_opts="PartitionScheme=huge_app,FlashMode=dio"
92-
esp32c6_opts="PartitionScheme=huge_app,FlashMode=dio"
93-
esp32h2_opts="PartitionScheme=huge_app,FlashMode=dio"
95+
esp32_opts="PSRAM=enabled,FlashMode=dio${fqbn_append:+,$fqbn_append}"
96+
esp32s2_opts="PSRAM=enabled,FlashMode=dio${fqbn_append:+,$fqbn_append}"
97+
esp32s3_opts="PSRAM=opi,USBMode=default,FlashMode=dio${fqbn_append:+,$fqbn_append}"
98+
esp32c3_opts="FlashMode=dio${fqbn_append:+,$fqbn_append}"
99+
esp32c6_opts="FlashMode=dio${fqbn_append:+,$fqbn_append}"
100+
esp32h2_opts="FlashMode=dio${fqbn_append:+,$fqbn_append}"
94101

95102
# Select the common part of the FQBN based on the target. The rest will be
96103
# appended depending on the passed options.
@@ -154,7 +161,8 @@ function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [ex
154161
requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
155162
if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
156163
for requirement in $requirements; do
157-
found_line=$(grep -E "^$requirement" $LIBS_DIR/$target/sdkconfig)
164+
requirement=$(echo $requirement | xargs)
165+
found_line=$(grep -E "^$requirement" "$SDKCONFIG_DIR/$target/sdkconfig")
158166
if [[ "$found_line" == "" ]]; then
159167
echo "Target $target does not meet the requirement $requirement for $sketchname. Skipping."
160168
exit 0
@@ -310,7 +318,8 @@ function count_sketches(){ # count_sketches <path> [target] [file]
310318
requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
311319
if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
312320
for requirement in $requirements; do
313-
found_line=$(grep -E "^$requirement" $LIBS_DIR/$target/sdkconfig)
321+
requirement=$(echo $requirement | xargs)
322+
found_line=$(grep -E "^$requirement" $SDKCONFIG_DIR/$target/sdkconfig)
314323
if [[ "$found_line" == "" ]]; then
315324
continue 2
316325
fi

‎.github/scripts/tests_run.sh‎

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,15 @@ function run_test() {
1010
local result=0
1111
local error=0
1212

13+
if [ $options -eq 0 ] && [ -f $sketchdir/ci.json ]; then
14+
len=`jq -r --arg target $target '.fqbn[$target] | length' $sketchdir/ci.json`
15+
if [ $len -eq 0 ]; then
16+
len=1
17+
fi
18+
else
19+
len=1
20+
fi
21+
1322
if [ -f $sketchdir/ci.json ]; then
1423
# If the target or platform is listed as false, skip the sketch. Otherwise, include it.
1524
is_target=$(jq -r --arg target $target '.targets[$target]' $sketchdir/ci.json)
@@ -21,11 +30,22 @@ function run_test() {
2130
return 0
2231
fi
2332

33+
if [ -d $ARDUINO_ESP32_PATH/tools/esp32-arduino-libs ]; then
34+
SDKCONFIG_PATH="$ARDUINO_ESP32_PATH/tools/esp32-arduino-libs/$target/sdkconfig"
35+
else
36+
if [ $len -eq 1 ]; then
37+
SDKCONFIG_PATH="$HOME/.arduino/tests/$sketchname/build.tmp/sdkconfig"
38+
else
39+
SDKCONFIG_PATH="$HOME/.arduino/tests/$sketchname/build0.tmp/sdkconfig"
40+
fi
41+
fi
42+
2443
# Check if the sketch requires any configuration options
2544
requirements=$(jq -r '.requires[]? // empty' $sketchdir/ci.json)
2645
if [[ "$requirements" != "null" ]] || [[ "$requirements" != "" ]]; then
2746
for requirement in $requirements; do
28-
found_line=$(grep -E "^$requirement" $LIBS_DIR/$target/sdkconfig)
47+
requirement=$(echo $requirement | xargs)
48+
found_line=$(grep -E "^$requirement" "$SDKCONFIG_PATH")
2949
if [[ "$found_line" == "" ]]; then
3050
printf "\033[93mTarget $target does not meet the requirement $requirement for $sketchname. Skipping.\033[0m\n"
3151
printf "\n\n\n"
@@ -35,15 +55,6 @@ function run_test() {
3555
fi
3656
fi
3757

38-
if [ $options -eq 0 ] && [ -f $sketchdir/ci.json ]; then
39-
len=`jq -r --arg target $target '.fqbn[$target] | length' $sketchdir/ci.json`
40-
if [ $len -eq 0 ]; then
41-
len=1
42-
fi
43-
else
44-
len=1
45-
fi
46-
4758
if [ $len -eq 1 ]; then
4859
# build_dir="$sketchdir/build"
4960
build_dir="$HOME/.arduino/tests/$sketchname/build.tmp"
@@ -120,7 +131,6 @@ function run_test() {
120131

121132
SCRIPTS_DIR="./.github/scripts"
122133
COUNT_SKETCHES="${SCRIPTS_DIR}/sketch_utils.sh count"
123-
LIBS_DIR="tools/esp32-arduino-libs"
124134

125135
platform="hardware"
126136
wokwi_timeout=60000

‎.github/workflows/tests_build.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ jobs:
7575
~/.arduino/tests/**/build*.tmp/*.bin
7676
~/.arduino/tests/**/build*.tmp/*.elf
7777
~/.arduino/tests/**/build*.tmp/*.json
78+
~/.arduino/tests/**/build*.tmp/sdkconfig
7879
7980
- name: Upload ${{ inputs.chip }} ${{ inputs.type }} binaries as artifacts
8081
uses: actions/upload-artifact@v4
@@ -85,3 +86,4 @@ jobs:
8586
~/.arduino/tests/**/build*.tmp/*.bin
8687
~/.arduino/tests/**/build*.tmp/*.elf
8788
~/.arduino/tests/**/build*.tmp/*.json
89+
~/.arduino/tests/**/build*.tmp/sdkconfig

‎cores/esp32/esp32-hal-misc.c‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,13 +251,11 @@ extern bool btInUse();
251251
#endif
252252

253253
#if CONFIG_SPIRAM_SUPPORT || CONFIG_SPIRAM
254-
#ifndef CONFIG_SPIRAM_BOOT_INIT
255254
ESP_SYSTEM_INIT_FN(init_psram_new, BIT(0), 99) {
256255
psramInit();
257256
return ESP_OK;
258257
}
259258
#endif
260-
#endif
261259

262260
void initArduino() {
263261
//init proper ref tick value for PLL (uncomment if REF_TICK is different than 1MHz)

‎docs/en/contributing.rst‎

Lines changed: 43 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,47 @@ And in the ``README.md`` file:
166166
167167
Currently, this example requires Wi-Fi and supports the following targets.
168168
169-
| Supported Targets | ESP32 | ESP32-H2 | ESP32-S3 | ESP32-C3 | ESP32-C6 |
170-
| ----------------- | ----- | -------- | -------- | -------- | -------- |
169+
| Supported Targets | ESP32 | ESP32-S3 | ESP32-C3 | ESP32-C6 |
170+
| ----------------- | ----- | -------- | -------- | -------- |
171+
172+
By default, the CI system will use the FQBNs specified in the ``.github/scripts/sketch_utils.sh`` file to compile the sketches.
173+
Currently, the default FQBNs are:
174+
175+
* ``espressif:esp32:esp32:PSRAM=enabled,FlashMode=dio``
176+
* ``espressif:esp32:esp32s2:PSRAM=enabled,FlashMode=dio``
177+
* ``espressif:esp32:esp32s3:PSRAM=opi,USBMode=default,FlashMode=dio``
178+
* ``espressif:esp32:esp32c3:FlashMode=dio``
179+
* ``espressif:esp32:esp32c6:FlashMode=dio``
180+
* ``espressif:esp32:esp32h2:FlashMode=dio``
181+
182+
There are two ways to alter the FQBNs used to compile the sketches: by using the ``fqbn`` or ``fqbn_append`` fields in the ``ci.json`` file.
183+
184+
If you just want to append a string to the default FQBNs, you can use the ``fqbn_append`` field. For example, to add the ``DebugLevel=debug`` to the FQBNs, you would use:
185+
186+
.. code-block:: json
187+
188+
{
189+
"fqbn_append": "DebugLevel=debug"
190+
}
191+
192+
If you want to override the default FQBNs, you can use the ``fqbn`` field. It is a dictionary where the key is the target name and the value is a list of FQBNs.
193+
The FQBNs in the list will be used in sequence to compile the sketch. For example, to compile a sketch for ESP32-S2 with and without PSRAM enabled, you would use:
194+
195+
.. code-block:: json
196+
197+
{
198+
"fqbn": {
199+
"esp32s2": [
200+
"espressif:esp32:esp32s2:PSRAM=enabled,FlashMode=dio",
201+
"espressif:esp32:esp32s2:PSRAM=disabled,FlashMode=dio"
202+
]
203+
}
204+
}
205+
206+
.. note::
207+
208+
The FQBNs specified in the ``fqbn`` field will also override the options specified in the ``fqbn_append`` field.
209+
That means that if the ``fqbn`` field is specified, the ``fqbn_append`` field will be ignored and will have no effect.
171210

172211
Example Template
173212
****************
@@ -376,9 +415,10 @@ The ``ci.json`` file is used to specify how the test suite and sketches will han
376415
* ``platforms``: A dictionary that specifies the supported platforms. The key is the platform name and the value is a boolean that specifies if
377416
the platform is supported. By default, all platforms are assumed to be supported.
378417
* ``extra_tags``: A list of extra tags that the runner will require when running the test suite in hardware. By default, no extra tags are required.
418+
* ``fqbn_append``: A string to be appended to the default FQBNs. By default, no string is appended. This has no effect if ``fqbn`` is specified.
379419
* ``fqbn``: A dictionary that specifies the FQBNs that will be used to compile the sketch. The key is the target name and the value is a list
380420
of FQBNs. The `default FQBNs <https://github.com/espressif/arduino-esp32/blob/a31a5fca1739993173caba995f7785b8eed6b30e/.github/scripts/sketch_utils.sh#L86-L91>`_
381-
are used if this field is not specified.
421+
are used if this field is not specified. This overrides the default FQBNs and the ``fqbn_append`` field.
382422

383423
The ``wifi`` test suite is a good example of how to use the ``ci.json`` file:
384424

‎libraries/ESP32/examples/Camera/CameraWebServer/ci.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,19 @@
11
{
2+
"fqbn": {
3+
"esp32": [
4+
"espressif:esp32:esp32:PSRAM=enabled,PartitionScheme=custom,FlashMode=dio",
5+
"espressif:esp32:esp32:PSRAM=disabled,PartitionScheme=custom,FlashMode=dio"
6+
],
7+
"esp32s2": [
8+
"espressif:esp32:esp32s2:PSRAM=enabled,PartitionScheme=custom,FlashMode=dio",
9+
"espressif:esp32:esp32s2:PSRAM=disabled,PartitionScheme=custom,FlashMode=dio"
10+
],
11+
"esp32s3": [
12+
"espressif:esp32:esp32s3:PSRAM=opi,USBMode=default,PartitionScheme=custom,FlashMode=qio",
13+
"espressif:esp32:esp32s3:PSRAM=enabled,USBMode=default,PartitionScheme=custom,FlashMode=qio",
14+
"espressif:esp32:esp32s3:PSRAM=disabled,USBMode=default,PartitionScheme=custom,FlashMode=qio"
15+
]
16+
},
217
"requires": [
318
"CONFIG_CAMERA_TASK_STACK_SIZE=[0-9]+"
419
]

‎libraries/ESP32/examples/Camera/CameraWebServer/partitions.csv‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Name, Type, SubType, Offset, Size, Flags
22
nvs, data, nvs, 0x9000, 0x5000,
33
otadata, data, ota, 0xe000, 0x2000,
4-
app0, app, ota_0, 0x10000, 0x3d0000,
5-
fr, data, , 0x3e0000, 0x20000,
4+
app0, app, ota_0, 0x10000, 0x3c0000,
5+
fr, data, , 0x3d0000, 0x20000,
6+
coredump, data, coredump,0x3f0000, 0x10000,

‎libraries/RainMaker/examples/RMakerCustom/ci.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
2+
"fqbn_append": "PartitionScheme=huge_app",
23
"requires": [
34
"CONFIG_SOC_WIFI_SUPPORTED=y",
4-
"CONFIG_ESP_RMAKER_WORK_QUEUE_TASK_STACK"
5+
"CONFIG_ESP_RMAKER_WORK_QUEUE_TASK_STACK=[1-9][0-9]*"
56
]
67
}

‎libraries/RainMaker/examples/RMakerCustomAirCooler/ci.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
2+
"fqbn_append": "PartitionScheme=huge_app",
23
"requires": [
34
"CONFIG_SOC_WIFI_SUPPORTED=y",
4-
"CONFIG_ESP_RMAKER_WORK_QUEUE_TASK_STACK"
5+
"CONFIG_ESP_RMAKER_WORK_QUEUE_TASK_STACK=[1-9][0-9]*"
56
]
67
}

0 commit comments

Comments
 (0)