Skip to content

Commit e6a0b20

Browse files
authored
feat(uart): avoid electrical noise before setting pins
1 parent 7e75bba commit e6a0b20

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/validation/uart/uart.ino

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -368,6 +368,7 @@ void change_pins_test(void) {
368368
// internal loopback creates a BREAK on ESP32 and ESP32-S2
369369
// setting it before changing the pins solves it
370370
uart_internal_loopback(config.uart_num, NEW_RX1);
371+
delay(5); // wait for internal circuit to settle
371372
config.serial.setPins(NEW_RX1, NEW_TX1);
372373
TEST_ASSERT_EQUAL(NEW_RX1, uart_get_RxPin(config.uart_num));
373374
TEST_ASSERT_EQUAL(NEW_TX1, uart_get_TxPin(config.uart_num));
@@ -379,6 +380,7 @@ void change_pins_test(void) {
379380
// internal loopback creates a BREAK on ESP32 and ESP32-S2
380381
// setting it before changing the pins solves it
381382
uart_internal_loopback(config.uart_num, next_uart.default_rx_pin);
383+
delay(5); // wait for internal circuit to settle
382384
config.serial.setPins(next_uart.default_rx_pin, next_uart.default_tx_pin);
383385
TEST_ASSERT_EQUAL(uart_get_RxPin(config.uart_num), next_uart.default_rx_pin);
384386
TEST_ASSERT_EQUAL(uart_get_TxPin(config.uart_num), next_uart.default_tx_pin);
@@ -456,6 +458,7 @@ void periman_test(void) {
456458
// internal loopback creates a BREAK on ESP32 and ESP32-S2
457459
// setting it before changing the pins solves it
458460
uart_internal_loopback(config.uart_num, config.default_rx_pin);
461+
delay(5); // wait for internal circuit to settle
459462
config.serial.setPins(config.default_rx_pin, config.default_tx_pin);
460463

461464
log_d("Trying to send message using UART%d with I2C disabled", config.uart_num);

0 commit comments

Comments
 (0)