Small hardcoded stack size

[Ariakenom]

Board

N/A

Device Description

N/A

Hardware Configuration

N/A

Version

latest stable Release (if not listed below)

Type

Bug

IDE Name

N/A

Operating System

N/A

Flash frequency

N/A

PSRAM enabled

yes

Upload speed

N/A

Description

Enabling debug level esp logs crashes due to the hardcoded stack size linked below.

https://github.com/espressif/arduino-esp32/blob/ea382dfac5a91454dd722d16fb77be454570bbfd/cores/esp32/HWCDC.cpp#L63C82-L63C93

Probably affects ESPUSB as well. Maybe more?

Expected behavior:
Don't stack overflow.

Sketch

# platformio.ini
platform = espressif32 @ ^6.8.0
framework = espidf, arduino

# ESP menuconfig
change CONFIG_LOG_MAXIMUM_EQUALS_DEFAULT to n
change CONFIG_LOG_MAXIMUM_LEVEL_VERBOSE to y

# Code
Do USB activity after setting:
esp_log_level_set("*", ESP_LOG_VERBOSE);

Debug Message

# everything working fine, normal logs

# set log level = verbose

D (23201) event: running post ARDUINO_HW_CDC_EVENTS:3 with handler 0x42018ee0 and context 0x3fced83c on loop 0x3fcecd80

***ERROR*** A stack overflow in task arduino_hw_cdc_ has been detected.


Backtrace: 0x40378346:0x3fcecda0 0x4037ee3d:0x3fcecdc0 0x40382c1d:0x3fcecde0 0x40380fde:0x3fcece60 0x4037eef4:0x3fcece80 0x4037eeea:0x3fcece78 |<-CORRUPTED




ELF file SHA256: x

Rebooting...
ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0xc (RTC_SW_CPU_RST),boot:0x8 (SPI_FAST_FLASH_BOOT)

# addr2line
0x40378346: panic_abort at C:/Users/x/.platformio/packages/framework-espidf@3.40407.240606/components/esp_system/panic.c:408                                        
0x4037ee3d: esp_system_abort at C:/Users/x/.platformio/packages/framework-espidf@3.40407.240606/components/esp_system/esp_system.c:137
0x40382c1d: vApplicationStackOverflowHook at C:\Users\x\.platformio\packages\framework-espidf@3.40407.240606\components\freertos\port\xtensa/port.c:407
0x40380fde: vTaskSwitchContext at C:\Users\x\.platformio\packages\framework-espidf@3.40407.240606\components\freertos/tasks.c:3616
0x4037eef4: _frxt_dispatch at C:\Users\x\.platformio\packages\framework-espidf@3.40407.240606\components\freertos\port\xtensa/portasm.S:436
0x4037eeea: _frxt_int_exit at C:\Users\x\.platformio\packages\framework-espidf@3.40407.240606\components\freertos\port\xtensa/portasm.S:231

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[Jason2866]

This settings does use outdated not maintained Arduino core 2.0.17 based on IDF 4.4.7

platform = espressif32 @ ^6.8.0
framework = espidf, arduino

For using actual branch Arduino master use the fork pioarduino:

platform = https://github.com/pioarduino/platform-espressif32.git#develop
framework = espidf, arduino

[SuGlider]

@Ariakenom - we need a simple Arduino Sketch that can be used to reproduce this problem in order to solve it.
Please provide a piece of code that causes the HWCDC Stack Overflow.

[Ariakenom]

This settings does use outdated not maintained Arduino core 2.0.17 based on IDF 4.4.7

platform = espressif32 @ ^6.8.0
framework = espidf, arduino

For using actual branch Arduino master use the fork pioarduino:

platform = https://github.com/pioarduino/platform-espressif32.git#develop
framework = espidf, arduino

Thanks for the info. That situation seems like quite the mess.

I spent some time to do the upgrade but observed the same behavior. (Except for 10KB more RAM usage.)

PACKAGES:
 - contrib-piohome @ 3.4.4
 - framework-arduinoespressif32 @ 3.3.0
 - framework-arduinoespressif32-libs @ 5.5.0+sha.129cd0d247
 - framework-espidf @ 3.50501.0 (5.5.1)
...

@Ariakenom - we need a simple Arduino Sketch that can be used to reproduce this problem in order to solve it.
Please provide a piece of code that causes the HWCDC Stack Overflow.

I thought pointing to the source code that is wrong would be clear enough.

See for example this comment regarding stack size.
espressif/esp-idf#5165 (comment)

[SuGlider]

@Ariakenom - Just to confirm, if you change the stack size to 3,584 bytes, instead of 2,048, does it fix the issue you have reported?

[Ariakenom]

Yes, that works.

Note that ESPUSB and users of ARDUINO_SERIAL_EVENT_TASK_STACK_SIZE probably has the same issue but I haven't tried. It should probably be configurable in some way.

[SuGlider]

@Ariakenom - The PR #11895 changes the Arduino Core code to use ARDUINO_SERIAL_EVENT_TASK_STACK_SIZE for every Event Task Stack size that can be created.

In this way, it is possible to change it using

• IDF Menu Config (for the Arduino as Component building mode),
• or just adding -DARDUINO_SERIAL_EVENT_TASK_STACK_SIZE=4096 in the build_opt.h Arduino project when using Arduino IDE,
• or the same in PIO environment (build_flags = -DARDUINO_SERIAL_EVENT_TASK_STACK_SIZE=4096)

Please let me know your thoughts about it.

[Ariakenom]

@SuGlider Great structure!

But ARDUINO_SERIAL_EVENT_TASK_STACK_SIZE is still by default 2048 so I would suggest increasing that. Otherwise you will still get stack overflows if you enable the logging.

The logging is statically disabled by default, as far as I know, so there is some defense for not increasing it. It will save RAM.