fix(esp-tls): clean up is_tls flag

Author: erkia

components/esp-tls/esp_tls.c

@@ -468,15 +468,12 @@ static int esp_tls_low_level_conn(const char *hostname, int hostlen, int port, c
     switch (tls->conn_state) {
     case ESP_TLS_INIT:
         tls->sockfd = -1;
-        if (cfg != NULL && cfg->is_plain_tcp == false) {
-            _esp_tls_net_init(tls);
-            tls->is_tls = true;
-        }
+        _esp_tls_net_init(tls);
         if ((esp_ret = tcp_connect(hostname, hostlen, port, cfg, tls->error_handle, &tls->sockfd)) != ESP_OK) {
             ESP_INT_EVENT_TRACKER_CAPTURE(tls->error_handle, ESP_TLS_ERR_TYPE_ESP, esp_ret);
             return -1;
         }
-        if (tls->is_tls == false) {
+        if (cfg && cfg->is_plain_tcp) {
             tls->read = tcp_read;
             tls->write = tcp_write;
             ESP_LOGD(TAG, "non-tls connection established");

components/esp-tls/esp_tls_mbedtls.c

@@ -456,12 +456,10 @@ void esp_mbedtls_conn_delete(esp_tls_t *tls)
 {
     if (tls != NULL) {
         esp_mbedtls_cleanup(tls);
-        if (tls->is_tls) {
-            if (tls->server_fd.fd != -1) {
-                mbedtls_net_free(&tls->server_fd);
-                /* Socket is already closed by `mbedtls_net_free` and hence also change assignment of its copy to an invalid value */
-                tls->sockfd = -1;
-            }
+        if (tls->server_fd.fd != -1) {
+            mbedtls_net_free(&tls->server_fd);
+            /* Socket is already closed by `mbedtls_net_free` and hence also change assignment of its copy to an invalid value */
+            tls->sockfd = -1;
         }
     }
 }

components/esp-tls/private_include/esp_tls_private.h

@@ -91,8 +91,6 @@ struct esp_tls {
 
     fd_set wset;                                                                /*!< write file descriptors */
 
-    bool is_tls;                                                                /*!< indicates connection type (TLS or NON-TLS) */
-
     esp_tls_role_t role;                                                        /*!< esp-tls role
                                                                                      - ESP_TLS_CLIENT
                                                                                      - ESP_TLS_SERVER */