Skip to content

Commit 288fc56

Browse files
committed
tests: fix skipif markers. use temp_skip instead
1 parent c55e913 commit 288fc56

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

examples/protocols/esp_http_client/pytest_esp_http_client.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@ def test_examples_protocol_esp_http_client_dynamic_buffer(dut: Dut) -> None:
109109

110110

111111
@pytest.mark.host_test
112-
# Currently we are just testing the build for esp_http_client on Linux target. So skipping the test run.
113-
# Later we will enable the test run for Linux target as well.
114-
@pytest.mark.skipif('config.getvalue("target") == "linux"', reason='Do not run on Linux')
115112
@pytest.mark.parametrize(
116113
'config',
117114
[
@@ -121,5 +118,11 @@ def test_examples_protocol_esp_http_client_dynamic_buffer(dut: Dut) -> None:
121118
indirect=True,
122119
)
123120
@idf_parametrize('target', ['linux'], indirect=['target'])
124-
def test_examples_protocol_esp_http_client_linux(dut: Dut) -> None:
121+
def test_examples_protocol_esp_http_client_linux(target: str, dut: Dut) -> None:
122+
if target == 'linux':
123+
pytest.skip(
124+
'Currently we are just testing the build for esp_http_client on Linux target. '
125+
'So skipping the test run. Later we will enable the test run for Linux target as well.'
126+
)
127+
125128
dut.expect('Finish http example', timeout=60)

tools/test_apps/system/panic/pytest_panic.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -936,11 +936,10 @@ def test_rtc_fast_reg1_execute_violation(dut: PanicTestDut, test_func_name: str)
936936

937937

938938
@pytest.mark.generic
939-
@pytest.mark.skipif(
940-
'config.getvalue("target") in ["esp32c5", "esp32c6", "esp32h2", "esp32p4", "esp32h21"]',
941-
reason='Not a violation condition, no PMS peripheral case',
939+
@pytest.mark.temp_skip(
940+
targets=['esp32c5', 'esp32c6', 'esp32h2', 'esp32p4', 'esp32h21'],
941+
reason='Not a violation condition, no PMS peripheral cases',
942942
)
943-
@pytest.mark.temp_skip_ci(targets=['esp32h21'], reason='lack of runners')
944943
@idf_parametrize('config, target', CONFIGS_MEMPROT_RTC_FAST_MEM, indirect=['config', 'target'])
945944
def test_rtc_fast_reg2_execute_violation(dut: PanicTestDut, test_func_name: str) -> None:
946945
dut.run_test_func(test_func_name)

0 commit comments

Comments
 (0)