Skip to content

Commit 2b97653

Browse files
committed
Merge branch 'bugfix/wpa2_ent_fixes' into 'master'
Few fixes in wpa_supplicant Closes WIFI-6676 See merge request espressif/esp-idf!33017
2 parents ee74f27 + 7444127 commit 2b97653

File tree

6 files changed

+303
-294
lines changed

6 files changed

+303
-294
lines changed

components/esp_wifi/wifi_apps/nan_app/src/nan_app.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ void esp_nan_app_deinit(void)
673673
}
674674

675675
if (s_nan_data_lock) {
676-
os_semphr_delete(s_nan_data_lock);
676+
os_mutex_delete(s_nan_data_lock);
677677
s_nan_data_lock = NULL;
678678
}
679679
}

components/wpa_supplicant/esp_supplicant/src/esp_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ void esp_supplicant_common_deinit(void)
415415
s_supplicant_evt_queue = NULL;
416416
}
417417
if (s_supplicant_api_lock) {
418-
os_semphr_delete(s_supplicant_api_lock);
418+
os_mutex_delete(s_supplicant_api_lock);
419419
s_supplicant_api_lock = NULL;
420420
}
421421
} else if (esp_supplicant_post_evt(SIG_SUPPLICANT_DEL_TASK, 0) != 0) {

components/wpa_supplicant/esp_supplicant/src/esp_dpp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ static void esp_dpp_task(void *pvParameters)
617617
s_dpp_evt_queue = NULL;
618618

619619
if (s_dpp_api_lock) {
620-
os_semphr_delete(s_dpp_api_lock);
620+
os_mutex_delete(s_dpp_api_lock);
621621
s_dpp_api_lock = NULL;
622622
}
623623

components/wpa_supplicant/esp_supplicant/src/esp_eap_client.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ void wpa2_task(void *pvParameters)
242242
break;
243243
} else {
244244
if (s_wifi_wpa2_sync_sem) {
245-
wpa_printf(MSG_DEBUG, "EAP: wifi->EAP api completed sig(%" PRId32 ")", e->sig);
245+
wpa_printf(MSG_DEBUG, "EAP: wifi->EAP api completed");
246246
os_semphr_give(s_wifi_wpa2_sync_sem);
247247
} else {
248248
wpa_printf(MSG_ERROR, "EAP: null wifi->EAP sync sem");
@@ -255,7 +255,7 @@ void wpa2_task(void *pvParameters)
255255
wpa_printf(MSG_DEBUG, "EAP: task deleted");
256256
s_wpa2_queue = NULL;
257257
if (s_wifi_wpa2_sync_sem) {
258-
wpa_printf(MSG_DEBUG, "EAP: wifi->EAP api completed sig(%" PRId32 ")", e->sig);
258+
wpa_printf(MSG_DEBUG, "EAP: wifi->EAP api completed");
259259
os_semphr_give(s_wifi_wpa2_sync_sem);
260260
} else {
261261
wpa_printf(MSG_ERROR, "EAP: null wifi->EAP sync sem");
@@ -725,7 +725,7 @@ static int eap_peer_sm_init(void)
725725

726726
gEapSm = sm;
727727
#ifdef USE_WPA2_TASK
728-
s_wpa2_queue = os_queue_create(SIG_WPA2_MAX, sizeof(s_wpa2_queue));
728+
s_wpa2_queue = os_queue_create(SIG_WPA2_MAX, sizeof(ETSEvent));
729729
ret = os_task_create(wpa2_task, "wpa2T", WPA2_TASK_STACK_SIZE, NULL, WPA2_TASK_PRIORITY, &s_wpa2_task_hdl);
730730
if (ret != TRUE) {
731731
wpa_printf(MSG_ERROR, "wps enable: failed to create task");
@@ -782,7 +782,7 @@ static void eap_peer_sm_deinit(void)
782782
}
783783

784784
if (s_wpa2_data_lock) {
785-
os_semphr_delete(s_wpa2_data_lock);
785+
os_mutex_delete(s_wpa2_data_lock);
786786
s_wpa2_data_lock = NULL;
787787
wpa_printf(MSG_DEBUG, "EAP: eap_peer_sm_deinit: free data lock");
788788
}

components/wpa_supplicant/esp_supplicant/src/esp_wps.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1771,6 +1771,11 @@ int wps_task_deinit(void)
17711771
wps_rxq_deinit();
17721772
}
17731773

1774+
if (s_wps_data_lock) {
1775+
os_mutex_delete(s_wps_data_lock);
1776+
s_wps_data_lock = NULL;
1777+
}
1778+
17741779
return ESP_OK;
17751780
}
17761781

@@ -1803,7 +1808,7 @@ int wps_task_init(void)
18031808
}
18041809

18051810
os_bzero(s_wps_sig_cnt, SIG_WPS_NUM);
1806-
s_wps_queue = os_queue_create(SIG_WPS_NUM, sizeof(s_wps_queue));
1811+
s_wps_queue = os_queue_create(SIG_WPS_NUM, sizeof(ETSEvent));
18071812
if (!s_wps_queue) {
18081813
wpa_printf(MSG_ERROR, "wps task init: failed to alloc queue");
18091814
goto _wps_no_mem;

0 commit comments

Comments
 (0)