Skip to content

Commit 409af75

Browse files
committed
Merge branch 'fix/usb_phy_pull_override' into 'master'
fix(usb_phy): Removed pad pull override config for Full-speed Closes IDF-12074 See merge request espressif/esp-idf!36660
2 parents a23554f + 9c85170 commit 409af75

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

components/usb/usb_phy.c

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -180,23 +180,7 @@ esp_err_t usb_phy_otg_dev_set_speed(usb_phy_handle_t handle, usb_phy_speed_t spe
180180
ESP_RETURN_ON_FALSE((handle->target == USB_PHY_TARGET_UTMI) == (speed == USB_PHY_SPEED_HIGH), ESP_ERR_NOT_SUPPORTED, USBPHY_TAG, "UTMI can be HighSpeed only"); // This is our software limitation
181181

182182
handle->otg_speed = speed;
183-
if (handle->target == USB_PHY_TARGET_UTMI) {
184-
return ESP_OK; // No need to configure anything for UTMI PHY
185-
}
186-
187-
// Configure pull resistors for device
188-
usb_wrap_pull_override_vals_t vals = {
189-
.dp_pd = false,
190-
.dm_pd = false,
191-
};
192-
if (speed == USB_PHY_SPEED_LOW) {
193-
vals.dp_pu = false;
194-
vals.dm_pu = true;
195-
} else {
196-
vals.dp_pu = true;
197-
vals.dm_pu = false;
198-
}
199-
usb_wrap_hal_phy_enable_pull_override(&handle->wrap_hal, &vals);
183+
// No need to configure anything neither for UTMI PHY nor for Internal USB FSLS PHY
200184
return ESP_OK;
201185
}
202186

0 commit comments

Comments
 (0)