Merge branch 'refactor/mcpwm_generator_remove_varg_api' into 'master'

refactor(mcpwm): remove varg action setting functions for timer, compare, and brake events

Closes IDF-13901, IDF-13890, IDF-13865, and IDF-13880

See merge request espressif/esp-idf!42259

Author: suda-morris

components/esp_driver_mcpwm/include/driver/mcpwm_fault.h

@@ -8,7 +8,6 @@
 
 #include <stdint.h>
 #include <stdbool.h>
-#include <stdarg.h>
 #include "esp_err.h"
 #include "driver/mcpwm_types.h"
 

components/esp_driver_mcpwm/include/driver/mcpwm_gen.h

@@ -8,7 +8,6 @@
 
 #include <stdint.h>
 #include <stdbool.h>
-#include <stdarg.h>
 #include "esp_err.h"
 #include "driver/mcpwm_types.h"
 
@@ -84,8 +83,6 @@ typedef struct {
  */
 #define MCPWM_GEN_TIMER_EVENT_ACTION(dir, ev, act) \
     (mcpwm_gen_timer_event_action_t) { .direction = dir, .event = ev, .action = act }
-#define MCPWM_GEN_TIMER_EVENT_ACTION_END() \
-    (mcpwm_gen_timer_event_action_t) { .event = MCPWM_TIMER_EVENT_INVALID }
 
 /**
  * @brief Set generator action on MCPWM timer event
@@ -100,21 +97,6 @@ typedef struct {
  */
 esp_err_t mcpwm_generator_set_action_on_timer_event(mcpwm_gen_handle_t gen, mcpwm_gen_timer_event_action_t ev_act);
 
-/**
- * @brief Set generator actions on multiple MCPWM timer events
- *
- * @note This is an aggregation version of `mcpwm_generator_set_action_on_timer_event`, which allows user to set multiple actions in one call.
- *
- * @param[in] gen MCPWM generator handle, allocated by `mcpwm_new_generator()`
- * @param[in] ev_act MCPWM timer event action list, must be terminated by `MCPWM_GEN_TIMER_EVENT_ACTION_END()`
- * @return
- *      - ESP_OK: Set generator actions successfully
- *      - ESP_ERR_INVALID_ARG: Set generator actions failed because of invalid argument
- *      - ESP_ERR_INVALID_STATE: Set generator actions failed because of timer is not connected to operator
- *      - ESP_FAIL: Set generator actions failed because of other error
- */
-esp_err_t mcpwm_generator_set_actions_on_timer_event(mcpwm_gen_handle_t gen, mcpwm_gen_timer_event_action_t ev_act, ...);
-
 /**
  * @brief Generator action on specific comparator event
  */
@@ -129,8 +111,6 @@ typedef struct {
  */
 #define MCPWM_GEN_COMPARE_EVENT_ACTION(dir, cmp, act) \
     (mcpwm_gen_compare_event_action_t) { .direction = dir, .comparator = cmp, .action = act }
-#define MCPWM_GEN_COMPARE_EVENT_ACTION_END() \
-    (mcpwm_gen_compare_event_action_t) { .comparator = NULL }
 
 /**
  * @brief Set generator action on MCPWM compare event
@@ -144,20 +124,6 @@ typedef struct {
  */
 esp_err_t mcpwm_generator_set_action_on_compare_event(mcpwm_gen_handle_t generator, mcpwm_gen_compare_event_action_t ev_act);
 
-/**
- * @brief Set generator actions on multiple MCPWM compare events
- *
- * @note This is an aggregation version of `mcpwm_generator_set_action_on_compare_event`, which allows user to set multiple actions in one call.
- *
- * @param[in] generator MCPWM generator handle, allocated by `mcpwm_new_generator()`
- * @param[in] ev_act MCPWM compare event action list, must be terminated by `MCPWM_GEN_COMPARE_EVENT_ACTION_END()`
- * @return
- *      - ESP_OK: Set generator actions successfully
- *      - ESP_ERR_INVALID_ARG: Set generator actions failed because of invalid argument
- *      - ESP_FAIL: Set generator actions failed because of other error
- */
-esp_err_t mcpwm_generator_set_actions_on_compare_event(mcpwm_gen_handle_t generator, mcpwm_gen_compare_event_action_t ev_act, ...);
-
 /**
  * @brief Generator action on specific brake event
  */
@@ -172,8 +138,6 @@ typedef struct {
  */
 #define MCPWM_GEN_BRAKE_EVENT_ACTION(dir, mode, act) \
     (mcpwm_gen_brake_event_action_t) { .direction = dir, .brake_mode = mode, .action = act }
-#define MCPWM_GEN_BRAKE_EVENT_ACTION_END() \
-    (mcpwm_gen_brake_event_action_t) { .brake_mode = MCPWM_OPER_BRAKE_MODE_INVALID }
 
 /**
  * @brief Set generator action on MCPWM brake event
@@ -187,20 +151,6 @@ typedef struct {
  */
 esp_err_t mcpwm_generator_set_action_on_brake_event(mcpwm_gen_handle_t generator, mcpwm_gen_brake_event_action_t ev_act);
 
-/**
- * @brief Set generator actions on multiple MCPWM brake events
- *
- * @note This is an aggregation version of `mcpwm_generator_set_action_on_brake_event`, which allows user to set multiple actions in one call.
- *
- * @param[in] generator MCPWM generator handle, allocated by `mcpwm_new_generator()`
- * @param[in] ev_act MCPWM brake event action list, must be terminated by `MCPWM_GEN_BRAKE_EVENT_ACTION_END()`
- * @return
- *      - ESP_OK: Set generator actions successfully
- *      - ESP_ERR_INVALID_ARG: Set generator actions failed because of invalid argument
- *      - ESP_FAIL: Set generator actions failed because of other error
- */
-esp_err_t mcpwm_generator_set_actions_on_brake_event(mcpwm_gen_handle_t generator, mcpwm_gen_brake_event_action_t ev_act, ...);
-
 /**
  * @brief Generator action on specific fault event
  */

components/esp_driver_mcpwm/src/mcpwm_gen.c

@@ -160,37 +160,6 @@ esp_err_t mcpwm_generator_set_action_on_timer_event(mcpwm_gen_handle_t gen, mcpw
     return ESP_OK;
 }
 
-esp_err_t mcpwm_generator_set_actions_on_timer_event(mcpwm_gen_handle_t gen, mcpwm_gen_timer_event_action_t ev_act, ...)
-{
-    ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
-    mcpwm_oper_t *oper = gen->oper;
-    mcpwm_group_t *group = oper->group;
-    mcpwm_timer_t *timer = oper->timer;
-    ESP_RETURN_ON_FALSE(timer, ESP_ERR_INVALID_STATE, TAG, "no timer is connected to the operator");
-    mcpwm_gen_timer_event_action_t ev_act_itor = ev_act;
-    bool invalid_utep = false;
-    bool invalid_dtez = false;
-    va_list it = {};
-    va_start(it, ev_act);
-    while (ev_act_itor.event != MCPWM_TIMER_EVENT_INVALID) {
-        invalid_utep = (timer->count_mode == MCPWM_TIMER_COUNT_MODE_UP_DOWN) &&
-                       (ev_act_itor.direction == MCPWM_TIMER_DIRECTION_UP) &&
-                       (ev_act_itor.event == MCPWM_TIMER_EVENT_FULL);
-        invalid_dtez = (timer->count_mode == MCPWM_TIMER_COUNT_MODE_UP_DOWN) &&
-                       (ev_act_itor.direction == MCPWM_TIMER_DIRECTION_DOWN) &&
-                       (ev_act_itor.event == MCPWM_TIMER_EVENT_EMPTY);
-        if (invalid_utep || invalid_dtez) {
-            va_end(it);
-            ESP_RETURN_ON_FALSE(false, ESP_ERR_INVALID_ARG, TAG, "UTEP and DTEZ can't be reached under MCPWM_TIMER_COUNT_MODE_UP_DOWN mode");
-        }
-        mcpwm_ll_generator_set_action_on_timer_event(group->hal.dev, oper->oper_id, gen->gen_id,
-                                                     ev_act_itor.direction, ev_act_itor.event, ev_act_itor.action);
-        ev_act_itor = va_arg(it, mcpwm_gen_timer_event_action_t);
-    }
-    va_end(it);
-    return ESP_OK;
-}
-
 esp_err_t mcpwm_generator_set_action_on_compare_event(mcpwm_gen_handle_t gen, mcpwm_gen_compare_event_action_t ev_act)
 {
     ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
@@ -202,23 +171,6 @@ esp_err_t mcpwm_generator_set_action_on_compare_event(mcpwm_gen_handle_t gen, mc
     return ESP_OK;
 }
 
-esp_err_t mcpwm_generator_set_actions_on_compare_event(mcpwm_gen_handle_t gen, mcpwm_gen_compare_event_action_t ev_act, ...)
-{
-    ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
-    mcpwm_oper_t *oper = gen->oper;
-    mcpwm_group_t *group = oper->group;
-    mcpwm_gen_compare_event_action_t ev_act_itor = ev_act;
-    va_list it = {};
-    va_start(it, ev_act);
-    while (ev_act_itor.comparator) {
-        mcpwm_ll_generator_set_action_on_compare_event(group->hal.dev, oper->oper_id, gen->gen_id,
-                                                       ev_act_itor.direction, ev_act_itor.comparator->cmpr_id, ev_act_itor.action);
-        ev_act_itor = va_arg(it, mcpwm_gen_compare_event_action_t);
-    }
-    va_end(it);
-    return ESP_OK;
-}
-
 esp_err_t mcpwm_generator_set_action_on_brake_event(mcpwm_gen_handle_t gen, mcpwm_gen_brake_event_action_t ev_act)
 {
     ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
@@ -230,23 +182,6 @@ esp_err_t mcpwm_generator_set_action_on_brake_event(mcpwm_gen_handle_t gen, mcpw
     return ESP_OK;
 }
 
-esp_err_t mcpwm_generator_set_actions_on_brake_event(mcpwm_gen_handle_t gen, mcpwm_gen_brake_event_action_t ev_act, ...)
-{
-    ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
-    mcpwm_oper_t *oper = gen->oper;
-    mcpwm_group_t *group = oper->group;
-    mcpwm_gen_brake_event_action_t ev_act_itor = ev_act;
-    va_list it = {};
-    va_start(it, ev_act);
-    while (ev_act_itor.brake_mode != MCPWM_OPER_BRAKE_MODE_INVALID) {
-        mcpwm_ll_generator_set_action_on_brake_event(group->hal.dev, oper->oper_id, gen->gen_id,
-                                                     ev_act_itor.direction, ev_act_itor.brake_mode, ev_act_itor.action);
-        ev_act_itor = va_arg(it, mcpwm_gen_brake_event_action_t);
-    }
-    va_end(it);
-    return ESP_OK;
-}
-
 esp_err_t mcpwm_generator_set_action_on_fault_event(mcpwm_gen_handle_t gen, mcpwm_gen_fault_event_action_t ev_act)
 {
     ESP_RETURN_ON_FALSE(gen, ESP_ERR_INVALID_ARG, TAG, "invalid argument");

components/esp_driver_mcpwm/src/mcpwm_private.h

@@ -8,7 +8,6 @@
 
 #include <stdint.h>
 #include <stdlib.h>
-#include <stdarg.h>
 #include <sys/cdefs.h>
 #include <sys/lock.h>
 #include "sdkconfig.h"

components/esp_driver_mcpwm/test_apps/mcpwm/main/test_mcpwm_gen.c

@@ -260,10 +260,10 @@ TEST_CASE("mcpwm_generator_action_on_timer_event", "[mcpwm]")
     TEST_ESP_OK(mcpwm_new_generator(oper, &gen_config, &gen));
 
     printf("set generator to output high on timer full\r\n");
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_timer_event(gen,
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP)));
     printf("start timer\r\n");
     TEST_ESP_OK(mcpwm_timer_start_stop(timer, MCPWM_TIMER_START_NO_STOP));
     vTaskDelay(pdMS_TO_TICKS(100));
@@ -272,10 +272,10 @@ TEST_CASE("mcpwm_generator_action_on_timer_event", "[mcpwm]")
     TEST_ASSERT_EQUAL(1, gpio_get_level(generator_gpio));
 
     printf("set generator to output low on timer full\r\n");
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_timer_event(gen,
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_LOW),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP)));
     printf("start timer\r\n");
     TEST_ESP_OK(mcpwm_timer_start_stop(timer, MCPWM_TIMER_START_NO_STOP));
     vTaskDelay(pdMS_TO_TICKS(100));
@@ -457,49 +457,48 @@ static void single_edge_active_low(mcpwm_gen_handle_t gena, mcpwm_gen_handle_t g
 
 static void pulse_placement(mcpwm_gen_handle_t gena, mcpwm_gen_handle_t genb, mcpwm_cmpr_handle_t cmpa, mcpwm_cmpr_handle_t cmpb)
 {
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(gena,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_timer_event(genb,
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_TOGGLE),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(genb,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_TOGGLE)));
 }
 
 static void dual_edge_active_low_asym(mcpwm_gen_handle_t gena, mcpwm_gen_handle_t genb, mcpwm_cmpr_handle_t cmpa, mcpwm_cmpr_handle_t cmpb)
 {
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(gena,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_timer_event(genb,
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_LOW),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(genb,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(genb,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH)));
 }
 
 static void dual_edge_active_low_sym(mcpwm_gen_handle_t gena, mcpwm_gen_handle_t genb, mcpwm_cmpr_handle_t cmpa, mcpwm_cmpr_handle_t cmpb)
 {
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(gena,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpa, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(genb,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpa, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(genb,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(genb,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_LOW)));
 }
 
 static void dual_edge_complementary(mcpwm_gen_handle_t gena, mcpwm_gen_handle_t genb, mcpwm_cmpr_handle_t cmpa, mcpwm_cmpr_handle_t cmpb)
 {
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(gena,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpa, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_compare_event(genb,
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_LOW),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_HIGH),
-                                                             MCPWM_GEN_COMPARE_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpa, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(gena,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpa, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(genb,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, cmpb, MCPWM_GEN_ACTION_LOW)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_compare_event(genb,
+                                                            MCPWM_GEN_COMPARE_EVENT_ACTION(MCPWM_TIMER_DIRECTION_DOWN, cmpb, MCPWM_GEN_ACTION_HIGH)));
 }
 
 TEST_CASE("mcpwm_generator_action_on_compare_event", "[mcpwm]")

components/esp_driver_mcpwm/test_apps/mcpwm/main/test_mcpwm_sleep.c

@@ -62,10 +62,10 @@ static void test_mcpwm_timer_sleep_retention(bool allow_pd)
     TEST_ESP_OK(mcpwm_new_generator(oper, &gen_config, &gen));
 
     printf("set generator to output high on timer full\r\n");
-    TEST_ESP_OK(mcpwm_generator_set_actions_on_timer_event(gen,
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP),
-                                                           MCPWM_GEN_TIMER_EVENT_ACTION_END()));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_FULL, MCPWM_GEN_ACTION_HIGH)));
+    TEST_ESP_OK(mcpwm_generator_set_action_on_timer_event(gen,
+                                                          MCPWM_GEN_TIMER_EVENT_ACTION(MCPWM_TIMER_DIRECTION_UP, MCPWM_TIMER_EVENT_EMPTY, MCPWM_GEN_ACTION_KEEP)));
 
     // go to sleep
     esp_sleep_context_t sleep_ctx;