Skip to content

Commit 569b9d5

Browse files
committed
component/bt: remove some error logs which are not error
1 parent 17e8d49 commit 569b9d5

File tree

16 files changed

+63
-66
lines changed

16 files changed

+63
-66
lines changed

components/bt/bluedroid/bta/av/bta_av_aact.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ static void bta_av_proc_stream_evt(UINT8 handle, BD_ADDR bd_addr, UINT8 event, t
546546
if (p_data) {
547547
bta_av_conn_cback(handle, bd_addr, event, p_data);
548548
} else {
549-
APPL_TRACE_ERROR("%s: p_data is null", __func__);
549+
APPL_TRACE_EVENT("%s: p_data is null", __func__);
550550
}
551551
}
552552

components/bt/bluedroid/bta/av/bta_av_act.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ void bta_av_rc_opened(tBTA_AV_CB *p_cb, tBTA_AV_DATA *p_data)
474474
p_scb->rc_handle = p_data->rc_conn_chg.handle;
475475
APPL_TRACE_DEBUG("bta_av_rc_opened shdl:%d, srch %d", i + 1, p_scb->rc_handle);
476476
shdl = i + 1;
477-
LOG_INFO("%s allow incoming AVRCP connections:%d", __func__, p_scb->use_rc);
477+
APPL_TRACE_EVENT("%s allow incoming AVRCP connections:%d", __func__, p_scb->use_rc);
478478
bta_sys_stop_timer(&p_scb->timer);
479479
disc = p_scb->hndl;
480480
break;
@@ -506,7 +506,7 @@ void bta_av_rc_opened(tBTA_AV_CB *p_cb, tBTA_AV_DATA *p_data)
506506

507507
p_cb->rcb[i].shdl = shdl;
508508
rc_open.rc_handle = i;
509-
APPL_TRACE_ERROR("bta_av_rc_opened rcb[%d] shdl:%d lidx:%d/%d",
509+
APPL_TRACE_EVENT("bta_av_rc_opened rcb[%d] shdl:%d lidx:%d/%d",
510510
i, shdl, p_cb->rcb[i].lidx, p_cb->lcb[BTA_AV_NUM_LINKS].lidx);
511511
p_cb->rcb[i].status |= BTA_AV_RC_CONN_MASK;
512512

components/bt/bluedroid/bta/dm/bta_dm_act.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3118,7 +3118,7 @@ static BOOLEAN bta_dm_check_av(UINT16 event)
31183118
}
31193119
#endif
31203120

3121-
APPL_TRACE_WARNING("bta_dm_check_av:%d", bta_dm_cb.cur_av_count);
3121+
APPL_TRACE_EVENT("bta_dm_check_av:%d", bta_dm_cb.cur_av_count);
31223122
if (bta_dm_cb.cur_av_count) {
31233123
for (i = 0; i < bta_dm_cb.device_list.count; i++) {
31243124
p_dev = &bta_dm_cb.device_list.peer_device[i];
@@ -3442,7 +3442,7 @@ static void bta_dm_rm_cback(tBTA_SYS_CONN_STATUS status, UINT8 id, UINT8 app_id,
34423442
#endif ///BTM_SSR_INCLUDED == TRUE
34433443
}
34443444
}
3445-
APPL_TRACE_WARNING("bta_dm_rm_cback:%d, status:%d", bta_dm_cb.cur_av_count, status);
3445+
APPL_TRACE_EVENT("bta_dm_rm_cback:%d, status:%d", bta_dm_cb.cur_av_count, status);
34463446
}
34473447

34483448
/* Don't adjust roles for each busy/idle state transition to avoid

components/bt/bluedroid/btc/profile/std/a2dp/btc_a2dp_source.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1493,7 +1493,7 @@ static void btc_a2dp_source_feeding_state_reset(void)
14931493
btc_aa_src_cb.media_feeding.cfg.pcm.num_channel *
14941494
BTC_MEDIA_TIME_TICK_MS) / 1000;
14951495

1496-
APPL_TRACE_WARNING("pcm bytes per tick %d",
1496+
APPL_TRACE_EVENT("pcm bytes per tick %d",
14971497
(int)btc_aa_src_cb.media_feeding_state.pcm.bytes_per_tick);
14981498
}
14991499
}

components/bt/bluedroid/btc/profile/std/gap/btc_gap_ble.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -579,23 +579,23 @@ static void btc_search_callback(tBTA_DM_SEARCH_EVT event, tBTA_DM_SEARCH *p_data
579579
}
580580
case BTA_DM_INQ_CMPL_EVT: {
581581
param.scan_rst.num_resps = p_data->inq_cmpl.num_resps;
582-
LOG_ERROR("%s BLE observe complete. Num Resp %d\n", __FUNCTION__, p_data->inq_cmpl.num_resps);
582+
LOG_DEBUG("%s BLE observe complete. Num Resp %d\n", __FUNCTION__, p_data->inq_cmpl.num_resps);
583583
break;
584584
}
585585
case BTA_DM_DISC_RES_EVT:
586-
LOG_ERROR("BTA_DM_DISC_RES_EVT\n");
586+
LOG_DEBUG("BTA_DM_DISC_RES_EVT\n");
587587
break;
588588
case BTA_DM_DISC_BLE_RES_EVT:
589-
LOG_ERROR("BTA_DM_DISC_BLE_RES_EVT\n");
589+
LOG_DEBUG("BTA_DM_DISC_BLE_RES_EVT\n");
590590
break;
591591
case BTA_DM_DISC_CMPL_EVT:
592-
LOG_ERROR("BTA_DM_DISC_CMPL_EVT\n");
592+
LOG_DEBUG("BTA_DM_DISC_CMPL_EVT\n");
593593
break;
594594
case BTA_DM_DI_DISC_CMPL_EVT:
595-
LOG_ERROR("BTA_DM_DI_DISC_CMPL_EVT\n");
595+
LOG_DEBUG("BTA_DM_DI_DISC_CMPL_EVT\n");
596596
break;
597597
case BTA_DM_SEARCH_CANCEL_CMPL_EVT:
598-
LOG_ERROR("BTA_DM_SEARCH_CANCEL_CMPL_EVT\n");
598+
LOG_DEBUG("BTA_DM_SEARCH_CANCEL_CMPL_EVT\n");
599599
break;
600600
default:
601601
LOG_ERROR("%s : Unknown event 0x%x\n", __FUNCTION__, event);

components/bt/bluedroid/btc/profile/std/gatt/btc_gattc.c

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static inline void btc_gattc_cb_to_app(esp_gattc_cb_event_t event, esp_gatt_if_t
2929
esp_gattc_cb_t btc_gattc_cb = (esp_gattc_cb_t )btc_profile_cb_get(BTC_PID_GATTC);
3030
if (btc_gattc_cb) {
3131
btc_gattc_cb(event, gattc_if, param);
32-
}
32+
}
3333
}
3434

3535
void btc_gattc_arg_deep_copy(btc_msg_t *msg, void *p_dest, void *p_src)
@@ -128,7 +128,7 @@ static void btc_gattc_copy_req_data(btc_msg_t *msg, void *p_dest, void *p_src)
128128
// Allocate buffer for request data if necessary
129129
switch (msg->act) {
130130
case BTA_GATTC_READ_DESCR_EVT:
131-
case BTA_GATTC_READ_CHAR_EVT:
131+
case BTA_GATTC_READ_CHAR_EVT:
132132
case BTA_GATTC_READ_MUTIPLE_EVT: {
133133
if (p_src_data->read.p_value && p_src_data->read.p_value->p_value) {
134134
p_dest_data->read.p_value = (tBTA_GATT_UNFMT *)osi_malloc(sizeof(tBTA_GATT_UNFMT) + p_src_data->read.p_value->len);
@@ -141,7 +141,7 @@ static void btc_gattc_copy_req_data(btc_msg_t *msg, void *p_dest, void *p_src)
141141
}
142142
}
143143
break;
144-
}
144+
}
145145
default:
146146
break;
147147
}
@@ -152,7 +152,7 @@ static void btc_gattc_free_req_data(btc_msg_t *msg)
152152
tBTA_GATTC *arg = (tBTA_GATTC *)(msg->arg);
153153
switch (msg->act) {
154154
case BTA_GATTC_READ_DESCR_EVT:
155-
case BTA_GATTC_READ_CHAR_EVT:
155+
case BTA_GATTC_READ_CHAR_EVT:
156156
case BTA_GATTC_READ_MUTIPLE_EVT: {
157157
if (arg->read.p_value) {
158158
osi_free(arg->read.p_value);
@@ -290,7 +290,7 @@ static void btc_gattc_search_service(btc_ble_gattc_args_t *arg)
290290
}
291291
}
292292

293-
esp_gatt_status_t btc_ble_gattc_get_service(uint16_t conn_id, esp_bt_uuid_t *svc_uuid,
293+
esp_gatt_status_t btc_ble_gattc_get_service(uint16_t conn_id, esp_bt_uuid_t *svc_uuid,
294294
esp_gattc_service_elem_t *result,
295295
uint16_t *count, uint16_t offset)
296296
{
@@ -302,7 +302,7 @@ esp_gatt_status_t btc_ble_gattc_get_service(uint16_t conn_id, esp_bt_uuid_t *svc
302302
bta_uuid = osi_malloc(sizeof(tBT_UUID));
303303
btc_to_bta_uuid(bta_uuid, svc_uuid);
304304
}
305-
305+
306306
BTA_GATTC_GetServiceWithUUID(conn_id, bta_uuid, &db, &svc_num);
307307

308308
if ((status = btc_gattc_check_valid_param(svc_num, offset)) != ESP_GATT_OK) {
@@ -312,7 +312,7 @@ esp_gatt_status_t btc_ble_gattc_get_service(uint16_t conn_id, esp_bt_uuid_t *svc
312312
if (bta_uuid) {
313313
osi_free(bta_uuid);
314314
}
315-
return status;
315+
return status;
316316
} else {
317317
btc_gattc_fill_gatt_db_conversion(*count, (uint16_t)svc_num, ESP_GATT_DB_PRIMARY_SERVICE, offset, (void *)result, db);
318318
}
@@ -370,7 +370,7 @@ esp_gatt_status_t btc_ble_gattc_get_all_descr(uint16_t conn_id,
370370
if (db) {
371371
osi_free(db);
372372
}
373-
return status;
373+
return status;
374374
} else {
375375
btc_gattc_fill_gatt_db_conversion(*count, (uint16_t)descr_num, ESP_GATT_DB_DESCRIPTOR, offset, (void *)result, db);
376376
}
@@ -387,7 +387,7 @@ esp_gatt_status_t btc_ble_gattc_get_char_by_uuid(uint16_t conn_id,
387387
uint16_t start_handle,
388388
uint16_t end_handle,
389389
esp_bt_uuid_t char_uuid,
390-
esp_gattc_char_elem_t *result,
390+
esp_gattc_char_elem_t *result,
391391
uint16_t *count)
392392
{
393393
esp_gatt_status_t status;
@@ -419,7 +419,7 @@ esp_gatt_status_t btc_ble_gattc_get_descr_by_uuid(uint16_t conn_id,
419419
uint16_t end_handle,
420420
esp_bt_uuid_t char_uuid,
421421
esp_bt_uuid_t descr_uuid,
422-
esp_gattc_descr_elem_t *result,
422+
esp_gattc_descr_elem_t *result,
423423
uint16_t *count)
424424
{
425425
esp_gatt_status_t status;
@@ -429,8 +429,8 @@ esp_gatt_status_t btc_ble_gattc_get_descr_by_uuid(uint16_t conn_id,
429429
tBT_UUID bta_descr_uuid = {0};
430430
btc_to_bta_uuid(&bta_char_uuid, &char_uuid);
431431
btc_to_bta_uuid(&bta_descr_uuid, &descr_uuid);
432-
433-
BTA_GATTC_GetDescrByUUID(conn_id, start_handle, end_handle,
432+
433+
BTA_GATTC_GetDescrByUUID(conn_id, start_handle, end_handle,
434434
bta_char_uuid, bta_descr_uuid, &db, &descr_num);
435435

436436
if ((status = btc_gattc_check_valid_param(descr_num, 0)) != ESP_GATT_OK) {
@@ -441,7 +441,7 @@ esp_gatt_status_t btc_ble_gattc_get_descr_by_uuid(uint16_t conn_id,
441441
} else {
442442
btc_gattc_fill_gatt_db_conversion(*count, (uint16_t)descr_num, ESP_GATT_DB_DESCRIPTOR, 0, (void *)result, db);
443443
}
444-
444+
445445
*count = descr_num;
446446
//don't forget to free the db buffer after used.
447447
if (db) {
@@ -461,7 +461,7 @@ esp_gatt_status_t btc_ble_gattc_get_descr_by_char_handle(uint16_t conn_id,
461461
int descr_num = 0;
462462
tBT_UUID bta_descr_uuid = {0};
463463
btc_to_bta_uuid(&bta_descr_uuid, &descr_uuid);
464-
464+
465465
BTA_GATTC_GetDescrByCharHandle(conn_id, char_handle, bta_descr_uuid, &db, &descr_num);
466466

467467
if ((status = btc_gattc_check_valid_param(descr_num, 0)) != ESP_GATT_OK) {
@@ -479,7 +479,7 @@ esp_gatt_status_t btc_ble_gattc_get_descr_by_char_handle(uint16_t conn_id,
479479
osi_free(db);
480480
}
481481
return ESP_GATT_OK;
482-
482+
483483
}
484484

485485
esp_gatt_status_t btc_ble_gattc_get_include_service(uint16_t conn_id,
@@ -588,7 +588,7 @@ static void btc_gattc_read_char_descr(btc_ble_gattc_args_t *arg)
588588

589589
static void btc_gattc_write_char(btc_ble_gattc_args_t *arg)
590590
{
591-
BTA_GATTC_WriteCharValue(arg->write_char.conn_id,
591+
BTA_GATTC_WriteCharValue(arg->write_char.conn_id,
592592
arg->write_char.handle,
593593
arg->write_char.write_type,
594594
arg->write_char.value_len,
@@ -603,7 +603,7 @@ static void btc_gattc_write_char_descr(btc_ble_gattc_args_t *arg)
603603
descr_val.len = arg->write_descr.value_len;
604604
descr_val.p_value = arg->write_descr.value;
605605

606-
BTA_GATTC_WriteCharDescr(arg->write_descr.conn_id,
606+
BTA_GATTC_WriteCharDescr(arg->write_descr.conn_id,
607607
arg->write_descr.handle,
608608
arg->write_descr.write_type, &descr_val,
609609
arg->write_descr.auth_req);
@@ -671,7 +671,6 @@ void btc_gattc_call_handler(btc_msg_t *msg)
671671
btc_ble_gattc_args_t *arg = (btc_ble_gattc_args_t *)(msg->arg);
672672
switch (msg->act) {
673673
case BTC_GATTC_ACT_APP_REGISTER:
674-
LOG_ERROR("%s()", __func__);
675674
btc_gattc_app_register(arg);
676675
break;
677676
case BTC_GATTC_ACT_APP_UNREGISTER:

components/bt/bluedroid/stack/avct/avct_lcb_act.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -377,16 +377,16 @@ void avct_lcb_bind_conn(tAVCT_LCB *p_lcb, tAVCT_LCB_EVT *p_data)
377377
*******************************************************************************/
378378
void avct_lcb_chk_disc(tAVCT_LCB *p_lcb, tAVCT_LCB_EVT *p_data)
379379
{
380-
AVCT_TRACE_WARNING("avct_lcb_chk_disc");
380+
AVCT_TRACE_EVENT("avct_lcb_chk_disc");
381381
#if (AVCT_BROWSE_INCLUDED == TRUE)
382382
avct_close_bcb(p_lcb, p_data);
383383
#endif
384384
if (avct_lcb_last_ccb(p_lcb, p_data->p_ccb)) {
385-
AVCT_TRACE_WARNING("closing");
385+
AVCT_TRACE_EVENT("closing");
386386
p_data->p_ccb->ch_close = TRUE;
387387
avct_lcb_event(p_lcb, AVCT_LCB_INT_CLOSE_EVT, p_data);
388388
} else {
389-
AVCT_TRACE_WARNING("dealloc ccb");
389+
AVCT_TRACE_EVENT("dealloc ccb");
390390
avct_lcb_unbind_disc(p_lcb, p_data);
391391
}
392392
}

components/bt/bluedroid/stack/btm/btm_sec.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2598,7 +2598,6 @@ tBTM_STATUS btm_sec_mx_access_request (BD_ADDR bd_addr, UINT16 psm, BOOLEAN is_o
25982598
void btm_sec_conn_req (UINT8 *bda, UINT8 *dc)
25992599
{
26002600
tBTM_SEC_DEV_REC *p_dev_rec = btm_find_dev (bda);
2601-
BTM_TRACE_ERROR ("%s\n", __func__);
26022601
/* Some device may request a connection before we are done with the HCI_Reset sequence */
26032602
if (!controller_get_interface()->get_is_ready()) {
26042603
BTM_TRACE_ERROR ("Security Manager: connect request when device not ready\n");
@@ -4209,7 +4208,6 @@ void btm_sec_connected (UINT8 *bda, UINT16 handle, UINT8 status, UINT8 enc_mode)
42094208

42104209
btm_acl_resubmit_page();
42114210

4212-
BTM_TRACE_ERROR ("%s\n", __func__);
42134211
/* Commenting out trace due to obf/compilation problems.
42144212
*/
42154213
#if (BT_USE_TRACES == TRUE && SMP_INCLUDED == TRUE)
@@ -5971,7 +5969,7 @@ static void btm_sec_check_pending_enc_req (tBTM_SEC_DEV_REC *p_dev_rec, tBT_TRA
59715969
if (p_e->p_callback) {
59725970
(*p_e->p_callback) (p_dev_rec->bd_addr, transport, p_e->p_ref_data, res);
59735971
}
5974-
5972+
59755973
fixed_queue_try_remove_from_queue(btm_cb.sec_pending_q, (void *)p_e);
59765974
}
59775975
}

components/bt/bluedroid/stack/sdp/sdp_discovery.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ static void process_service_search_attr_rsp (tCONN_CB *p_ccb, UINT8 *p_reply)
656656
/*******************************************************************/
657657

658658
#if (SDP_RAW_DATA_INCLUDED == TRUE)
659-
SDP_TRACE_WARNING("process_service_search_attr_rsp\n");
659+
SDP_TRACE_DEBUG("process_service_search_attr_rsp\n");
660660
sdp_copy_raw_data (p_ccb, TRUE);
661661
#endif
662662

examples/bluetooth/a2dp_sink/main/bt_app_av.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ static void bt_av_hdl_a2d_evt(uint16_t event, void *p_param)
123123
sample_rate = 48000;
124124
}
125125
i2s_set_clk(0, sample_rate, 16, 2);
126-
126+
127127
ESP_LOGI(BT_AV_TAG, "Configure audio player %x-%x-%x-%x",
128128
a2d->audio_cfg.mcc.cie.sbc[0],
129129
a2d->audio_cfg.mcc.cie.sbc[1],

0 commit comments

Comments
 (0)