fix(gpio): add some detailed error log for gpio_pullup_en and gpio_pulldown_en

songruo · songruo · commit 6994be3acdc5 · 2025-04-18T19:03:16.000+08:00
diff --git a/components/esp_driver_gpio/src/gpio.c b/components/esp_driver_gpio/src/gpio.c
@@ -75,7 +75,7 @@ static gpio_context_t gpio_context = {
 
 esp_err_t gpio_pullup_en(gpio_num_t gpio_num)
 {
-    GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error", ESP_ERR_INVALID_ARG);
+    GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error (input-only pad has no internal PU)", ESP_ERR_INVALID_ARG);
 
     if (!rtc_gpio_is_valid_gpio(gpio_num) || SOC_GPIO_SUPPORT_RTC_INDEPENDENT) {
         portENTER_CRITICAL(&gpio_context.gpio_spinlock);
@@ -113,7 +113,7 @@ esp_err_t gpio_pullup_dis(gpio_num_t gpio_num)
 
 esp_err_t gpio_pulldown_en(gpio_num_t gpio_num)
 {
-    GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error", ESP_ERR_INVALID_ARG);
+    GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error (input-only pad has no internal PD)", ESP_ERR_INVALID_ARG);
 
     if (!rtc_gpio_is_valid_gpio(gpio_num) || SOC_GPIO_SUPPORT_RTC_INDEPENDENT) {
         portENTER_CRITICAL(&gpio_context.gpio_spinlock);

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ static gpio_context_t gpio_context = {`
`75`	`75`
`76`	`76`	`esp_err_t gpio_pullup_en(gpio_num_t gpio_num)`
`77`	`77`	`{`
`78`		`- GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error", ESP_ERR_INVALID_ARG);`
	`78`	`+ GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error (input-only pad has no internal PU)", ESP_ERR_INVALID_ARG);`
`79`	`79`
`80`	`80`	`if (!rtc_gpio_is_valid_gpio(gpio_num) \|\| SOC_GPIO_SUPPORT_RTC_INDEPENDENT) {`
`81`	`81`	`portENTER_CRITICAL(&gpio_context.gpio_spinlock);`
`@@ -113,7 +113,7 @@ esp_err_t gpio_pullup_dis(gpio_num_t gpio_num)`
`113`	`113`
`114`	`114`	`esp_err_t gpio_pulldown_en(gpio_num_t gpio_num)`
`115`	`115`	`{`
`116`		`- GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error", ESP_ERR_INVALID_ARG);`
	`116`	`+ GPIO_CHECK(GPIO_IS_VALID_OUTPUT_GPIO(gpio_num), "GPIO number error (input-only pad has no internal PD)", ESP_ERR_INVALID_ARG);`
`117`	`117`
`118`	`118`	`if (!rtc_gpio_is_valid_gpio(gpio_num) \|\| SOC_GPIO_SUPPORT_RTC_INDEPENDENT) {`
`119`	`119`	`portENTER_CRITICAL(&gpio_context.gpio_spinlock);`