Merge branch 'fix/usb_host_enum_unchecked_return_coverity' into 'master'

roma-jam · roma-jam · commit 6ac45b2559c5 · 2025-01-29T19:45:48.000+08:00
fix(usb_host): Fixed unchecked return value in enum driver (coverity)

Closes IDF-10068

See merge request espressif/esp-idf!36663
diff --git a/components/usb/enum.c b/components/usb/enum.c
@@ -198,8 +198,8 @@ static uint8_t get_next_free_dev_addr(void)
         if (usbh_devs_open(new_dev_addr, &dev_hdl) == ESP_ERR_NOT_FOUND) {
             break;
         }
-        // We have a device with the same address on a bus, close device and request new addr
-        usbh_dev_close(dev_hdl);
+        // We have a device with the same address on a bus, close device and request new addr, there should be no error with closing
+        ESP_ERROR_CHECK(usbh_dev_close(dev_hdl));
         new_dev_addr = get_next_dev_addr();
     }
     // Sanity check

Original file line number	Diff line number	Diff line change
`@@ -198,8 +198,8 @@ static uint8_t get_next_free_dev_addr(void)`
`198`	`198`	`if (usbh_devs_open(new_dev_addr, &dev_hdl) == ESP_ERR_NOT_FOUND) {`
`199`	`199`	`break;`
`200`	`200`	`}`
`201`		`- // We have a device with the same address on a bus, close device and request new addr`
`202`		`- usbh_dev_close(dev_hdl);`
	`201`	`+ // We have a device with the same address on a bus, close device and request new addr, there should be no error with closing`
	`202`	`+ ESP_ERROR_CHECK(usbh_dev_close(dev_hdl));`
`203`	`203`	`new_dev_addr = get_next_dev_addr();`
`204`	`204`	`}`
`205`	`205`	`// Sanity check`