Skip to content

Commit 6acb38a

Browse files
committed
Merge branch 'bugfix/idf_monitor_windows10' into 'master'
idf_monitor: Fix bug with Windows 10 sometimes printing a character twice See merge request idf/esp-idf!1964
2 parents d155973 + 3e83cfd commit 6acb38a

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

tools/idf_monitor.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -580,15 +580,13 @@ def __init__(self, output):
580580
self.matched = b''
581581

582582
def _output_write(self, data):
583-
# Windows 10 bug since the Fall Creators Update, sometimes writing to console randomly fails
584-
# (but usually succeeds afterwards, it seems.)
585-
# Ref https://github.com/espressif/esp-idf/issues/1136
586-
for tries in range(3):
587-
try:
588-
self.output.write(data)
589-
return
590-
except IOError:
591-
pass
583+
try:
584+
self.output.write(data)
585+
except IOError:
586+
# Windows 10 bug since the Fall Creators Update, sometimes writing to console randomly throws
587+
# an exception (however, the character is still written to the screen)
588+
# Ref https://github.com/espressif/esp-idf/issues/1136
589+
pass
592590

593591
def write(self, data):
594592
for b in data:

0 commit comments

Comments
 (0)