Merge branch 'fix/esp_netif_minor_leak' into 'master'

david-cermak · david-cermak · commit 7ab29a89e5a3 · 2025-09-27T03:59:32.000+08:00
Fix tiny memory leak when PPP connection creation fails in esp_netif_new_ppp (GitHub PR)

Closes IDFGH-16327

See merge request espressif/esp-idf!42126
diff --git a/components/esp_netif/lwip/esp_netif_lwip_ppp.c b/components/esp_netif/lwip/esp_netif_lwip_ppp.c
@@ -229,6 +229,7 @@ netif_related_data_t * esp_netif_new_ppp(esp_netif_t *esp_netif, const esp_netif
     ESP_LOGD(TAG, "%s: PPP connection created: %p", __func__, ppp_obj->ppp);
     if (!ppp_obj->ppp) {
         ESP_LOGE(TAG, "%s: lwIP PPP connection cannot be created", __func__);
+        free(ppp_obj);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -229,6 +229,7 @@ netif_related_data_t * esp_netif_new_ppp(esp_netif_t *esp_netif, const esp_netif`
`229`	`229`	`ESP_LOGD(TAG, "%s: PPP connection created: %p", __func__, ppp_obj->ppp);`
`230`	`230`	`if (!ppp_obj->ppp) {`
`231`	`231`	`ESP_LOGE(TAG, "%s: lwIP PPP connection cannot be created", __func__);`
	`232`	`+ free(ppp_obj);`
`232`	`233`	`return NULL;`
`233`	`234`	`}`
`234`	`235`