Skip to content

Commit 9f4a28f

Browse files
committed
Merge branch 'fix/lwip_remove_unused_flags' into 'master'
[lwip]: Removed unused lwip flags Closes IDF-10227 See merge request espressif/esp-idf!42123
2 parents a3a8643 + 69baa8f commit 9f4a28f

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

components/lwip/port/debug/lwip_debug.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,6 @@ static void dbg_lwip_tcp_pcb_one_show(struct tcp_pcb* pcb)
8787
ESP_LWIP_LOGI("rttest=%" PRIu32 " rtseq=%" PRIu32 " sa=%d sv=%d", pcb->rttest, pcb->rtseq, pcb->sa, pcb->sv);
8888
ESP_LWIP_LOGI("rto=%d nrtx=%d", pcb->rto, pcb->nrtx);
8989
ESP_LWIP_LOGI("dupacks=%d lastack=%" PRIu32, pcb->dupacks, pcb->lastack);
90-
#if ESP_PER_SOC_TCP_WND
91-
ESP_LWIP_LOGI("per_soc_window=%d per_soc_snd_buf=%d", pcb->per_soc_tcp_wnd, pcb->per_soc_tcp_snd_buf);
92-
#endif
9390
ESP_LWIP_LOGI("cwnd=%"TCPWNDSIZE_F" ssthreash=%"TCPWNDSIZE_F, pcb->cwnd, pcb->ssthresh);
9491
ESP_LWIP_LOGI("snd_next=%" PRIu32 " snd_wl1=%" PRIu32 " snd_wl2=%" PRIu32, pcb->snd_nxt, pcb->snd_wl1, pcb->snd_wl2);
9592
ESP_LWIP_LOGI("snd_lbb=%" PRIu32 " snd_wnd=%"TCPWNDSIZE_F" snd_wnd_max=%"TCPWNDSIZE_F, pcb->snd_lbb, pcb->snd_wnd, pcb->snd_wnd_max);

components/lwip/port/freertos/sys_arch.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@ sys_mutex_new(sys_mutex_t *pxMutex)
4343
{
4444
*pxMutex = xSemaphoreCreateMutex();
4545
if (*pxMutex == NULL) {
46-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sys_mutex_new: out of mem\r\n"));
46+
LWIP_DEBUGF(SYS_DEBUG, ("sys_mutex_new: out of mem\r\n"));
4747
return ERR_MEM;
4848
}
4949

50-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sys_mutex_new: m=%p\n", *pxMutex));
50+
LWIP_DEBUGF(SYS_DEBUG, ("sys_mutex_new: m=%p\n", *pxMutex));
5151

5252
return ERR_OK;
5353
}
@@ -88,7 +88,7 @@ sys_mutex_unlock(sys_mutex_t *pxMutex)
8888
void
8989
sys_mutex_free(sys_mutex_t *pxMutex)
9090
{
91-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sys_mutex_free: m=%p\n", *pxMutex));
91+
LWIP_DEBUGF(SYS_DEBUG, ("sys_mutex_free: m=%p\n", *pxMutex));
9292
vSemaphoreDelete(*pxMutex);
9393
*pxMutex = NULL;
9494
}
@@ -110,7 +110,7 @@ sys_sem_new(sys_sem_t *sem, u8_t count)
110110

111111
*sem = xSemaphoreCreateBinary();
112112
if (*sem == NULL) {
113-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sys_sem_new: out of mem\r\n"));
113+
LWIP_DEBUGF(SYS_DEBUG, ("sys_sem_new: out of mem\r\n"));
114114
return ERR_MEM;
115115
}
116116

@@ -207,19 +207,19 @@ sys_mbox_new(sys_mbox_t *mbox, int size)
207207
{
208208
*mbox = mem_malloc(sizeof(struct sys_mbox_s));
209209
if (*mbox == NULL){
210-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("fail to new *mbox\n"));
210+
LWIP_DEBUGF(SYS_DEBUG, ("fail to new *mbox\n"));
211211
return ERR_MEM;
212212
}
213213

214214
(*mbox)->os_mbox = xQueueCreate(size, sizeof(void *));
215215

216216
if ((*mbox)->os_mbox == NULL) {
217-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("fail to new (*mbox)->os_mbox\n"));
217+
LWIP_DEBUGF(SYS_DEBUG, ("fail to new (*mbox)->os_mbox\n"));
218218
mem_free(*mbox);
219219
return ERR_MEM;
220220
}
221221

222-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("new *mbox ok mbox=%p os_mbox=%p\n", *mbox, (*mbox)->os_mbox));
222+
LWIP_DEBUGF(SYS_DEBUG, ("new *mbox ok mbox=%p os_mbox=%p\n", *mbox, (*mbox)->os_mbox));
223223
return ERR_OK;
224224
}
225225

@@ -252,7 +252,7 @@ sys_mbox_trypost(sys_mbox_t *mbox, void *msg)
252252
if (xQueueSend((*mbox)->os_mbox, &msg, 0) == pdTRUE) {
253253
xReturn = ERR_OK;
254254
} else {
255-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("trypost mbox=%p fail\n", (*mbox)->os_mbox));
255+
LWIP_DEBUGF(SYS_DEBUG, ("trypost mbox=%p fail\n", (*mbox)->os_mbox));
256256
xReturn = ERR_MEM;
257257
}
258258

@@ -481,7 +481,7 @@ sys_thread_sem_get(void)
481481
if (!sem) {
482482
sem = sys_thread_sem_init();
483483
}
484-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sem_get s=%p\n", sem));
484+
LWIP_DEBUGF(SYS_DEBUG, ("sem_get s=%p\n", sem));
485485
return sem;
486486
}
487487

@@ -491,12 +491,12 @@ sys_thread_sem_free(void* data) // destructor for TLS semaphore
491491
sys_sem_t *sem = (sys_sem_t*)(data);
492492

493493
if (sem && *sem){
494-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sem del, sem=%p\n", *sem));
494+
LWIP_DEBUGF(SYS_DEBUG, ("sem del, sem=%p\n", *sem));
495495
vSemaphoreDelete(*sem);
496496
}
497497

498498
if (sem) {
499-
LWIP_DEBUGF(ESP_THREAD_SAFE_DEBUG, ("sem pointer del, sem_p=%p\n", sem));
499+
LWIP_DEBUGF(SYS_DEBUG, ("sem pointer del, sem_p=%p\n", sem));
500500
mem_free(sem);
501501
}
502502
}

components/lwip/port/include/lwipopts.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1669,11 +1669,10 @@ static inline uint32_t timeout_from_offered(uint32_t lease, uint32_t min)
16691669
#define ESP_MLDV6_REPORT 0
16701670
#endif
16711671

1672+
#define SYS_DEBUG LWIP_DBG_OFF
1673+
16721674
#define ESP_LWIP 1
16731675
#define ESP_LWIP_ARP 1
1674-
#define ESP_PER_SOC_TCP_WND 0
1675-
#define ESP_THREAD_SAFE 1 /* Not used (to be removed in v6.x) */
1676-
#define ESP_THREAD_SAFE_DEBUG LWIP_DBG_OFF
16771676
#define ESP_DHCP 1
16781677
#define ESP_DNS 1
16791678
#define ESP_STATS_TCP 0

0 commit comments

Comments
 (0)