@@ -52,7 +52,6 @@ const static char *TAG = "esp_apptrace";
5252
5353static uint32_t esp_apptrace_membufs_down_buffer_write_nolock (esp_apptrace_membufs_proto_data_t * proto , uint8_t * data , uint32_t size );
5454
55-
5655esp_err_t esp_apptrace_membufs_init (esp_apptrace_membufs_proto_data_t * proto , const esp_apptrace_mem_block_t blocks_cfg [2 ])
5756{
5857 // disabled by default
@@ -66,7 +65,7 @@ esp_err_t esp_apptrace_membufs_init(esp_apptrace_membufs_proto_data_t *proto, co
6665 proto -> state .in_block = 0 ;
6766#if CONFIG_APPTRACE_PENDING_DATA_SIZE_MAX > 0
6867 esp_apptrace_rb_init (& proto -> rb_pend , proto -> pending_data ,
69- sizeof (proto -> pending_data ));
68+ sizeof (proto -> pending_data ));
7069#endif
7170 return ESP_OK ;
7271}
@@ -101,13 +100,13 @@ static esp_err_t esp_apptrace_membufs_swap(esp_apptrace_membufs_proto_data_t *pr
101100 // TODO: add support for multiple blocks from host, currently there is no need for that
102101 uint8_t * p = proto -> blocks [new_block_num ].start + proto -> blocks [new_block_num ].sz ;
103102 ESP_APPTRACE_LOGD ("Recvd %" PRIu16 " bytes from host (@ %p) [%x %x %x %x %x %x %x %x .. %x %x %x %x %x %x %x %x]" ,
104- hdr -> block_sz , proto -> blocks [new_block_num ].start ,
105- * (proto -> blocks [new_block_num ].start + 0 ), * (proto -> blocks [new_block_num ].start + 1 ),
106- * (proto -> blocks [new_block_num ].start + 2 ), * (proto -> blocks [new_block_num ].start + 3 ),
107- * (proto -> blocks [new_block_num ].start + 4 ), * (proto -> blocks [new_block_num ].start + 5 ),
108- * (proto -> blocks [new_block_num ].start + 6 ), * (proto -> blocks [new_block_num ].start + 7 ),
109- * (p - 8 ), * (p - 7 ), * (p - 6 ), * (p - 5 ), * (p - 4 ), * (p - 3 ), * (p - 2 ), * (p - 1 ));
110- uint32_t sz = esp_apptrace_membufs_down_buffer_write_nolock (proto , (uint8_t * )(hdr + 1 ), hdr -> block_sz );
103+ hdr -> block_sz , proto -> blocks [new_block_num ].start ,
104+ * (proto -> blocks [new_block_num ].start + 0 ), * (proto -> blocks [new_block_num ].start + 1 ),
105+ * (proto -> blocks [new_block_num ].start + 2 ), * (proto -> blocks [new_block_num ].start + 3 ),
106+ * (proto -> blocks [new_block_num ].start + 4 ), * (proto -> blocks [new_block_num ].start + 5 ),
107+ * (proto -> blocks [new_block_num ].start + 6 ), * (proto -> blocks [new_block_num ].start + 7 ),
108+ * (p - 8 ), * (p - 7 ), * (p - 6 ), * (p - 5 ), * (p - 4 ), * (p - 3 ), * (p - 2 ), * (p - 1 ));
109+ uint32_t sz = esp_apptrace_membufs_down_buffer_write_nolock (proto , (uint8_t * )(hdr + 1 ), hdr -> block_sz );
111110 if (sz != hdr -> block_sz ) {
112111 ESP_APPTRACE_LOGE ("Failed to write %" PRIu32 " bytes to down buffer (%" PRIu16 " %" PRIu32 ")!" , hdr -> block_sz - sz , hdr -> block_sz , sz );
113112 }
@@ -129,8 +128,8 @@ static esp_err_t esp_apptrace_membufs_swap(esp_apptrace_membufs_proto_data_t *pr
129128 break ;
130129 }
131130 ESP_APPTRACE_LOGD ("Pump %d pend bytes [%x %x %x %x : %x %x %x %x : %x %x %x %x : %x %x...%x %x]" ,
132- read_sz , * (ptr + 0 ), * (ptr + 1 ), * (ptr + 2 ), * (ptr + 3 ), * (ptr + 4 ),
133- * (ptr + 5 ), * (ptr + 6 ), * (ptr + 7 ), * (ptr + 8 ), * (ptr + 9 ), * (ptr + 10 ), * (ptr + 11 ), * (ptr + 12 ), * (ptr + 13 ), * (ptr + read_sz - 2 ), * (ptr + read_sz - 1 ));
131+ read_sz , * (ptr + 0 ), * (ptr + 1 ), * (ptr + 2 ), * (ptr + 3 ), * (ptr + 4 ),
132+ * (ptr + 5 ), * (ptr + 6 ), * (ptr + 7 ), * (ptr + 8 ), * (ptr + 9 ), * (ptr + 10 ), * (ptr + 11 ), * (ptr + 12 ), * (ptr + 13 ), * (ptr + read_sz - 2 ), * (ptr + read_sz - 1 ));
134133 memcpy (proto -> blocks [new_block_num ].start + proto -> state .markers [new_block_num ], ptr , read_sz );
135134 proto -> state .markers [new_block_num ] += read_sz ;
136135 }
@@ -209,7 +208,7 @@ static uint32_t esp_apptrace_membufs_down_buffer_write_nolock(esp_apptrace_membu
209208
210209 while (total_sz < size ) {
211210 ESP_APPTRACE_LOGD ("esp_apptrace_trax_down_buffer_write_nolock WRS %" PRIu32 "-%" PRIu32 "-%" PRIu32 " %" PRIu32 , proto -> rb_down .wr , proto -> rb_down .rd ,
212- proto -> rb_down .cur_size , size );
211+ proto -> rb_down .cur_size , size );
213212 uint32_t wr_sz = esp_apptrace_rb_write_size_get (& proto -> rb_down );
214213 if (wr_sz == 0 ) {
215214 break ;
@@ -319,10 +318,10 @@ uint8_t *esp_apptrace_membufs_up_buffer_get(esp_apptrace_membufs_proto_data_t *p
319318 if (1 ) {
320319#endif
321320 if (ESP_APPTRACE_INBLOCK_MARKER (proto ) + ESP_APPTRACE_USR_BLOCK_RAW_SZ (size ) > ESP_APPTRACE_INBLOCK (proto )-> sz ) {
322- #if CONFIG_APPTRACE_PENDING_DATA_SIZE_MAX > 0
321+ #if CONFIG_APPTRACE_PENDING_DATA_SIZE_MAX > 0
323322 ESP_APPTRACE_LOGD ("Block full. Get %" PRIu32 " bytes from PEND buffer" , size );
324323 buf_ptr = esp_apptrace_rb_produce (& proto -> rb_pend , ESP_APPTRACE_USR_BLOCK_RAW_SZ (size ));
325- #endif
324+ #endif
326325 if (buf_ptr == NULL ) {
327326 int pended_buf ;
328327 ESP_APPTRACE_LOGD (" full. Get %" PRIu32 " bytes from pend buffer" , size );
@@ -372,10 +371,11 @@ esp_err_t esp_apptrace_membufs_flush_nolock(esp_apptrace_membufs_proto_data_t *p
372371 ESP_APPTRACE_LOGD ("Try to flush %" PRIu32 " bytes" , ESP_APPTRACE_INBLOCK_MARKER (proto ));
373372 res = esp_apptrace_membufs_swap_waitus (proto , tmo );
374373 if (res != ESP_OK ) {
375- if (res == ESP_ERR_TIMEOUT )
374+ if (res == ESP_ERR_TIMEOUT ) {
376375 ESP_APPTRACE_LOGW ("Failed to switch to another block in %" PRIi32 " us!" , (int32_t )tmo -> elapsed );
377- else
376+ } else {
378377 ESP_APPTRACE_LOGE ("Failed to switch to another block, res: %d" , res );
378+ }
379379 return res ;
380380 }
381381 }
0 commit comments