Skip to content

Commit a36c8b8

Browse files
Vincent-Dalstraespressif-bot
authored andcommitted
fix: Add quotes around node ID in dependency graph
Graphviz node ID's are represented as strings, that can only use a restricted set of characters (characters, digits, and underscores), and must not match a reserved keyword. These restrictions do not apply when the string is wrapped in double quotes. This allows for component names with dashes in them, for example. Closes #17594
1 parent 08e4aba commit a36c8b8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/cmake/depgraph.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ function(depgraph_add_edge dep_from dep_to)
3535
# However, show which components are "common" by adding an edge from a node named "common".
3636
# If necessary, add a new build property to customize this behavior.
3737
if(NOT dep_from IN_LIST common_reqs)
38-
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "common -> ${dep_to}" APPEND)
38+
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"common\" -> \"${dep_to}\"" APPEND)
3939
endif()
4040
else()
41-
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "${dep_from} -> ${dep_to} ${attr}" APPEND)
41+
idf_build_set_property(__BUILD_COMPONENT_DEPGRAPH "\"${dep_from}\" -> \"${dep_to}\" ${attr}" APPEND)
4242
endif()
4343
endfunction()
4444

0 commit comments

Comments
 (0)