Skip to content

Commit a4cb2dc

Browse files
committed
remove(i2s): remove deprecated configuration in IDF v6.0
1 parent bf3a050 commit a4cb2dc

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

components/esp_driver_i2s/i2s_common.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -573,10 +573,6 @@ uint32_t i2s_get_source_clk_freq(i2s_clock_src_t clk_src, uint32_t mclk_freq_hz)
573573
return clk_freq;
574574
}
575575

576-
/* Temporary ignore the deprecated warning of i2s_event_data_t::data */
577-
#pragma GCC diagnostic push
578-
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
579-
580576
#if SOC_GDMA_SUPPORTED
581577
static bool IRAM_ATTR i2s_dma_rx_callback(gdma_channel_handle_t dma_chan, gdma_event_data_t *event_data, void *user_data)
582578
{
@@ -592,7 +588,6 @@ static bool IRAM_ATTR i2s_dma_rx_callback(gdma_channel_handle_t dma_chan, gdma_e
592588
esp_cache_msync((void *)finish_desc->buf, handle->dma.buf_size, ESP_CACHE_MSYNC_FLAG_INVALIDATE);
593589
#endif
594590
i2s_event_data_t evt = {
595-
.data = &(finish_desc->buf),
596591
.dma_buf = (void *)finish_desc->buf,
597592
.size = handle->dma.buf_size,
598593
};
@@ -602,7 +597,6 @@ static bool IRAM_ATTR i2s_dma_rx_callback(gdma_channel_handle_t dma_chan, gdma_e
602597
if (xQueueIsQueueFullFromISR(handle->msg_queue)) {
603598
xQueueReceiveFromISR(handle->msg_queue, &dummy, &need_yield1);
604599
if (handle->callbacks.on_recv_q_ovf) {
605-
evt.data = NULL;
606600
user_need_yield |= handle->callbacks.on_recv_q_ovf(handle, &evt, handle->user_data);
607601
}
608602
}
@@ -623,7 +617,6 @@ static bool IRAM_ATTR i2s_dma_tx_callback(gdma_channel_handle_t dma_chan, gdma_e
623617
finish_desc = (lldesc_t *)event_data->tx_eof_desc_addr;
624618
void *curr_buf = (void *)finish_desc->buf;
625619
i2s_event_data_t evt = {
626-
.data = &(finish_desc->buf),
627620
.dma_buf = curr_buf,
628621
.size = handle->dma.buf_size,
629622
};
@@ -642,7 +635,6 @@ static bool IRAM_ATTR i2s_dma_tx_callback(gdma_channel_handle_t dma_chan, gdma_e
642635
if (xQueueIsQueueFullFromISR(handle->msg_queue)) {
643636
xQueueReceiveFromISR(handle->msg_queue, &dummy, &need_yield1);
644637
if (handle->callbacks.on_send_q_ovf) {
645-
evt.data = NULL;
646638
evt.dma_buf = NULL;
647639
user_need_yield |= handle->callbacks.on_send_q_ovf(handle, &evt, handle->user_data);
648640
}
@@ -678,7 +670,6 @@ static void IRAM_ATTR i2s_dma_rx_callback(void *arg)
678670

679671
if (handle && (status & I2S_LL_EVENT_RX_EOF)) {
680672
i2s_hal_get_in_eof_des_addr(&(handle->controller->hal), (uint32_t *)&finish_desc);
681-
evt.data = &(finish_desc->buf);
682673
evt.dma_buf = (void *)finish_desc->buf;
683674
evt.size = handle->dma.buf_size;
684675
if (handle->callbacks.on_recv) {
@@ -687,7 +678,6 @@ static void IRAM_ATTR i2s_dma_rx_callback(void *arg)
687678
if (xQueueIsQueueFullFromISR(handle->msg_queue)) {
688679
xQueueReceiveFromISR(handle->msg_queue, &dummy, &need_yield1);
689680
if (handle->callbacks.on_recv_q_ovf) {
690-
evt.data = NULL;
691681
evt.dma_buf = NULL;
692682
user_need_yield |= handle->callbacks.on_recv_q_ovf(handle, &evt, handle->user_data);
693683
}
@@ -719,7 +709,6 @@ static void IRAM_ATTR i2s_dma_tx_callback(void *arg)
719709
if (handle && (status & I2S_LL_EVENT_TX_EOF)) {
720710
i2s_hal_get_out_eof_des_addr(&(handle->controller->hal), (uint32_t *)&finish_desc);
721711
void *curr_buf = (void *)finish_desc->buf;
722-
evt.data = &(finish_desc->buf);
723712
evt.dma_buf = curr_buf;
724713
evt.size = handle->dma.buf_size;
725714
// Auto clear the dma buffer before data sent
@@ -732,7 +721,6 @@ static void IRAM_ATTR i2s_dma_tx_callback(void *arg)
732721
if (xQueueIsQueueFullFromISR(handle->msg_queue)) {
733722
xQueueReceiveFromISR(handle->msg_queue, &dummy, &need_yield1);
734723
if (handle->callbacks.on_send_q_ovf) {
735-
evt.data = NULL;
736724
user_need_yield |= handle->callbacks.on_send_q_ovf(handle, &evt, handle->user_data);
737725
}
738726
}
@@ -749,8 +737,6 @@ static void IRAM_ATTR i2s_dma_tx_callback(void *arg)
749737
}
750738
#endif
751739

752-
#pragma GCC diagnostic pop
753-
754740
#if SOC_GDMA_SUPPORTED
755741
/**
756742
* @brief I2S DMA interrupt initialization (implemented by I2S dedicated DMA)

components/esp_driver_i2s/include/driver/i2s_types.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,6 @@ typedef struct {
7575
* @brief Event structure used in I2S event queue
7676
*/
7777
typedef struct {
78-
void *data __attribute__((deprecated)); /**< (Deprecated) The secondary pointer of DMA buffer that just finished sending or receiving for `on_recv` and `on_sent` callback
79-
* NULL for `on_recv_q_ovf` and `on_send_q_ovf` callback
80-
*/
8178
void *dma_buf;/**< The first level pointer of DMA buffer that just finished sending or receiving for `on_recv` and `on_sent` callback
8279
* NULL for `on_recv_q_ovf` and `on_send_q_ovf` callback
8380
*/

0 commit comments

Comments
 (0)