fix(http): fix invalid content-length header in http get

TeXniKK · TeXniKK · commit c87cb854f320 · 2024-08-29T00:14:49.000+02:00
diff --git a/components/esp_http_client/esp_http_client.c b/components/esp_http_client/esp_http_client.c
@@ -1493,7 +1493,12 @@ static esp_err_t esp_http_client_connect(esp_http_client_handle_t client)
 static int http_client_prepare_first_line(esp_http_client_handle_t client, int write_len)
 {
     if (write_len >= 0) {
-        http_header_set_format(client->request->headers, "Content-Length", "%d", write_len);
+        const bool length_required = (client->connection_info.method != HTTP_METHOD_GET &&
+                                      client->connection_info.method != HTTP_METHOD_HEAD &&
+                                      client->connection_info.method != HTTP_METHOD_DELETE);
+        if (write_len != 0 || length_required) {
+            http_header_set_format(client->request->headers, "Content-Length", "%d", write_len);
+        }
     } else {
         esp_http_client_set_header(client, "Transfer-Encoding", "chunked");
     }

Original file line number	Diff line number	Diff line change
`@@ -1493,7 +1493,12 @@ static esp_err_t esp_http_client_connect(esp_http_client_handle_t client)`
`1493`	`1493`	`static int http_client_prepare_first_line(esp_http_client_handle_t client, int write_len)`
`1494`	`1494`	`{`
`1495`	`1495`	`if (write_len >= 0) {`
`1496`		`- http_header_set_format(client->request->headers, "Content-Length", "%d", write_len);`
	`1496`	`+ const bool length_required = (client->connection_info.method != HTTP_METHOD_GET &&`
	`1497`	`+ client->connection_info.method != HTTP_METHOD_HEAD &&`
	`1498`	`+ client->connection_info.method != HTTP_METHOD_DELETE);`
	`1499`	`+ if (write_len != 0 \|\| length_required) {`
	`1500`	`+ http_header_set_format(client->request->headers, "Content-Length", "%d", write_len);`
	`1501`	`+ }`
`1497`	`1502`	`} else {`
`1498`	`1503`	`esp_http_client_set_header(client, "Transfer-Encoding", "chunked");`
`1499`	`1504`	`}`