Skip to content

Commit d9fdb0b

Browse files
committed
fix(driver_twai): improve twai ci test
1 parent c5a7513 commit d9fdb0b

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

components/driver/test_apps/legacy_twai/pytest_twai.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def test_twai_self(dut: Dut) -> None:
2626
dut.run_all_single_board_cases(group='twai-loop-back')
2727

2828

29-
@pytest.fixture(name='socket_can', scope='module')
29+
@pytest.fixture(name='socket_can')
3030
def fixture_create_socket_can() -> Bus:
3131
# Set up the socket CAN with the bitrate
3232
start_command = 'sudo ip link set can0 up type can bitrate 250000 restart-ms 100'

components/esp_driver_twai/test_apps/test_twai/pytest_driver_twai.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ def fixture_create_socket_can() -> Bus:
3838
@pytest.mark.twai_std
3939
@pytest.mark.temp_skip_ci(targets=['esp32c5'], reason='no runner')
4040
@pytest.mark.parametrize('config', ['release'], indirect=True)
41-
@pytest.mark.timeout(10) # Whole test timeout
4241
@idf_parametrize('target', soc_filtered_targets('SOC_TWAI_SUPPORTED == 1'), indirect=['target'])
4342
def test_driver_twai_listen_only(dut: Dut, socket_can: Bus) -> None:
4443
dut.serial.hard_reset()
@@ -62,7 +61,6 @@ def test_driver_twai_listen_only(dut: Dut, socket_can: Bus) -> None:
6261
@pytest.mark.twai_std
6362
@pytest.mark.temp_skip_ci(targets=['esp32c5'], reason='no runner')
6463
@pytest.mark.parametrize('config', ['release'], indirect=True)
65-
@pytest.mark.timeout(10) # Whole test timeout
6664
@idf_parametrize('target', soc_filtered_targets('SOC_TWAI_SUPPORTED == 1'), indirect=['target'])
6765
def test_driver_twai_remote_request(dut: Dut, socket_can: Bus) -> None:
6866
dut.serial.hard_reset()

0 commit comments

Comments
 (0)