Skip to content

Commit f9961fd

Browse files
committed
fix(esp_http_client): added initial argument checking for APIs'
This MR added checks for arguments passed in APIS' of esp_http_client.c
1 parent 73e1085 commit f9961fd

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

components/esp_http_client/esp_http_client.c

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,21 +356,37 @@ static int http_on_chunk_header(http_parser *parser)
356356

357357
esp_err_t esp_http_client_set_header(esp_http_client_handle_t client, const char *key, const char *value)
358358
{
359+
if (client == NULL || client->request == NULL || client->request->headers == NULL || key == NULL || value == NULL) {
360+
return ESP_ERR_INVALID_ARG;
361+
}
362+
359363
return http_header_set(client->request->headers, key, value);
360364
}
361365

362366
esp_err_t esp_http_client_get_header(esp_http_client_handle_t client, const char *key, char **value)
363367
{
368+
if (client == NULL || client->request == NULL || client->request->headers == NULL || key == NULL) {
369+
return ESP_ERR_INVALID_ARG;
370+
}
371+
364372
return http_header_get(client->request->headers, key, value);
365373
}
366374

367375
esp_err_t esp_http_client_delete_header(esp_http_client_handle_t client, const char *key)
368376
{
377+
if (client == NULL || client->request == NULL || client->request->headers == NULL || key == NULL) {
378+
return ESP_ERR_INVALID_ARG;
379+
}
380+
369381
return http_header_delete(client->request->headers, key);
370382
}
371383

372-
esp_err_t esp_http_client_delete_headers(esp_http_client_handle_t client)
384+
esp_err_t esp_http_client_delete_all_headers(esp_http_client_handle_t client)
373385
{
386+
if (client == NULL || client->request == NULL || client->request->headers == NULL) {
387+
return ESP_ERR_INVALID_ARG;
388+
}
389+
374390
return http_header_clean(client->request->headers);
375391
}
376392

components/esp_http_client/include/esp_http_client.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,7 @@ esp_err_t esp_http_client_delete_header(esp_http_client_handle_t client, const c
496496
* - ESP_OK
497497
* - ESP_FAIL
498498
*/
499-
esp_err_t esp_http_client_delete_headers(esp_http_client_handle_t client);
499+
esp_err_t esp_http_client_delete_all_headers(esp_http_client_handle_t client);
500500

501501
/**
502502
* @brief This function will be open the connection, write all header strings and return

0 commit comments

Comments
 (0)