fix(led_indicator): fix ledc default low output in activate-low mode

close #551

Author: YanKE01

components/led/led_indicator/CHANGELOG.md

@@ -1,5 +1,11 @@
 # ChangeLog
 
+## v2.0.1 - 2025-8-12
+
+### Bugfix
+
+* Fix: For LEDs driven by the LEDC driver with active-low enable, use the LEDC inversion function to avoid the LED turning on immediately after creation due to an initial low-level output.
+
 ## v2.0.0 - 2025-7-30
 
 ### Improve:

components/led/led_indicator/idf_component.yml

@@ -1,4 +1,4 @@
-version: "2.0.0"
+version: "2.0.1"
 description: LED indicator driver
 url: https://github.com/espressif/esp-iot-solution/tree/master/components/led/led_indicator
 dependencies:

components/led/led_indicator/src/led_indicator_ledc.c

@@ -5,6 +5,7 @@
  */
 
 #include <math.h>
+#include "driver/gpio.h"
 #include "driver/ledc.h"
 #include "esp_log.h"
 #include "led_indicator_ledc.h"
@@ -56,6 +57,7 @@ static esp_err_t led_indicator_ledc_init(void *param)
     ledc_channel_t ch = cfg->channel;
     LED_LEDC_CHECK(!s_ledc->ledc_channel[ch].is_init, "LEDC channel is already initialized!", goto EXIT);
     ledc_channel_config_t ledc_ch_cfg = LEDC_CHANNEL_CONFIG(cfg->timer_num, cfg->channel, cfg->gpio_num);
+    ledc_ch_cfg.flags.output_invert = cfg->is_active_level_high ? false : true;
     ret = ledc_channel_config(&ledc_ch_cfg);
     LED_LEDC_CHECK(ESP_OK == ret, "ledc_channel_config fail!", goto EXIT);
     s_ledc->ledc_channel[ch].channel = ch;
@@ -93,9 +95,6 @@ static esp_err_t led_indicator_ledc_set_on_off(void *channel, bool on_off)
     uint32_t ch = (uint32_t)channel;
     LED_LEDC_CHECK(s_ledc->ledc_channel[ch].is_init, "LEDC channel doesn't init", return ESP_FAIL);
     uint32_t duty = on_off ? s_ledc->max_duty : 0;
-    if (!s_ledc->ledc_channel[ch].is_active_level_high) {
-        duty = s_ledc->max_duty - duty;
-    }
 
     ret = ledc_set_duty(LEDC_MODE, s_ledc->ledc_channel[ch].channel, duty);
     LED_LEDC_CHECK(ESP_OK == ret, "LEDC set duty error", return ret);
@@ -110,7 +109,6 @@ static esp_err_t led_indicator_ledc_set_brightness(void *channel, uint32_t brigh
     uint32_t ch = (uint32_t)channel;
     LED_LEDC_CHECK(s_ledc->ledc_channel[ch].is_init, "LEDC channel doesn't init", return ESP_FAIL);
     LED_LEDC_CHECK(brightness <= UINT8_MAX, "brightness can't be larger than UINT8_MAX", return ESP_FAIL);
-    brightness = s_ledc->ledc_channel[ch].is_active_level_high ? brightness : (UINT8_MAX - brightness);
     ret = ledc_set_duty(LEDC_MODE, s_ledc->ledc_channel[ch].channel, brightness * s_ledc->max_duty / UINT8_MAX);
     LED_LEDC_CHECK(ESP_OK == ret, "LEDC set duty error", return ret);
     ret = ledc_update_duty(LEDC_MODE, s_ledc->ledc_channel[ch].channel);

components/led/led_indicator/src/led_indicator_rgb.c

@@ -5,6 +5,7 @@
  */
 
 #include <math.h>
+#include "driver/gpio.h"
 #include "driver/ledc.h"
 #include "esp_log.h"
 #include "led_indicator_rgb.h"
@@ -42,12 +43,15 @@ static esp_err_t led_indicator_rgb_init(void *param, void **ret_rgb)
     }
 
     ledc_channel_config_t red_ch_cfg = LEDC_CHANNEL_CONFIG(cfg->timer_num, cfg->red_channel, cfg->red_gpio_num);
+    red_ch_cfg.flags.output_invert = cfg->is_active_level_high ? false : true;
     ret = ledc_channel_config(&red_ch_cfg);
     LED_RGB_CHECK(ESP_OK == ret, "red ledc_channel_config fail!", goto EXIT);
     ledc_channel_config_t green_ch_cfg = LEDC_CHANNEL_CONFIG(cfg->timer_num, cfg->green_channel, cfg->green_gpio_num);
+    green_ch_cfg.flags.output_invert = cfg->is_active_level_high ? false : true;
     ret = ledc_channel_config(&green_ch_cfg);
     LED_RGB_CHECK(ESP_OK == ret, "green ledc_channel_config fail!", goto EXIT);
     ledc_channel_config_t blue_ch_cfg = LEDC_CHANNEL_CONFIG(cfg->timer_num, cfg->blue_channel, cfg->blue_gpio_num);
+    blue_ch_cfg.flags.output_invert = cfg->is_active_level_high ? false : true;
     ret = ledc_channel_config(&blue_ch_cfg);
     LED_RGB_CHECK(ESP_OK == ret, "blud ledc_channel_config fail!", goto EXIT);
     rgb->rgb_channel[0] = cfg->red_channel;
@@ -73,11 +77,6 @@ static esp_err_t led_indicator_rgb_deinit(void *rgb_handle)
 static esp_err_t led_indicator_rgb_set_duty(led_rgb_t *p_rgb, uint32_t rgb[])
 {
     esp_err_t ret;
-    if (!p_rgb->is_active_level_high) {
-        rgb[0] = p_rgb->max_duty - rgb[0];
-        rgb[1] = p_rgb->max_duty - rgb[1];
-        rgb[2] = p_rgb->max_duty - rgb[2];
-    }
     for (int i = 0; i < 3; i++) {
         ret = ledc_set_duty(LEDC_MODE, p_rgb->rgb_channel[i], rgb[i]);
         LED_RGB_CHECK(ESP_OK == ret, "LEDC set duty error", return ret);