Skip to content

Commit 23790cd

Browse files
committed
Merge branch 'fix-attribute-types-1-3' into 'release/v1.3'
[v1.3] components/esp-matter: fix types for on_time and off_wait_time See merge request app-frameworks/esp-matter!1347
2 parents 057b237 + 3a52432 commit 23790cd

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ build_image:
208208
- *add_gitlab_ssh_key
209209
- *get_build_caches
210210
- *setup_idf
211-
- pip install 'idf-component-manager~=1.4.0'
211+
- pip install 'idf-component-manager~=2.2'
212212
- cd ${ESP_MATTER_PATH}
213213
- mkdir -p ${REPOS_PATH}
214214
- *update_build_caches

components/esp_matter/esp_matter_attribute.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1129,18 +1129,18 @@ attribute_t *create_global_scene_control(cluster_t *cluster, bool value)
11291129
esp_matter_bool(value));
11301130
}
11311131

1132-
attribute_t *create_on_time(cluster_t *cluster, nullable<uint16_t> value)
1132+
attribute_t *create_on_time(cluster_t *cluster, uint16_t value)
11331133
{
11341134
return esp_matter::attribute::create(cluster, OnOff::Attributes::OnTime::Id,
1135-
ATTRIBUTE_FLAG_WRITABLE | ATTRIBUTE_FLAG_NULLABLE,
1136-
esp_matter_nullable_uint16(value));
1135+
ATTRIBUTE_FLAG_WRITABLE,
1136+
esp_matter_uint16(value));
11371137
}
11381138

1139-
attribute_t *create_off_wait_time(cluster_t *cluster, nullable<uint16_t> value)
1139+
attribute_t *create_off_wait_time(cluster_t *cluster, uint16_t value)
11401140
{
11411141
return esp_matter::attribute::create(cluster, OnOff::Attributes::OffWaitTime::Id,
1142-
ATTRIBUTE_FLAG_WRITABLE | ATTRIBUTE_FLAG_NULLABLE,
1143-
esp_matter_nullable_uint16(value));
1142+
ATTRIBUTE_FLAG_WRITABLE,
1143+
esp_matter_uint16(value));
11441144
}
11451145

11461146
attribute_t *create_start_up_on_off(cluster_t *cluster, nullable<uint8_t> value)

components/esp_matter/esp_matter_attribute.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,8 +320,8 @@ namespace on_off {
320320
namespace attribute {
321321
attribute_t *create_on_off(cluster_t *cluster, bool value);
322322
attribute_t *create_global_scene_control(cluster_t *cluster, bool value);
323-
attribute_t *create_on_time(cluster_t *cluster, nullable<uint16_t> value);
324-
attribute_t *create_off_wait_time(cluster_t *cluster, nullable<uint16_t> value);
323+
attribute_t *create_on_time(cluster_t *cluster, uint16_t value);
324+
attribute_t *create_off_wait_time(cluster_t *cluster, uint16_t value);
325325
attribute_t *create_start_up_on_off(cluster_t *cluster, nullable<uint8_t> value);
326326
} /* attribute */
327327
} /* on_off */

components/esp_matter/esp_matter_feature.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ namespace lighting {
185185

186186
typedef struct config {
187187
bool global_scene_control;
188-
nullable<uint16_t> on_time;
189-
nullable<uint16_t> off_wait_time;
188+
uint16_t on_time;
189+
uint16_t off_wait_time;
190190
nullable<uint8_t> start_up_on_off;
191191
config() : global_scene_control(1), on_time(0), off_wait_time(0), start_up_on_off(0) {}
192192
} config_t;

examples/light/main/idf_component.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ dependencies:
77
esp_bsp_generic:
88
version: "^1.1.0"
99
espressif/esp_lvgl_port:
10-
version: "2.6.0"
10+
version: "2.7.0"

0 commit comments

Comments
 (0)