Merge branch 'ci/matter_tbr_v1_4' into 'release/v1.4'

pytest: Use the Matter Thread Border Router example as the TBR for ESP32-H2's pytest(v1.4)

See merge request app-frameworks/esp-matter!1164

Author: chshu

.gitlab-ci.yml

@@ -60,16 +60,6 @@ variables:
       time rsync -a ~/.espressif/dist/ ${MATTER_CACHE_DIR}/espressif_dist/ || true
     fi
 
-.setup_ot_br: &setup_ot_br
-  - cd ${CI_PROJECT_DIR}
-  - apt-get update
-  - apt-get install -y openssh-client
-  - git clone ${ESP_THREAD_BR_REPO_URL}
-  - cd ${BR_PATH}/examples/basic_thread_border_router
-  - git checkout v1.1
-  - idf.py set-target esp32s3
-  - idf.py build
-
 .setup_ot_rcp: &setup_ot_rcp
   - cd ${IDF_PATH}
   - ./install.sh
@@ -307,16 +297,17 @@ build_esp_matter_examples_pytest_H2_idf_v5_1:
       - "${IDF_PATH}/examples/openthread/ot_rcp/build/bootloader/*.bin"
       - "${IDF_PATH}/examples/openthread/ot_rcp/build/config/sdkconfig.json"
       - "${IDF_PATH}/examples/openthread/ot_rcp/build/flasher_args.json"
-      - "${BR_PATH}/examples/basic_thread_border_router/build/*.bin"
-      - "${BR_PATH}/examples/basic_thread_border_router/build/partition_table/*.bin"
-      - "${BR_PATH}/examples/basic_thread_border_router/build/bootloader/*.bin"
-      - "${BR_PATH}/examples/basic_thread_border_router/build/config/sdkconfig.json"
-      - "${BR_PATH}/examples/basic_thread_border_router/build/flasher_args.json"
     when: always
     expire_in: 4 days
   script:
     - *setup_ot_rcp
-    - *setup_ot_br
+    - cd ${ESP_MATTER_PATH}/examples/thread_border_router
+    - touch main/MatterProjConfig.h
+    # Use different discriminators for TBR and light examples
+    - echo "#define CHIP_DEVICE_CONFIG_USE_TEST_SETUP_DISCRIMINATOR 0xE00" >> main/MatterProjConfig.h
+    - echo "CONFIG_CHIP_PROJECT_CONFIG=\"main/MatterProjConfig.h\"" >> sdkconfig.defaults
+    - cd ${ESP_MATTER_PATH}/examples/light
+    - echo "CONFIG_ENABLE_MEMORY_PROFILING=y" >> sdkconfig.defaults
     - cd ${ESP_MATTER_PATH}
     - pip install -r tools/ci/requirements-build.txt
     - python tools/ci/build_apps.py ./examples --pytest_h2

examples/pytest_esp_matter_light.py

@@ -15,7 +15,8 @@
 
 CURRENT_DIR_LIGHT = str(pathlib.Path(__file__).parent)+'/light'
 CHIP_TOOL_EXE = str(pathlib.Path(__file__).parent)+ '/../connectedhomeip/connectedhomeip/out/host/chip-tool'
-OT_BR_EXAMPLE_PATH = str(pathlib.Path(__file__).parent)+'/../esp-thread-br/examples/basic_thread_border_router'
+OT_BR_EXAMPLE_PATH = str(pathlib.Path(__file__).parent)+'/thread_border_router'
+OT_DATASET_HEXSTR = '0e08000000000001000035060004001fffe00708fdb824be22185de50c0402a0f7f8051020112014020519772011201402051977030d41706f6c6c6f6e54687265616404101fefc90ee1637d47ca75f87ec24f9403000300000f0208201120140205197701022201'
 pytest_build_dir = CURRENT_DIR_LIGHT
 pytest_matter_thread_dir = CURRENT_DIR_LIGHT+'|'+OT_BR_EXAMPLE_PATH
 
@@ -227,7 +228,7 @@ def fixture_Init_interface() -> bool:
 @pytest.mark.esp_matter_dut
 @pytest.mark.parametrize(
     'count, app_path, target, erase_all', [
-        ( 2, pytest_matter_thread_dir, 'esp32h2|esp32s3', 'y|n'),
+        ( 2, pytest_matter_thread_dir, 'esp32h2|esp32s3', 'y|y'),
     ],
     indirect=True,
 )
@@ -240,51 +241,56 @@ def test_matter_commissioning_h2(dut:Tuple[Dut, Dut]) -> None:
     fixture_Init_interface()
     # BLE start advertising
     light.expect(r'chip\[DL\]\: Configuring CHIPoBLE advertising', timeout=20)
-    # flash ot_br
-    ot_br.expect('OpenThread attached to netif', timeout=30)
+    ot_br.expect(r'chip\[DL\]\: Configuring CHIPoBLE advertising', timeout=20)
+    # Start commissioning OTBR
     time.sleep(2)
-    ot_br.write('factoryreset')
-    ot_br.expect('OpenThread attached to netif', timeout=30)
-    time.sleep(2)
-    ot_br.write('log level 3')
-    ot_br.expect('Done', timeout=5)
-    time.sleep(2)
-    # wifi connect -s ChipTEH2 -p chiptest123
-    ot_br.write('wifi connect -s ChipTEH2 -p chiptest123')
-    ot_br.expect('wifi sta is connected successfully', timeout=5)
+    command = CHIP_TOOL_EXE + ' pairing ble-wifi 1 ChipTEH2 chiptest123 20202021 3584'
+    out_str = subprocess.getoutput(command)
+    print(out_str)
+    result = re.findall(r'Run command failure', str(out_str))
+    if len(result) != 0:
+      assert False
+    # Set the active dataset and start Thread network
     time.sleep(2)
-    # start an ot network
-    ot_br.write('ifconfig up')
-    ot_br.expect('netif up', timeout=5)
+    command = CHIP_TOOL_EXE + ' generalcommissioning arm-fail-safe 180 1 1 0'
+    out_str = subprocess.getoutput(command)
+    print(out_str)
+    result = re.findall(r'Run command failure', str(out_str))
+    if len(result) != 0:
+      assert False
     time.sleep(2)
-    ot_br.write('thread start')
-    ot_br.expect('Role detached -> leader', timeout=20)
+    command = CHIP_TOOL_EXE + ' threadborderroutermanagement set-active-dataset-request hex:' + OT_DATASET_HEXSTR + ' 1 1'
+    out_str = subprocess.getoutput(command)
+    print(out_str)
+    result = re.findall(r'Run command failure', str(out_str))
+    if len(result) != 0:
+      assert False
     time.sleep(2)
-   # get dataset
-    ot_br.write('dataset active -x')
-    dataset=ot_br.expect(r'\n(\w{202}\r)', timeout=5)[1].decode()
-    print(dataset)
-    ot_br.expect('Got IPv6 event: Interface "example_netif_sta" address: fdde:ad00:beef:cafe', timeout=30)
-    print("Got unique local ipv6 address")
-    # Start commissioning
+    command = CHIP_TOOL_EXE + ' generalcommissioning commissioning-complete 1 0'
+    out_str = subprocess.getoutput(command)
+    print(out_str)
+    result = re.findall(r'Run command failure', str(out_str))
+    if len(result) != 0:
+      assert False
+    # Start commissioning Light
     time.sleep(2)
-    command = CHIP_TOOL_EXE + " pairing ble-thread 1 hex:{} ".format(dataset.strip())+"20202021 3840"
+    command = CHIP_TOOL_EXE + ' pairing ble-thread 2 hex:' + OT_DATASET_HEXSTR +' 20202021 3840'
     out_str = subprocess.getoutput(command)
     print(out_str)
     result = re.findall(r'Run command failure', str(out_str))
     if len(result) != 0:
       assert False
     # Use toggle command to turn-off the light
     time.sleep(2)
-    command = CHIP_TOOL_EXE + ' onoff toggle 1 1'
+    command = CHIP_TOOL_EXE + ' onoff toggle 2 1'
     out_str = subprocess.getoutput(command)
     print(out_str)
     result = re.findall(r'Run command failure', str(out_str))
     if len(result) != 0:
       assert False
     # Use toggle command to turn-on the light
     time.sleep(2)
-    command = CHIP_TOOL_EXE + ' onoff toggle 1 1'
+    command = CHIP_TOOL_EXE + ' onoff toggle 2 1'
     out_str = subprocess.getoutput(command)
     print(out_str)
     result = re.findall(r'Run command failure', str(out_str))

examples/thread_border_router/main/app_main.cpp

@@ -72,15 +72,11 @@ extern "C" void app_main()
     static chip::KvsPersistentStorageDelegate tbr_storage_delegate;
     chip::DeviceLayer::PersistedStorage::KeyValueStoreManager & kvsManager = chip::DeviceLayer::PersistedStorage::KeyValueStoreMgr();
     tbr_storage_delegate.Init(&kvsManager);
-    GenericOpenThreadBorderRouterDelegate *delegate = chip::Platform::New<GenericOpenThreadBorderRouterDelegate>(&tbr_storage_delegate);
+    static GenericOpenThreadBorderRouterDelegate delegate(&tbr_storage_delegate);
     char threadBRName[] = "Espressif-ThreadBR";
-    delegate->SetThreadBorderRouterName(chip::CharSpan(threadBRName));
-    if (!delegate) {
-        ESP_LOGE(TAG, "Failed to create thread_border_router delegate");
-        return;
-    }
+    delegate.SetThreadBorderRouterName(chip::CharSpan(threadBRName));
     thread_border_router::config_t tbr_config;
-    tbr_config.thread_border_router_management.delegate = delegate;
+    tbr_config.thread_border_router_management.delegate = &delegate;
     endpoint_t *tbr_endpoint = thread_border_router::create(node, &tbr_config, ENDPOINT_FLAG_NONE, NULL);
     if (!node || !tbr_endpoint) {
         ESP_LOGE(TAG, "Failed to create data model");

examples/thread_border_router/sdkconfig.defaults

@@ -56,3 +56,5 @@ CONFIG_USE_MINIMAL_MDNS=n
 # Enable Matter shell
 CONFIG_ENABLE_CHIP_SHELL=y
 CONFIG_ESP_MATTER_CONSOLE_TASK_STACK=4096
+
+CONFIG_AUTO_UPDATE_RCP=y

tools/ci/build_apps.py

@@ -28,6 +28,7 @@
 
 PYTEST_H2_APPS = [
     {"target": "esp32h2", "name": "light"},
+    {"target": "esp32s3", "name": "thread_border_router"},
 ]
 MAINFEST_FILES = [
     str(PROJECT_ROOT / 'examples' / '.build-rules.yml'),