Merge branch 'fix-warnings' into 'main'

components/esp_matter: fix few warnings

See merge request app-frameworks/esp-matter!1188

Author: dhrishi

components/esp_matter/esp_matter_attribute_bounds.cpp

@@ -131,7 +131,6 @@ void add_bounds_cb(cluster_t *cluster)
                 break;
             }
             case LevelControl::Attributes::MinLevel::Id: {
-                esp_matter_attr_val_t max_val = esp_matter_invalid(NULL);
                 uint8_t min = 1, max = 254;
                 esp_matter::attribute::add_bounds(current_attribute, esp_matter_uint8(min), esp_matter_uint8(max));
                 break;

components/esp_matter/esp_matter_command.cpp

@@ -550,17 +550,6 @@ static esp_err_t esp_matter_command_callback_stop_with_on_off(const ConcreteComm
     return ESP_OK;
 }
 
-static esp_err_t esp_matter_command_callback_move_to_closest_frequency(const ConcreteCommandPath &command_path,
-                                                                       TLVReader &tlv_data, void *opaque_ptr)
-{
-    chip::app::Clusters::LevelControl::Commands::MoveToClosestFrequency::DecodableType command_data;
-    CHIP_ERROR error = Decode(tlv_data, command_data);
-    if (error == CHIP_NO_ERROR) {
-        emberAfLevelControlClusterMoveToClosestFrequencyCallback((CommandHandler *)opaque_ptr, command_path, command_data);
-    }
-    return ESP_OK;
-}
-
 static esp_err_t esp_matter_command_callback_move_to_hue(const ConcreteCommandPath &command_path, TLVReader &tlv_data,
                                                          void *opaque_ptr)
 {
@@ -1360,6 +1349,7 @@ static esp_err_t esp_matter_command_callback_disable_action_with_duration(const
     return ESP_OK;
 }
 
+#if CHIP_CONFIG_USE_ACCESS_RESTRICTIONS
 static esp_err_t esp_matter_command_callback_review_fabric_restrictions(const ConcreteCommandPath &command_path, TLVReader &tlv_data, void *opaque_ptr)
 {
     chip::app::Clusters::AccessControl::Commands::ReviewFabricRestrictions::DecodableType command_data;
@@ -1369,16 +1359,7 @@ static esp_err_t esp_matter_command_callback_review_fabric_restrictions(const Co
     }
     return ESP_OK;
 }
-
-static esp_err_t esp_matter_command_callback_keep_active(const ConcreteCommandPath &command_path, TLVReader &tlv_data, void *opaque_ptr)
-{
-    chip::app::Clusters::BridgedDeviceBasicInformation::Commands::KeepActive::DecodableType command_data;
-    CHIP_ERROR error = Decode(tlv_data, command_data);
-    if (error == CHIP_NO_ERROR) {
-        emberAfBridgedDeviceBasicInformationClusterKeepActiveCallback((CommandHandler *)opaque_ptr, command_path, command_data);
-    }
-    return ESP_OK;
-}
+#endif // CHIP_CONFIG_USE_ACCESS_RESTRICTIONS
 
 static esp_err_t esp_matter_command_callback_send_key(const ConcreteCommandPath &command_path, TLVReader &tlv_data, void *opaque_ptr)
 {

components/esp_matter/esp_matter_ota.cpp

@@ -73,9 +73,9 @@ esp_err_t esp_matter_ota_requestor_init(void)
 #endif
 }
 
+#if CONFIG_ENABLE_OTA_REQUESTOR
 static esp_err_t esp_matter_ota_override_impl(const esp_matter_ota_requestor_impl_t *impl)
 {
-#if CONFIG_ENABLE_OTA_REQUESTOR
     VerifyOrReturnError(impl != nullptr, ESP_ERR_INVALID_ARG);
 
     if (impl->driver != nullptr) {
@@ -88,10 +88,8 @@ static esp_err_t esp_matter_ota_override_impl(const esp_matter_ota_requestor_imp
     s_ota_requestor_impl.user_consent = impl->user_consent;
 
     return ESP_OK;
-#else
-    return ESP_ERR_NOT_SUPPORTED;
-#endif // CONFIG_ENABLE_OTA_REQUESTOR
 }
+#endif // CONFIG_ENABLE_OTA_REQUESTOR
 
 void esp_matter_ota_requestor_start(void)
 {

examples/common/utils/log_heap_numbers.h

@@ -1,23 +1,21 @@
 #include <esp_log.h>
 #include <esp_heap_caps.h>
 
+#ifdef CONFIG_ENABLE_MEMORY_PROFILING
 static const char *HEAP_PROFILING_TAG = "heap_profiling";
 
 static void memory_profiler_dump_heap_stat(const char *state)
 {
-#ifdef CONFIG_ENABLE_MEMORY_PROFILING
     ESP_LOGI(HEAP_PROFILING_TAG,"========== HEAP-DUMP-START ==========\n");
     ESP_LOGI(HEAP_PROFILING_TAG,"state: %s\n", state);
     ESP_LOGI(HEAP_PROFILING_TAG,"\tDescription\tInternal\n");
     ESP_LOGI(HEAP_PROFILING_TAG,"Current Free Memory\t%d\n", heap_caps_get_free_size(MALLOC_CAP_8BIT));
     ESP_LOGI(HEAP_PROFILING_TAG,"Largest Free Block\t%d\n", heap_caps_get_largest_free_block(MALLOC_CAP_8BIT | MALLOC_CAP_INTERNAL));
     ESP_LOGI(HEAP_PROFILING_TAG,"Min. Ever Free Size\t%d\n", heap_caps_get_minimum_free_size(MALLOC_CAP_8BIT | MALLOC_CAP_INTERNAL));
     ESP_LOGI(HEAP_PROFILING_TAG,"========== HEAP-DUMP-END ==========\n");
-#endif
 }
 
-#ifdef CONFIG_ENABLE_MEMORY_PROFILING
 #define MEMORY_PROFILER_DUMP_HEAP_STAT(state) memory_profiler_dump_heap_stat(state)
 #else
-#define MEMORY_PROFILER_DUMP_HEAP_STAT(state)
+#define MEMORY_PROFILER_DUMP_HEAP_STAT(state) void(0)
 #endif // CONFIG_ENABLE_MEMORY_PROFILING