Fix: Allocation for connection buffer was incorrectly done.

euripedesrocha · euripedesrocha · commit 6c849c62ef27 · 2023-06-21T08:24:46.000+02:00
By mistake calloc parameters were incorrect.
diff --git a/lib/mqtt_msg.c b/lib/mqtt_msg.c
@@ -619,7 +619,7 @@ int mqtt_has_valid_msg_hdr(uint8_t *buffer, size_t length)
 esp_err_t mqtt_msg_buffer_init(mqtt_connection_t *connection, int buffer_size)
 {
     memset(connection, 0, sizeof(mqtt_connection_t));
-    connection->buffer = (uint8_t *)calloc(0, buffer_size);
+    connection->buffer = (uint8_t *)calloc(buffer_size, sizeof(uint8_t));
     if (!connection->buffer) {
         return ESP_ERR_NO_MEM;
     }

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,7 @@ int mqtt_has_valid_msg_hdr(uint8_t *buffer, size_t length)`
`619`	`619`	`esp_err_t mqtt_msg_buffer_init(mqtt_connection_t *connection, int buffer_size)`
`620`	`620`	`{`
`621`	`621`	`memset(connection, 0, sizeof(mqtt_connection_t));`
`622`		`- connection->buffer = (uint8_t *)calloc(0, buffer_size);`
	`622`	`+ connection->buffer = (uint8_t *)calloc(buffer_size, sizeof(uint8_t));`
`623`	`623`	`if (!connection->buffer) {`
`624`	`624`	`return ESP_ERR_NO_MEM;`
`625`	`625`	`}`