fix(modem): Fix DTE to post fragments to parsers for USB term

david-cermak · david-cermak · commit 1db1e1508d63 · 2023-10-20T11:54:48.000+02:00
diff --git a/components/esp_modem/src/esp_modem_dte.cpp b/components/esp_modem/src/esp_modem_dte.cpp
@@ -78,9 +78,9 @@ void DTE::set_command_callbacks()
             if (command_cb.process_line(data, 0, len)) {
                 return true;
             }
-            // cannot inflate and the processing hasn't finishes in the first iteration -> report a failure
-            command_cb.give_up();
-            return true;
+            // cannot inflate and the processing hasn't finishes in the first iteration, but continue
+            // (will post next fragments to the parser, since we might be just missing a last token or OK
+            return false;
 #endif
         }
         // data == nullptr: Terminals which request users to read current data

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,9 @@ void DTE::set_command_callbacks()`
`78`	`78`	`if (command_cb.process_line(data, 0, len)) {`
`79`	`79`	`return true;`
`80`	`80`	`}`
`81`		`- // cannot inflate and the processing hasn't finishes in the first iteration -> report a failure`
`82`		`- command_cb.give_up();`
`83`		`- return true;`
	`81`	`+ // cannot inflate and the processing hasn't finishes in the first iteration, but continue`
	`82`	`+ // (will post next fragments to the parser, since we might be just missing a last token or OK`
	`83`	`+ return false;`
`84`	`84`	`#endif`
`85`	`85`	`}`
`86`	`86`	`// data == nullptr: Terminals which request users to read current data`