Skip to content

Commit 2005f3f

Browse files
committed
fix(mdns): Forward porting 8ca45f3 delete race
1 parent acd3c13 commit 2005f3f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

components/mdns/mdns_service.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ static void _mdns_service_task(void *pvParameters)
221221
}
222222
}
223223
_mdns_service_task_handle = NULL;
224-
vTaskDelete(NULL);
224+
vTaskDelay(portMAX_DELAY);
225225
}
226226

227227
static void _mdns_timer_cb(void *arg)
@@ -324,16 +324,17 @@ static esp_err_t _mdns_service_task_stop(void)
324324
{
325325
_mdns_stop_timer();
326326
if (_mdns_service_task_handle) {
327+
TaskHandle_t task_handle = _mdns_service_task_handle;
327328
mdns_action_t action;
328329
mdns_action_t *a = &action;
329330
action.type = ACTION_TASK_STOP;
330331
if (xQueueSend(s_action_queue, &a, (TickType_t)0) != pdPASS) {
331-
vTaskDelete(_mdns_service_task_handle);
332332
_mdns_service_task_handle = NULL;
333333
}
334334
while (_mdns_service_task_handle) {
335335
vTaskDelay(10 / portTICK_PERIOD_MS);
336336
}
337+
vTaskDelete(task_handle);
337338
}
338339
vSemaphoreDelete(_mdns_service_semaphore);
339340
_mdns_service_semaphore = NULL;

0 commit comments

Comments
 (0)