fix(websocket): Skip warn on zero timeout and auto reconnect is disabled

johanstokking · johanstokking · commit 5b467cbf5c0f · 2024-03-06T22:20:48.000+01:00
diff --git a/components/esp_websocket_client/esp_websocket_client.c b/components/esp_websocket_client/esp_websocket_client.c
@@ -633,7 +633,7 @@ esp_websocket_client_handle_t esp_websocket_client_init(const esp_websocket_clie
         ESP_WS_CLIENT_MEM_CHECK(TAG, client->config->scheme, goto _websocket_init_fail);
     }
 
-    if (config->reconnect_timeout_ms <= 0) {
+    if (!config->disable_auto_reconnect && config->reconnect_timeout_ms <= 0) {
         client->wait_timeout_ms = WEBSOCKET_RECONNECT_TIMEOUT_MS;
         ESP_LOGW(TAG, "`reconnect_timeout_ms` is not set, or it is less than or equal to zero, using default time out %d (milliseconds)", WEBSOCKET_RECONNECT_TIMEOUT_MS);
     } else {

Original file line number	Diff line number	Diff line change
`@@ -633,7 +633,7 @@ esp_websocket_client_handle_t esp_websocket_client_init(const esp_websocket_clie`
`633`	`633`	`ESP_WS_CLIENT_MEM_CHECK(TAG, client->config->scheme, goto _websocket_init_fail);`
`634`	`634`	`}`
`635`	`635`
`636`		`- if (config->reconnect_timeout_ms <= 0) {`
	`636`	`+ if (!config->disable_auto_reconnect && config->reconnect_timeout_ms <= 0) {`
`637`	`637`	`client->wait_timeout_ms = WEBSOCKET_RECONNECT_TIMEOUT_MS;`
`638`	`638`	ESP_LOGW(TAG, "`reconnect_timeout_ms` is not set, or it is less than or equal to zero, using default time out %d (milliseconds)", WEBSOCKET_RECONNECT_TIMEOUT_MS);
`639`	`639`	`} else {`