Merge pull request #446 from david-cermak/fix/modem_command_state_consistency

david-cermak · web-flow · commit 671190bc6dcf · 2023-12-06T09:06:23.000+01:00
fix(modem): Fixed inconsistent state on data after OK
diff --git a/components/esp_modem/src/esp_modem_dte.cpp b/components/esp_modem/src/esp_modem_dte.cpp
@@ -347,6 +347,9 @@ void DTE::on_read(got_line_cb on_read_cb)
 
 bool DTE::command_cb::process_line(uint8_t *data, size_t consumed, size_t len)
 {
+    if (result != command_result::TIMEOUT) {
+        return false;   // this line has been processed already (got OK or FAIL previously)
+    }
     if (memchr(data + consumed, separator, len)) {
         result = got_line(data, consumed + len);
         if (result == command_result::OK || result == command_result::FAIL) {

Original file line number	Diff line number	Diff line change
`@@ -347,6 +347,9 @@ void DTE::on_read(got_line_cb on_read_cb)`
`347`	`347`
`348`	`348`	`bool DTE::command_cb::process_line(uint8_t *data, size_t consumed, size_t len)`
`349`	`349`	`{`
	`350`	`+ if (result != command_result::TIMEOUT) {`
	`351`	`+ return false; // this line has been processed already (got OK or FAIL previously)`
	`352`	`+ }`
`350`	`353`	`if (memchr(data + consumed, separator, len)) {`
`351`	`354`	`result = got_line(data, consumed + len);`
`352`	`355`	`if (result == command_result::OK \|\| result == command_result::FAIL) {`