fix(mdns): Schedule all queued Tx packets from timer task

david-cermak · david-cermak · commit d4e693e3928e · 2024-03-20T11:47:29.000+01:00
Co-Authored-By: not-my-real-name <none@interent.com> Partially addresses: espressif/esp-idf#13333
diff --git a/components/mdns/mdns.c b/components/mdns/mdns.c
@@ -5191,7 +5191,7 @@ static void _mdns_scheduler_run(void)
         MDNS_SERVICE_UNLOCK();
         return;
     }
-    if ((int32_t)(p->send_at - (xTaskGetTickCount() * portTICK_PERIOD_MS)) < 0) {
+    while (p && (int32_t)(p->send_at - (xTaskGetTickCount() * portTICK_PERIOD_MS)) < 0) {
         action = (mdns_action_t *)malloc(sizeof(mdns_action_t));
         if (action) {
             action->type = ACTION_TX_HANDLE;
@@ -5203,8 +5203,10 @@ static void _mdns_scheduler_run(void)
             }
         } else {
             HOOK_MALLOC_FAILED;
-            // continue
+            break;
         }
+        //Find the next unqued packet
+        p = p->next;
     }
     MDNS_SERVICE_UNLOCK();
 }

Original file line number	Diff line number	Diff line change
`@@ -5191,7 +5191,7 @@ static void _mdns_scheduler_run(void)`
`5191`	`5191`	`MDNS_SERVICE_UNLOCK();`
`5192`	`5192`	`return;`
`5193`	`5193`	`}`
`5194`		`- if ((int32_t)(p->send_at - (xTaskGetTickCount() * portTICK_PERIOD_MS)) < 0) {`
	`5194`	`+ while (p && (int32_t)(p->send_at - (xTaskGetTickCount() * portTICK_PERIOD_MS)) < 0) {`
`5195`	`5195`	`action = (mdns_action_t *)malloc(sizeof(mdns_action_t));`
`5196`	`5196`	`if (action) {`
`5197`	`5197`	`action->type = ACTION_TX_HANDLE;`
`@@ -5203,8 +5203,10 @@ static void _mdns_scheduler_run(void)`
`5203`	`5203`	`}`
`5204`	`5204`	`} else {`
`5205`	`5205`	`HOOK_MALLOC_FAILED;`
`5206`		`- // continue`
	`5206`	`+ break;`
`5207`	`5207`	`}`
	`5208`	`+ //Find the next unqued packet`
	`5209`	`+ p = p->next;`
`5208`	`5210`	`}`
`5209`	`5211`	`MDNS_SERVICE_UNLOCK();`
`5210`	`5212`	`}`