Merge pull request #689 from SoucheSouche/fix/esp-linenoise-static-analyzer-warnings

SoucheSouche · web-flow · commit b76db1d6d1d1 · 2026-02-24T07:34:48.000+01:00
fix(esp_linenoise): update code to fix static analyzer warning
diff --git a/esp_linenoise/idf_component.yml b/esp_linenoise/idf_component.yml
@@ -1,4 +1,4 @@
-version: "1.0.3"
+version: "1.0.4"
 description: "ESP Linenoise - Line editing C library"
 url: https://github.com/espressif/idf-extra-components/tree/master/esp_linenoise
 license: Apache-2.0
diff --git a/esp_linenoise/src/esp_linenoise.c b/esp_linenoise/src/esp_linenoise.c
@@ -1297,8 +1297,10 @@ void esp_linenoise_add_completion(void *ctx, const char *str)
         free(copy);
         return;
     }
+
+    cvec[lc->len] = copy;  // Store copy in new slot before updating struct
     lc->cvec = cvec;
-    lc->cvec[lc->len++] = copy;
+    lc->len++;
 }
 
 esp_err_t esp_linenoise_history_add(esp_linenoise_handle_t handle, const char *line)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-version: "1.0.3"`
	`1`	`+version: "1.0.4"`
`2`	`2`	`description: "ESP Linenoise - Line editing C library"`
`3`	`3`	`url: https://github.com/espressif/idf-extra-components/tree/master/esp_linenoise`
`4`	`4`	`license: Apache-2.0`
Original file line number	Diff line number	Diff line change
`@@ -1297,8 +1297,10 @@ void esp_linenoise_add_completion(void ctx, const char str)`
`1297`	`1297`	`free(copy);`
`1298`	`1298`	`return;`
`1299`	`1299`	`}`
	`1300`	`+`
	`1301`	`+ cvec[lc->len] = copy; // Store copy in new slot before updating struct`
`1300`	`1302`	`lc->cvec = cvec;`
`1301`		`- lc->cvec[lc->len++] = copy;`
	`1303`	`+ lc->len++;`
`1302`	`1304`	`}`
`1303`	`1305`
`1304`	`1306`	`esp_err_t esp_linenoise_history_add(esp_linenoise_handle_t handle, const char *line)`