Skip to content

Conversation

@jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Aug 26, 2025

Description

  • Updated pre-commit hooks, added pre-commit CI
  • Added pre-commit workflow on PR
  • Added the supported_versions.py script that automatically resolves supported versions of ESP-IDF and Python
  • Implemented the script in the reusable workflow (to be possible to use in other projects) and also implemented the reusable workflow in the wheels build workflows - to test this, the reusable workflow get-supported-versions.yml firstly would need to propagate to the main branch
  • Stopped the upload of the wheels for now to prepare for introducing another PR after this to solve all the issues and manywheels builds
  • Updated README to correspond with the changes
  • Added an automatic README updater (script and workflow) to keep the supported Python versions fresh
  • Added packages to the exclude_list.yaml to prevent build failures (no other easy solution has worked)
  • Updated the exclude_list.yaml

Related

  • Closes IDF-13811
  • Closes IDF-11486

Testing

Tested the changes on the workflows, also disabled the update to the Espressif server from this PR until the test is introduced, and we will be sure we can upload it again.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jakub-kocka jakub-kocka self-assigned this Aug 26, 2025
@github-actions
Copy link

github-actions bot commented Aug 26, 2025

Warnings
⚠️ Please consider squashing your 11 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 1742), you might consider splitting it into smaller PRs

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b07320b

@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch from 9c0d9e6 to 913fa35 Compare August 27, 2025 08:01
Copy link
Collaborator

@fhrbata fhrbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Thank you

@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch 2 times, most recently from 9ec0ec2 to 114d99d Compare August 29, 2025 08:51
@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch 9 times, most recently from 6186cc7 to 6be3f1b Compare September 4, 2025 09:08
@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch 7 times, most recently from d46b33a to affad4e Compare September 11, 2025 08:43
@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch from 310298a to a32bfd0 Compare September 12, 2025 07:07
@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch 14 times, most recently from 3969863 to b9ba211 Compare September 18, 2025 12:01
@jakub-kocka jakub-kocka force-pushed the feat/automatic_supported_versions branch from b9ba211 to b07320b Compare September 19, 2025 07:45
@jakub-kocka
Copy link
Collaborator Author

Guys, @peterdragun, @tomassebestik, @fhrbata, can you please take another look?

I have added a couple of changes - described in the description

This should be everything for this PR, making the repo fully autonomous and fixing the issues.
Follow-up will be the manylinux wheels build and probably tests before we turn on automatic upload to Espressif's PyPI again

Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomassebestik tomassebestik merged commit 11bb85b into main Sep 25, 2025
41 checks passed
@jakub-kocka jakub-kocka deleted the feat/automatic_supported_versions branch September 25, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants