Skip to content

Conversation

@jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Oct 8, 2025

Description

The automatic README update workflow had a missing requirement, which produces a failure of this workflow: https://github.com/espressif/idf-python-wheels/actions/runs/18331826139

Related

Automatic PR created: #50

Testing

https://github.com/espressif/idf-python-wheels/actions/runs/18339814576/job/52232392691

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jakub-kocka jakub-kocka self-assigned this Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against cf9280c

@jakub-kocka jakub-kocka marked this pull request as draft October 8, 2025 09:41
@jakub-kocka jakub-kocka requested a review from mfialaf October 8, 2025 12:24
@jakub-kocka jakub-kocka marked this pull request as ready for review October 8, 2025 12:24
Copy link
Collaborator

@mfialaf mfialaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@jakub-kocka
Copy link
Collaborator Author

Thank you for the review. I am merging this since the workflow passed successfully.

@jakub-kocka jakub-kocka merged commit f6205e2 into main Oct 9, 2025
8 checks passed
@jakub-kocka jakub-kocka deleted the fix/wheels_fixtures branch October 9, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants