Skip to content

Commit a7382f1

Browse files
authored
[clang-doc] remove indentation for preformatted text (llvm#166672)
Text that is in between `<pre>` tags is formatted verbatim. Thus, the text that was correctly indented in relation to its depth in HTML was being indented incorrectly when rendered. That resulted in bad looking pages.
1 parent f00d353 commit a7382f1

File tree

4 files changed

+5
-15
lines changed

4 files changed

+5
-15
lines changed

clang-tools-extra/clang-doc/assets/class-template.mustache

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,7 @@
141141
<div>
142142
{{#PublicMembers}}
143143
<div id="{{Name}}" class="delimiter-container">
144-
<pre>
145-
<code class="language-cpp code-clang-doc" >{{Type}} {{Name}}</code>
146-
</pre>
144+
<pre><code class="language-cpp code-clang-doc" >{{Type}} {{Name}}</code></pre>
147145
{{#MemberComments}}
148146
<div>
149147
{{>Comments}}
@@ -160,9 +158,7 @@
160158
<div>
161159
{{#Obj}}
162160
<div id="{{Name}}" class="delimiter-container">
163-
<pre>
164-
<code class="language-cpp code-clang-doc" >{{Type}} {{Name}}</code>
165-
</pre>
161+
<pre><code class="language-cpp code-clang-doc" >{{Type}} {{Name}}</code></pre>
166162
{{#MemberComments}}
167163
<div>
168164
{{>Comments}}

clang-tools-extra/clang-doc/assets/namespace-template.mustache

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@
9292
{{#Records}}
9393
<li id="{{USR}}" style="max-height: 40px;">
9494
<a href="{{DocumentationFileName}}.html">
95-
<pre>
96-
<code class="language-cpp code-clang-doc">class {{Name}}</code>
97-
</pre>
95+
<pre><code class="language-cpp code-clang-doc">class {{Name}}</code></pre>
9896
</a>
9997
</li>
10098
{{/Records}}

clang-tools-extra/test/clang-doc/mustache-index.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ class Foo;
7070
// CHECK-NEXT: <ul class="class-container">
7171
// CHECK-NEXT: <li id="{{[0-9A-F]*}}" style="max-height: 40px;">
7272
// CHECK-NEXT: <a href="_ZTV3Foo.html">
73-
// CHECK-NEXT: <pre>
74-
// CHECK-NEXT: <code class="language-cpp code-clang-doc">class Foo</code>
75-
// CHECK-NEXT: </pre>
73+
// CHECK-NEXT: <pre><code class="language-cpp code-clang-doc">class Foo</code></pre>
7674
// CHECK-NEXT: </a>
7775
// CHECK-NEXT: </li>
7876
// CHECK-NEXT: </ul>

clang-tools-extra/test/clang-doc/mustache-separate-namespace.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ namespace MyNamespace {
99
// CHECK: <ul class="class-container">
1010
// CHECK-NEXT: <li id="{{[0-9A-F]*}}" style="max-height: 40px;">
1111
// CHECK-NEXT: <a href="_ZTVN11MyNamespace3FooE.html">
12-
// CHECK-NEXT: <pre>
13-
// CHECK-NEXT: <code class="language-cpp code-clang-doc">class Foo</code>
14-
// CHECK-NEXT: </pre>
12+
// CHECK-NEXT: <pre><code class="language-cpp code-clang-doc">class Foo</code></pre>
1513
// CHECK-NEXT: </a>
1614
// CHECK-NEXT: </li>
1715
// CHECK-NEXT: </ul>

0 commit comments

Comments
 (0)