[chore][setup]: misleading idf.py not found error (#1642)

The original error message posting `/tools/idf.py` not found,
meanwhile the extension don't search this directory, which is
misleading.

This PR corrects those messages.

---

BTW, I was ought to find out why this extension cannot detect my
esp-idf installed with this
[ArchLinux AUR repo](https://aur.archlinux.org/packages/esp-idf-git).
The repo installs esp-idf to `/opt/esp-idf`, surely there is
`./tools/idf.py` or `./tools/export.sh`.

Even I was sure the
existense of `/opt/esp-idf/tools/idf.py`, the extension still keeps
yelling `/tools/idf.py` not found. Which I don't reproduce on the
master branch. So it's assumed to be fixed and I'll just update your
error message here.

Signed-off-by: 蔡略 <[email protected]>

Author: ClSlaid

src/setup/SetupPanel.ts

@@ -282,9 +282,8 @@ export class SetupPanel {
             });
             SetupPanel.postMessage({
               command: "setEspIdfErrorStatus",
-              errorMsg: `ESP-IDF is installed in ${
-                setupArgs.existingIdfSetups[message.selectedIdfSetup].idfPath
-              }`,
+              errorMsg: `ESP-IDF is installed in ${setupArgs.existingIdfSetups[message.selectedIdfSetup].idfPath
+                }`,
             });
             this.panel.webview.postMessage({
               command: "updateEspIdfToolsStatus",
@@ -325,40 +324,44 @@ export class SetupPanel {
           await commands.executeCommand("esp.component-manager.ui.show");
           break;
         case "canAccessFile":
-          if (message.path) {
-            const pathIdfPy = path.join(message.path, "tools", "idf.py");
-            // Only require read and execute permissions
-            const fileExists = await canAccessFile(pathIdfPy, fs.constants.R_OK | fs.constants.X_OK);
-            if (!fileExists) {
-              this.panel.webview.postMessage({
-                command: "canAccessFileResponse",
-                path: message.path,
-                exists: fileExists,
-              });
-            } else {
-              let versionEspIdf;
-              if (
-                message.currentVersion &&
-                typeof message.currentVersion === "string"
-              ) {
-                versionEspIdf = message.currentVersion;
-              } else {
-                versionEspIdf = await getEspIdfFromCMake(message.path);
-              }
-              // compareVersion returns a negative value if versionEspIdf is less than "5.0"
-              const noWhiteSpaceSupport =
-                compareVersion(versionEspIdf, "5.0") < 0;
-              const hasWhitespace = /\s/.test(message.path);
-              this.panel.webview.postMessage({
-                command: "canAccessFileResponse",
-                path: message.path,
-                exists: fileExists,
-                noWhiteSpaceSupport,
-                hasWhitespace,
-              });
-            }
+          if (!message.path) {
+            break;
+          }
+
+          const pathIdfPy = path.join(message.path, "tools", "idf.py");
+          // Only require read and execute permissions
+          const fileExists = await canAccessFile(pathIdfPy, fs.constants.R_OK | fs.constants.X_OK);
+          if (!fileExists) {
+            this.panel.webview.postMessage({
+              command: "canAccessFileResponse",
+              path: pathIdfPy,
+              exists: fileExists,
+            });
+            break;
           }
+
+          let versionEspIdf: string;
+          if (
+            message.currentVersion &&
+            typeof message.currentVersion === "string"
+          ) {
+            versionEspIdf = message.currentVersion;
+          } else {
+            versionEspIdf = await getEspIdfFromCMake(message.path);
+          }
+          // compareVersion returns a negative value if versionEspIdf is less than "5.0"
+          const noWhiteSpaceSupport =
+            compareVersion(versionEspIdf, "5.0") < 0;
+          const hasWhitespace = /\s/.test(message.path);
+          this.panel.webview.postMessage({
+            command: "canAccessFileResponse",
+            path: pathIdfPy,
+            exists: fileExists,
+            noWhiteSpaceSupport,
+            hasWhitespace,
+          });
           break;
+
         default:
           break;
       }
@@ -425,7 +428,7 @@ export class SetupPanel {
     ) as string;
     const progressLocation =
       notificationMode === idfConf.NotificationMode.All ||
-      notificationMode === idfConf.NotificationMode.Notifications
+        notificationMode === idfConf.NotificationMode.Notifications
         ? ProgressLocation.Notification
         : ProgressLocation.Window;
     return await window.withProgress(
@@ -559,7 +562,7 @@ export class SetupPanel {
     ) as string;
     const progressLocation =
       notificationMode === idfConf.NotificationMode.All ||
-      notificationMode === idfConf.NotificationMode.Notifications
+        notificationMode === idfConf.NotificationMode.Notifications
         ? ProgressLocation.Notification
         : ProgressLocation.Window;
     return await window.withProgress(
@@ -629,7 +632,7 @@ export class SetupPanel {
     ) as string;
     const progressLocation =
       notificationMode === idfConf.NotificationMode.All ||
-      notificationMode === idfConf.NotificationMode.Notifications
+        notificationMode === idfConf.NotificationMode.Notifications
         ? ProgressLocation.Notification
         : ProgressLocation.Window;
     return await window.withProgress(

src/views/setup/main.ts

@@ -276,7 +276,7 @@ window.addEventListener("message", (event) => {
     case "canAccessFileResponse":
       if (!msg.exists) {
         store.setIdfPathError(
-          "The path for ESP-IDF is not valid: /tools/idf.py not found."
+          `The path for ESP-IDF is not valid: ${msg.path} not found.`
         );
       } else if (msg.noWhiteSpaceSupport && msg.hasWhitespace) {
         store.setIdfPathError(

src/views/setup/store.ts

@@ -167,7 +167,7 @@ export const useSetupStore = defineStore("setup", () => {
     if (message.command === "canAccessFileResponse") {
       if (!message.exists) {
         setIdfPathError(
-          "The path for ESP-IDF is not valid: /tools/idf.py not found."
+          `The path for ESP-IDF is not valid: ${message.path} not found.`
         );
       } else {
         setIdfPathError("");