fix: fix zip archive not initialized

regnerisch · regnerisch · commit 9be4fadb4fcd · 2022-07-13T12:44:02.000+02:00
diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "espresso-tutorials/php-epub",
     "type": "library",
     "license": "ISC",
-    "version": "0.2.0",
+    "version": "0.3.0",
     "autoload": {
         "psr-4": {
             "EspressoTutorials\\Epub\\": "src/"
diff --git a/composer.lock b/composer.lock
diff --git a/src/Epub.php b/src/Epub.php
@@ -4,8 +4,6 @@
 
 class Epub
 {
-    protected \ZipArchive $archive;
-
     protected ?Container $container = null;
 
     protected ?Content $content = null;
@@ -41,13 +39,13 @@ public function content(): Content
 
     public function extractTo(string $path): bool
     {
-        $this->archive = new \ZipArchive();
+        $archive = new \ZipArchive();
 
-        if (!$this->archive->open($this->path)) {
+        if (!$archive->open($this->path)) {
             return false;
         }
 
-        if (!$this->archive->extractTo($path)) {
+        if (!$archive->extractTo($path)) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,6 @@`
`4`	`4`
`5`	`5`	`class Epub`
`6`	`6`	`{`
`7`		`- protected \ZipArchive $archive;`
`8`		`-`
`9`	`7`	`protected ?Container $container = null;`
`10`	`8`
`11`	`9`	`protected ?Content $content = null;`
`@@ -41,13 +39,13 @@ public function content(): Content`
`41`	`39`
`42`	`40`	`public function extractTo(string $path): bool`
`43`	`41`	`{`
`44`		`- $this->archive = new \ZipArchive();`
	`42`	`+ $archive = new \ZipArchive();`
`45`	`43`
`46`		`- if (!$this->archive->open($this->path)) {`
	`44`	`+ if (!$archive->open($this->path)) {`
`47`	`45`	`return false;`
`48`	`46`	`}`
`49`	`47`
`50`		`- if (!$this->archive->extractTo($path)) {`
	`48`	`+ if (!$archive->extractTo($path)) {`
`51`	`49`	`return false;`
`52`	`50`	`}`
`53`	`51`