Rotation

[espruino-discuss2]

Posted at 2022-12-07 by Hank

Just out of curiosity, is there a way to rotate the screen 180° and keep it rotated until the watchface is unloaded (e.g. when the loader shall show up)?

I'm tempted to add a feature to my watchface that if it's unlocked you would swipe up to roate the whole screen to show the time to another person and swipe it again to have the normal mode.

[espruino-discuss2]

Posted at 2022-12-07 by @gfwilliams

Yes - you can use g.setRotation(2) (you need to redraw after it).

The screen won't automatically swap back when the next app loads (since it's set up so left-handed users can permanently keep their watch in that state), so you'll need to implement a handler for the Bangle.on('kill', ...) event to call g.setRotation(0) to put it back.

---

Posted at 2022-12-07 by Hank

OK, will look into it, thanks a lot!

---

Posted at 2022-12-07 by Hank

As there is no g.getRotation, how do I determine the current set rotation?

---

Posted at 2022-12-07 by @gfwilliams

I don't think you can - I guess the question is why do you need to? Can't you keep track yourself?

---

Posted at 2022-12-07 by Hank

Yes, I guess I could. I'll let this as is for now. Maybe I'll add a toggle for BJS1 later.
espruino/BangleApps#2369

The screen won't automatically swap back when the next app loads (since it's set up so left-handed users can permanently keep their watch in that state), so you'll need to implement a handler for the Bangle.on('kill', ...) event to call g.setRotation(0) to put it back.

Actually now that I tried it out on the watch I find it better to not reset this when exiting. It's a neat feature to change global orientation quickly :)

---

Posted at 2022-12-07 by Serj

Why i need to 90° convenient rotation:

---

Posted at 2022-12-08 by Hank

@gfwilliams could you do me a favor and revert this whole PR?

Also I'm really wondering why the watchface is still loaded when the launcher is shown. How do I kill my
Bangle.on("drag", e => {
when user presses the button for the launcer?

Not that familiar with git and I'm afraid I would break something. I now discovered the problem that I cannot use the launcher anymore. Did not notice that before. Will work on this eventually but for now I got no time :(
@serj will hopefully consider the 90° then :)

---

Posted at 2022-12-08 by @gfwilliams

Revert this PR? espruino/BangleApps#2369

Also I'm really wondering why the watchface is still loaded when the launcher is shown

You implemented the remove function, but presumably didn't actually manage to remove all of the stuff that the clock loaded in it? https://github.com/pebl-hank/BangleApps/blob/383f18f92facbf8a4ea44bad2f8ea9ce0f763f6a/apps/hworldclock/app.js#L305-L313

There's info on implementing/testing here: http://www.espruino.com/Bangle.js+Fast+Load

Specifically handling stuff like drag is covered here: http://www.espruino.com/Bangle.js+Fast+Load#event-handlers

Although really for drag you should be using setUI({mode:"custom",clock:true,drag:...})

Best bet is just to not have the remove function for now, and then the clock will unload 'normally' and will get rid of all the changes.

---

Posted at 2022-12-08 by Hank

Revert this PR? https://github.com/espruino/BangleApps/p­ull/2369

Yes, please!

---

Posted at 2022-12-08 by Hank

PS: I will do the revert. Never mind. Sorry for any inconvenience.
espruino/BangleApps#2374

---

Posted at 2022-12-11 by Hank

I attached my current code.

Current log shows:

Uncaught ReferenceError: "onDrag" is not defined
 at line 1 col 285
...ngle.removeListener('drag',onDrag);Bangle.removeListener('on...
                              ^
in function "a" called from line 2 col 168
...e;delete Bangle.uiRemove;a()}g.reset();if(c){if("updown"==c)...
                              ^
in function called from line 1 col 31
Bangle.uiRemove?(Bangle.setUI(),(__FILE__=a)||(a=".bootcde")...
                              ^
at line 1 col 115
..."Storage").read(a))):load(a)
                              ^
in function called from line 1 col 408
...))}c?Bangle.load(b.launcher):eval('E.showMessage("No Launche...
                              ^
at line 1 col 525
...at:false,edge:"falling"});');
                              ^
in function called from system

How do I resolve this?

However, development is very difficult for me as I do not understand certain things. E.g. when I want to check the interaction between the watchface and the loader, the easiest would be to just upload my watchface to the storage. But when I do that via IDE, I get strange errors from the watchface that I don't get when it is uploaded to RAM:

Uncaught Error: Module Font5x9Numeric7Seg not found
 at line 15 col 29 in hworldclock.app.js
require("Font5x9Numeric7Seg").add(Graphics);
                            ^

---

Attachments:

• app.js

---

Posted at 2022-12-11 by @thyttan

Regarding "onDrag" is not defined:

Without diving deep into the code, I suspect you can solve the issue by wrapping Bangle.removeListener('drag',onDrag) in an if (onDrag) { ... } or if (onDrag!==undefined) { ... }. So that if onDrag isn't defined anymore for some reason it will not try to remove it.

Regarding Module Font5x9Numeric7Seg not found:

I think I remember require()ed fonts are inserted at the top of the app.js file on upload from the app loader, much like modules. I think you could look at the app.js file (via Web IDE) after you installed it via the app loader and see that code prepended. Then you could copy that code into your app code to be able to run it from the Web IDE without going via the app loader (again, I think).

---

Posted at 2022-12-12 by Hank

I now changed it to

Bangle.setUI({
  mode : "custom",clock:true,
  remove : function() {
    // Called to unload all of the clock app
	if (typeof PosInterval === "undefined") {
		console.log("PosInterval is undefined")
	} else {
		if (PosInterval) clearInterval(PosInterval);
	}	
    PosInterval = undefined;
    if (drawTimeoutSeconds) clearTimeout(drawTimeoutSeconds);
    drawTimeoutSeconds = undefined;
    if (drawTimeout) clearTimeout(drawTimeout);
    drawTimeout = undefined;	
	if (typeof onDrag !== "undefined") Bangle.removeListener('drag',onDrag);
	if (typeof onLock !== "undefined") Bangle.removeListener('onLock',onLock);
  }});

Now, the loader shows up, but the Listener seems to be still in place.

---

Posted at 2022-12-12 by @thyttan

There shouldn't be quotation marks around undefined.

Try:
if (typeof onDrag !== undefined) Bangle.removeListener('drag',onDrag);

---

Posted at 2022-12-12 by Hank

Then I actually get

 build: apps/hworldclock/app.js#L317
Invalid typeof comparison value

---

Posted at 2022-12-12 by @thyttan

Searching the repository it seems to me that that logic works for other apps: https://github.com/espruino/BangleApps/search?q=%21%3D%3Dundefined

Does it work if you use != instead of !==?

EDIT: Wait, drop the typeof like so:

if (onDrag !== undefined) Bangle.removeListener('drag',onDrag);

---

Posted at 2022-12-12 by Hank

    if (onDrag !== undefined) Bangle.removeListener('drag',onDrag);

gives me

Uncaught ReferenceError: "onDrag" is not defined
 at line 12 col 770 in hworldclock.app.js
...ut);drawTimeout=undefined;if(onDrag!==undefined)Bangle.removeListener('drag',on...
                                                 ^

---

Posted at 2022-12-12 by @thyttan

Ok, try initiating onDrag outside of initDragEvents() like so:

//......

let onDrag; // Initiate onDrag here. If you want to you could move the logic here as well but it shouldn't be neccesary, I think.

function initDragEvents() {
	
if (BANGLEJS2) { 	
	//Bangle.on("drag", e => {
	onDrag = e => {  // Add logic to onDrag here as before. Notice I dropped the "let" on this line.
            //......

---

Posted at 2022-12-12 by Hank

I actually removed the function as it was obsolete anyway - with the same result.
See attached file.

Thanks for your patience!

---

Attachments:

• app.js

---

Posted at 2022-12-12 by @thyttan

Ok, and now it works? 👍

---

Posted at 2022-12-12 by Hank

No, it doesn't. I get no error with the attached code. But the Listener isn't deleted. So it's basically the same as with the first try. I can load the watchface but when the launcher is called, the rotation is still happening on swipe...

---

Posted at 2022-12-12 by @thyttan

And if you go back to not using the if-statement now and just do as you did first like so:

Bangle.removeListener('drag',onDrag);

?

---

Posted at 2022-12-12 by Hank

Then I get

Uncaught ReferenceError: "onDrag" is not defined
 at line 12 col 802 in hworldclock.app.js
...ngle.removeListener('drag',onDrag);Bangle.removeListener('on...
                              ^

---

Posted at 2022-12-12 by @thyttan

hmm, try initiating onDrag above the Bangle.setUI( ... )-block maybe?

---

Posted at 2022-12-12 by Hank

Same result. I tried out to put the whole Bangle.setUI({ block underneath.

---

Posted at 2022-12-12 by @thyttan

Well, I don't think I have any more suggestions then sadly :/ :p

---

Posted at 2022-12-12 by Hank

YAY, now it worked.

That is soooo strange!
I have the

const BANGLEJS2 = process.env.HWVERSION == 2;

at the top of my code.

console.log BANGLEJS2;

shows "true".
But the following "if (BANGLEJS2) { " is not entered! No clue what happens there.

When I remove the check fpr BJS2, it works.

Another problem is that I get

Uncaught Clock has no widgets, can't fast load

When leaving the launcher despite i do load and show widgets at the end of my code.

---

Posted at 2022-12-12 by @halemmerich

You have your BANGLEJS2 constant defined in the big scope for cleanup and the handler is run in the global context. The variable does not exist there and is undefined so the check never triggers. To solve that either move the declaration out of the block and later delete global.BANGLEJS2 in the remove method or access process.env.HWVERSION for every check instead of storing the result in a constant. Same applies to stuff running in timeouts and intervals.

For the "has no widgets" message, maybe you need to update the clockHasWidgets value stored in the settings file? It was possibly set at a time where your clock did not yet have loadWidgets. You can update that by just setting the clock again in the settings app.

---

Posted at 2022-12-12 by Hank

I actually also tried to check for

process.env.HWVERSION == 2

and it didn't work.

Got it with the settings. It seemed to be necessary to assign the default clock again in the settings. Thank you all for those many hints!

---

Posted at 2022-12-12 by @halemmerich

setting.json is the file I meant, it caches if the last set clock had widgets at that time. Rewriting the settings currently just recreates the .boot0 file, that would not help in this case.
Just go into the settings app
-> System
-> Select Clock
-> Select your clock, even if already selected

That will recheck if the clock has a loadWidgets call and update the cached value accordingly. You can check the value by opening setting.json in the IDE before and after.

---

Posted at 2022-12-13 by Hank

@serj i was thinking of a config setting that allows you to set the rotation level to 180(default), disabled, 90 and 270.
That way you can swipe from 0 to the configured value and back.
Would that fit your use case?

---

Posted at 2022-12-13 by Serj

I think yes, thanks 👍

Is it possible to combine rotation with pattern through this application? https://banglejs.com/apps/?id=ptlaunch
So that any swipe can be assigned to a rotation?

---

Posted at 2022-12-13 by @gfwilliams

You can't do it for every app (at least not easily) because we don't have a standard way of redrawing the screen defined - once the screen is rotated we need to ask the app to redraw, and there's no way of doing that at the moment

---

Posted at 2022-12-15 by Fteacher

I'm glad you added the option to switch off the rotation in the settings, the display was never in the correct position for me to watch it. Still, I used the settings to put rotation on "off", but it actually works anyway :/.

---

Posted at 2022-12-16 by Hank

Currently the rotation is set back to 0° when set to "off". I will not touch rotation settings when set to "off" from the next version on.
Maybe I'll also distinguish 0° and off eventually; not sure yet.