Quick question about adding new icons

[espruino-discuss2]

Posted at 2024-08-27 by Pologram

Hello,

I would like to add new icons for Gmail and Google Messages (SMS) in the "Message Icons" app.

I am unsure about what the naming rule for the PNGs is.

gmail or google mail? messages or google messages?

Thanks for your help

[espruino-discuss2]

Posted at 2024-08-27 by @gfwilliams

Hi, that would be great! The best way to figure out naming would be to enable logging in Gadgetbridge, and then you can dump the log and see what name Android gives to the relevant apps (as that's what Bangle.js will have to use when figuring out what image to use)

---

Posted at 2024-08-27 by Pologram

Thanks Gordon!

I tried adding the new icons, ran generate.js, and tried updating the messageicons app from my personal app loader, but the resulting icon is completely white, both for Gmail and Messages.

I'm not sure about what I did wrong.
Here is my commit: espruino/BangleApps@master...paul-arg:BangleApps:messageicons
Here is the app loader: https://paul-arg.github.io/BangleApps/

Any help would be appreciated

---

Posted at 2024-08-28 by @gfwilliams

It all looks ok to me... Do other icons still appear ok, it's just your new one?

---

Posted at 2024-08-28 by Pologram

Other icons are all OK, just the two new ones are like this.

---

Posted at 2024-08-28 by Pologram

It looks like something went wrong in the generate.js script for my two PNGs because when I do require("Storage").read("messageicons.img", 20*76, 76) I get \x18\x18\x81 and then a bunch of \0\0\0. Basically there is no data for the two icons I added.

Maybe something is wrong with the PNG files, but I didn't get any warning/error when running the script.

---

Posted at 2024-08-28 by Pologram

I managed to insert the bits of missing data into messageicons.img. It was a bit of a hassle but everything is good now.

It might be nice to look into why the generation script failed for the future.

---

Attachments:

• screenshot_20240828-095014.bmp

---

Posted at 2024-08-29 by @gfwilliams

Did you commit the latest image file? Because I just ran the generate script on your branch at https://github.com/paul-arg/BangleApps/tree/messageicons and it appears to produce the exact same file for me here, so I think we're good.

Not sure why it'd have generated differently in your case though?

---

Posted at 2024-08-30 by Pologram

Yes I did. Looks like we're good indeed.
Thanks!

---

Posted at 2024-09-04 by @gfwilliams

Just for anyone else, if you need to test you can run some code like:

g.clear();
for (var i=0;i<72;i++) g.drawImage(require("Storage").read("messageicons.img",i*76,76),(i%7)*24,Math.floor(i/7)*24)

And it'll dump all the icons to the screen so you can see if they're ok (although right now there are too many to fit on one screen!)