Native UI: Set Label to not selectable by default

AmmarAbouZor · AmmarAbouZor · commit 3e2f71d96b0a · 2026-02-10T15:36:20.000+01:00
* Labels should be not selectable by default making selecting a text an
  explicit opt-in configuration.
* Change current labels removing code noise and applying selecting where
  it's needed
diff --git a/application/apps/indexer/gui/application/src/common/modal.rs b/application/apps/indexer/gui/application/src/common/modal.rs
@@ -1,5 +1,5 @@
 use egui::{
-    Button, Context, Frame, Id, Label, ModalResponse, NumExt as _, Spinner, Ui, Widget as _, vec2,
+    Button, Context, Frame, Id, ModalResponse, NumExt as _, Spinner, Ui, Widget as _, vec2,
 };
 
 /// Show standard modal dialog filled with the provided content.
@@ -31,7 +31,7 @@ where
     show_modal(ctx, "busy indicator", 200.0, |ui| {
         ui.vertical_centered(|ui| {
             if let Some(label) = label {
-                Label::new(label).selectable(false).ui(ui);
+                ui.label(label);
                 ui.add_space(5.);
             }
             Spinner::new().size(25.).ui(ui);
diff --git a/application/apps/indexer/gui/application/src/host/common/app_style.rs b/application/apps/indexer/gui/application/src/host/common/app_style.rs
@@ -0,0 +1,7 @@
+use egui::Style;
+
+/// Applies global style settings to the provided `style` object.
+pub fn global_styles(style: &mut Style) {
+    // We expect the labels to be not selectable by default.
+    style.interaction.selectable_labels = false;
+}
diff --git a/application/apps/indexer/gui/application/src/host/common/mod.rs b/application/apps/indexer/gui/application/src/host/common/mod.rs
@@ -1,3 +1,4 @@
+pub mod app_style;
 pub mod colors;
 pub mod dlt_stats;
 pub mod file_utls;
diff --git a/application/apps/indexer/gui/application/src/host/ui/mod.rs b/application/apps/indexer/gui/application/src/host/ui/mod.rs
@@ -2,7 +2,7 @@ use std::time::Duration;
 
 use anyhow::ensure;
 use eframe::NativeOptions;
-use egui::{Align, CentralPanel, Context, Frame, Layout, TopBottomPanel, Ui, Widget, vec2};
+use egui::{Align, CentralPanel, Context, Frame, Layout, TopBottomPanel, Ui, vec2};
 use itertools::Itertools;
 use log::{info, trace, warn};
 
@@ -11,6 +11,7 @@ use crate::{
     common::{modal::show_modal, phosphor},
     host::{
         command::{HostCommand, StartSessionParam},
+        common::app_style,
         communication::{UiReceivers, UiSenders},
         message::HostMessage,
         service::HostService,
@@ -80,6 +81,8 @@ impl Host {
                     ui_actions: UiActions::new(tokio_handle),
                 };
 
+                ctx.egui_ctx.all_styles_mut(app_style::global_styles);
+
                 host.handle_cli(cli_cmds)?;
 
                 Ok(Box::new(host))
@@ -262,12 +265,10 @@ impl Host {
 
                 ui.add_space(6.);
 
-                egui::Label::new(
+                ui.label(
                     "A file picker is currently open.\
                     If you don't see it, please check your taskbar or move this window",
-                )
-                .selectable(false)
-                .ui(ui);
+                );
             })
         });
     }
diff --git a/application/apps/indexer/gui/application/src/host/ui/multi_setup/main_table/mod.rs b/application/apps/indexer/gui/application/src/host/ui/multi_setup/main_table/mod.rs
@@ -10,9 +10,7 @@ mod table_columns;
 
 pub fn render_content(ui: &mut Ui, state: &mut MultiFileState) {
     main_panel_group_frame(ui).show(ui, |ui| {
-        Label::new(RichText::new("Multiple files").heading())
-            .selectable(false)
-            .ui(ui);
+        ui.label(RichText::new("Multiple files").heading());
 
         ui.add_space(10.);
 
@@ -73,11 +71,9 @@ fn render_table(ui: &mut Ui, state: &mut MultiFileState) {
 }
 
 fn table_header(ui: &mut Ui, column: TableColumn) {
-    Label::new(RichText::new(column.header()).strong())
-        .selectable(false)
-        .ui(ui);
+    ui.label(RichText::new(column.header()).strong());
 }
 
 fn table_cell_text(ui: &mut Ui, content: String) {
-    Label::new(content).selectable(false).truncate().ui(ui);
+    Label::new(content).truncate().ui(ui);
 }
diff --git a/application/apps/indexer/gui/application/src/host/ui/multi_setup/side_panel.rs b/application/apps/indexer/gui/application/src/host/ui/multi_setup/side_panel.rs
@@ -37,9 +37,7 @@ impl MultiSidePanel {
     }
 
     fn render_summary(ui: &mut Ui, state: &mut MultiFileState) {
-        Label::new(RichText::new("Summary").heading())
-            .selectable(false)
-            .ui(ui);
+        ui.label(RichText::new("Summary").heading());
 
         ui.add_space(6.);
 
@@ -55,9 +53,7 @@ impl MultiSidePanel {
     }
 
     fn render_overview(&mut self, ui: &mut Ui, state: &mut MultiFileState) {
-        Label::new(RichText::new("Concat Overview").heading())
-            .selectable(false)
-            .ui(ui);
+        ui.label(RichText::new("Concat Overview").heading());
         ui.add_space(6.);
 
         // ------------------------------
diff --git a/application/apps/indexer/gui/application/src/host/ui/notification.rs b/application/apps/indexer/gui/application/src/host/ui/notification.rs
@@ -257,7 +257,9 @@ impl NotificationUi {
                 ui.add_space(8.);
 
                 ScrollArea::vertical().max_height(12.).show(ui, |ui| {
-                    let msg_lbl = Label::new(notification_msg).wrap_mode(egui::TextWrapMode::Wrap);
+                    let msg_lbl = Label::new(notification_msg)
+                        .selectable(true)
+                        .wrap_mode(egui::TextWrapMode::Wrap);
                     ui.add(msg_lbl);
                 });
             })
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/mod.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/mod.rs
@@ -91,7 +91,7 @@ fn render_socket_address<C: ConfigBindAddress>(config: &mut C, ui: &mut Ui) -> R
     let mut outcome = RenderOutcome::None;
 
     ui.vertical(|ui| {
-        Label::new("Socket Address:").selectable(false).ui(ui);
+        ui.label("Socket Address:");
 
         let ip_txt_res = TextEdit::singleline(config.bind_addr())
             .vertical_align(Align::Center)
@@ -113,7 +113,7 @@ fn render_socket_address<C: ConfigBindAddress>(config: &mut C, ui: &mut Ui) -> R
                     .size(10.5)
                     .small()
                     .color(ui.style().visuals.warn_fg_color);
-                Label::new(err_txt).selectable(false).ui(ui);
+                Label::new(err_txt).selectable(true).ui(ui);
             }
         });
     });
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/process.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/process.rs
@@ -95,8 +95,8 @@ fn working_dir(config: &mut ProcessConfig, actions: &mut UiActions, ui: &mut Ui)
     egui::Sides::new().show(
         ui,
         |ui| {
-            Label::new("Working Folder:").selectable(false).ui(ui);
-            Label::new(path_txt).ui(ui);
+            ui.label("Working Folder:");
+            Label::new(path_txt).selectable(true).ui(ui);
         },
         |ui| {
             let btn_size = vec2(12., height);
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/serial.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/serial.rs
@@ -1,6 +1,6 @@
 use egui::{
-    Align, Button, ComboBox, Frame, Label, Layout, Margin, Popup, RectAlign, RichText, TextEdit,
-    Ui, Widget, vec2,
+    Align, Button, ComboBox, Frame, Layout, Margin, Popup, RectAlign, RichText, TextEdit, Ui,
+    Widget, vec2,
 };
 
 use crate::host::ui::session_setup::{
@@ -27,9 +27,7 @@ pub fn render_connection(config: &mut SerialConfig, ui: &mut Ui) -> RenderOutcom
     );
 
     ui.separator();
-    Label::new(RichText::new("Settings").heading().size(15.))
-        .selectable(false)
-        .ui(ui);
+    ui.label(RichText::new("Settings").heading().size(15.));
 
     ui.horizontal_wrapped(|ui| {
         ui.style_mut().spacing.combo_width = CONTROL_WIDTH;
@@ -201,7 +199,7 @@ fn labeled_field(ui: &mut Ui, label: &str, add_widget: impl FnOnce(&mut Ui)) {
             Frame::NONE
                 .inner_margin(Margin::symmetric(CONTROL_GROUP_SIDE_MARGIN, 0))
                 .show(ui, |ui| {
-                    Label::new(label).selectable(false).ui(ui);
+                    ui.label(label);
                     add_widget(ui);
                 });
         },
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/udp.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/main_config/udp.rs
@@ -113,7 +113,7 @@ fn label_input_field(
     ui.allocate_ui_with_layout(vec2(200., 70.), Layout::top_down(Align::LEFT), |ui| {
         ui.style_mut().spacing.item_spacing.y += 2.;
 
-        Label::new(label).selectable(false).ui(ui);
+        ui.label(label);
 
         let input_res = TextEdit::singleline(value).hint_text(hint_text).ui(ui);
 
@@ -123,7 +123,7 @@ fn label_input_field(
                 .size(11.)
                 .color(ui.visuals().warn_fg_color);
 
-            ui.label(txt);
+            Label::new(txt).selectable(true).ui(ui);
         }
 
         ui.allocate_space(ui.available_size());
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/mod.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/mod.rs
@@ -124,24 +124,26 @@ impl SessionSetup {
             self.state.update_parser(selected_parser);
         }
 
-        Label::new("Used Parser:").selectable(false).ui(ui);
+        ui.label("Used Parser:");
 
         ui.add_space(10.);
 
         match &mut self.state.source {
             ByteSourceConfig::File(source_file_info) => {
                 if let Some(size) = &source_file_info.size_byte {
-                    Label::new(format!("({})", file_utls::format_file_size(*size))).ui(ui);
+                    Label::new(format!("({})", file_utls::format_file_size(*size)))
+                        .selectable(true)
+                        .ui(ui);
                 }
-                Label::new(RichText::new(source_file_info.name.as_str()).strong()).ui(ui);
+                Label::new(RichText::new(source_file_info.name.as_str()).strong())
+                    .selectable(true)
+                    .ui(ui);
             }
             ByteSourceConfig::Concat(files) => {
                 let size = files.iter().filter_map(|f| f.size_byte).sum();
                 Label::new(format!("({})", file_utls::format_file_size(size))).ui(ui);
 
-                Label::new(RichText::new(format!("{} files", files.len())).strong())
-                    .selectable(false)
-                    .ui(ui)
+                ui.label(RichText::new(format!("{} files", files.len())).strong())
                     .on_hover_ui(|ui| {
                         files.iter().enumerate().for_each(|(idx, f)| {
                             if idx != 0 {
@@ -150,7 +152,7 @@ impl SessionSetup {
                             Label::new(format!("{}", f.path.display())).ui(ui);
                         });
                     });
-                Label::new("Concating:").selectable(false).ui(ui);
+                ui.label("Concating:");
             }
             ByteSourceConfig::Stream(stream_config) => {
                 let mut selected_stream = StreamNames::from(stream_config.deref());
@@ -173,7 +175,7 @@ impl SessionSetup {
                     self.state.update_stream(selected_stream);
                 }
 
-                Label::new("Stream From:").selectable(false).ui(ui);
+                ui.label("Stream From:");
             }
         }
     }
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/side_config/mod.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/side_config/mod.rs
@@ -1,4 +1,4 @@
-use egui::{Color32, Label, RichText, Ui, Widget};
+use egui::{Color32, RichText, Ui};
 
 use crate::host::{
     common::{parsers::ParserNames, ui_utls::side_panel_group_frame},
@@ -50,7 +50,7 @@ fn validation_errors(state: &SessionSetupState, ui: &mut Ui) {
             } else {
                 Color32::DARK_RED
             });
-            Label::new(txt).selectable(false).ui(ui);
+            ui.label(txt);
         }
     });
 }
diff --git a/application/apps/indexer/gui/application/src/host/ui/session_setup/side_config/text.rs b/application/apps/indexer/gui/application/src/host/ui/session_setup/side_config/text.rs
@@ -1,9 +1,7 @@
-use egui::{Label, Ui, Widget};
+use egui::Ui;
 
 pub fn render_content(ui: &mut Ui) {
     ui.vertical(|ui| {
-        Label::new("This parser doesn't require any kind of of configuration")
-            .selectable(false)
-            .ui(ui);
+        ui.label("This parser doesn't require any kind of of configuration");
     });
 }
diff --git a/application/apps/indexer/gui/application/src/session/ui/bottom_panel/chart/mod.rs b/application/apps/indexer/gui/application/src/session/ui/bottom_panel/chart/mod.rs
@@ -340,7 +340,6 @@ impl ChartUI {
                 the chart will be rendered.",
                 )
                 .halign(egui::Align::Min)
-                .selectable(false)
                 .ui(ui);
             },
         );
diff --git a/application/apps/indexer/gui/application/src/session/ui/bottom_panel/details/mod.rs b/application/apps/indexer/gui/application/src/session/ui/bottom_panel/details/mod.rs
@@ -14,12 +14,12 @@ impl DetailsUI {
         ui.add_space(10.);
 
         Label::new(format!("Row #: {}", log.pos))
-            .selectable(false)
+            .selectable(true)
             .ui(ui);
 
         ui.add_space(10.);
 
         let content = RichText::new(&log.content).strong();
-        Label::new(content).ui(ui);
+        Label::new(content).selectable(true).ui(ui);
     }
 }
diff --git a/application/apps/indexer/gui/application/src/session/ui/bottom_panel/search/search_bar.rs b/application/apps/indexer/gui/application/src/session/ui/bottom_panel/search/search_bar.rs
@@ -1,8 +1,8 @@
 use tokio::sync::mpsc::Sender;
 
 use egui::{
-    Align, Button, Frame, Id, Key, Label, Layout, Margin, Modifiers, RichText, Stroke, TextEdit,
-    Ui, Widget, vec2,
+    Align, Button, Frame, Id, Key, Layout, Margin, Modifiers, RichText, Stroke, TextEdit, Ui,
+    Widget, vec2,
 };
 use processor::search::filter::SearchFilter;
 use uuid::Uuid;
@@ -226,7 +226,7 @@ impl SearchBar {
                 shared.search.total_count(),
                 logs_count,
             );
-            Label::new(state_txt).selectable(false).ui(ui);
+            ui.label(state_txt);
 
             if shared
                 .search
diff --git a/application/apps/indexer/gui/application/src/session/ui/bottom_panel/search/search_table.rs b/application/apps/indexer/gui/application/src/session/ui/bottom_panel/search/search_table.rs
@@ -252,6 +252,9 @@ impl TableDelegate for LogsDelegate<'_> {
     }
 
     fn cell_ui(&mut self, ui: &mut Ui, cell: &CellInfo) {
+        // Users should be able to select the content of log files.
+        ui.style_mut().interaction.selectable_labels = true;
+
         let &CellInfo { col_nr, row_nr, .. } = cell;
 
         Frame::NONE
diff --git a/application/apps/indexer/gui/application/src/session/ui/logs_table/mod.rs b/application/apps/indexer/gui/application/src/session/ui/logs_table/mod.rs
@@ -251,6 +251,9 @@ impl TableDelegate for LogsDelegate<'_> {
     }
 
     fn cell_ui(&mut self, ui: &mut egui::Ui, cell: &egui_table::CellInfo) {
+        // Users should be able to select the content of log files.
+        ui.style_mut().interaction.selectable_labels = true;
+
         let &CellInfo { col_nr, row_nr, .. } = cell;
 
         Frame::NONE
diff --git a/application/apps/indexer/gui/application/src/session/ui/status_bar.rs b/application/apps/indexer/gui/application/src/session/ui/status_bar.rs
@@ -8,11 +8,13 @@ use crate::{common::phosphor::icons, session::ui::shared::SessionShared};
 
 pub fn render_content(shared: &SessionShared, ui: &mut Ui) {
     ui.horizontal_centered(|ui| {
-        ui.label(format!(
+        Label::new(format!(
             "{} / {}",
             shared.search.total_count(),
             shared.logs.logs_count
-        ));
+        ))
+        .selectable(true)
+        .ui(ui);
 
         ui.with_layout(Layout::right_to_left(Align::Center), |ui| {
             observe_states(shared, ui);
@@ -72,14 +74,14 @@ fn observe_states(shared: &SessionShared, ui: &mut Ui) {
                     };
 
                     let title = RichText::new(title).heading().size(15.0);
-                    Label::new(title).selectable(false).ui(ui);
+                    ui.label(title);
 
                     ui.horizontal_centered(|ui| {
                         if let Some(duratio) = operation.total_run_duration() {
                             let duration_txt = format!("[{:.2}s]", duratio.as_secs_f32());
-                            Label::new(duration_txt).selectable(false).ui(ui);
+                            ui.label(duration_txt);
                         }
-                        Label::new(desc).selectable(false).ui(ui);
+                        ui.label(desc);
                     });
                 }
             });
@@ -105,7 +107,7 @@ fn observe_states(shared: &SessionShared, ui: &mut Ui) {
             },
         };
 
-        Label::new(name).selectable(false).truncate().ui(ui);
+        Label::new(name).truncate().ui(ui);
 
         let (res, painter) = ui.allocate_painter(Vec2::splat(9.0), Sense::empty());
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+pub mod app_style;`
`1`	`2`	`pub mod colors;`
`2`	`3`	`pub mod dlt_stats;`
`3`	`4`	`pub mod file_utls;`
Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,7 @@ mod table_columns;`
`10`	`10`
`11`	`11`	`pub fn render_content(ui: &mut Ui, state: &mut MultiFileState) {`
`12`	`12`	`main_panel_group_frame(ui).show(ui, \|ui\| {`
`13`		`- Label::new(RichText::new("Multiple files").heading())`
`14`		`- .selectable(false)`
`15`		`- .ui(ui);`
	`13`	`+ ui.label(RichText::new("Multiple files").heading());`
`16`	`14`
`17`	`15`	`ui.add_space(10.);`
`18`	`16`
`@@ -73,11 +71,9 @@ fn render_table(ui: &mut Ui, state: &mut MultiFileState) {`
`73`	`71`	`}`
`74`	`72`
`75`	`73`	`fn table_header(ui: &mut Ui, column: TableColumn) {`
`76`		`- Label::new(RichText::new(column.header()).strong())`
`77`		`- .selectable(false)`
`78`		`- .ui(ui);`
	`74`	`+ ui.label(RichText::new(column.header()).strong());`
`79`	`75`	`}`
`80`	`76`
`81`	`77`	`fn table_cell_text(ui: &mut Ui, content: String) {`
`82`		`- Label::new(content).selectable(false).truncate().ui(ui);`
	`78`	`+ Label::new(content).truncate().ui(ui);`
`83`	`79`	`}`