Destroy Attributes's handle before its parent_link (#662)

FlyingSamson · web-flow · commit 2a858258b96c · 2024-12-12T17:14:56.000+01:00
diff --git a/src/h5cpp/attribute/attribute.cpp b/src/h5cpp/attribute/attribute.cpp
@@ -34,8 +34,8 @@ namespace hdf5 {
 namespace attribute {
 
 Attribute::Attribute(ObjectHandle &&handle,const node::Link &parent_link):
-    handle_(std::move(handle)),
-    parent_link_(parent_link)
+    parent_link_(parent_link),
+    handle_(std::move(handle))
 {
 }
 
diff --git a/src/h5cpp/attribute/attribute.hpp b/src/h5cpp/attribute/attribute.hpp
@@ -203,8 +203,8 @@ class DLL_EXPORT Attribute
     void read(T &data,const datatype::Datatype &mem_type) const;
 
   private:
-    ObjectHandle handle_;
     node::Link   parent_link_;
+    ObjectHandle handle_;
 
     template<typename T>
     void read(T &data,const datatype::Datatype &mem_type, const datatype::Datatype &file_type) const;

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ namespace hdf5 {`
`34`	`34`	`namespace attribute {`
`35`	`35`
`36`	`36`	`Attribute::Attribute(ObjectHandle &&handle,const node::Link &parent_link):`
`37`		`- handle_(std::move(handle)),`
`38`		`- parent_link_(parent_link)`
	`37`	`+ parent_link_(parent_link),`
	`38`	`+ handle_(std::move(handle))`
`39`	`39`	`{`
`40`	`40`	`}`
`41`	`41`